All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap3: pm: Use exported set_cr() instead of a custom one.
Date: Mon, 14 Feb 2011 16:08:10 -0800	[thread overview]
Message-ID: <871v3axiqd.fsf@ti.com> (raw)
In-Reply-To: <1297437132-1005-1-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Fri, 11 Feb 2011 20:42:11 +0530")

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> Remove the custom restore_control_register() and use the exported
> set_cr() instead to set the system control register(SCTRL) value.
>
> No functional change.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>

Tested/validated on ?

Kevin

> ---
>  arch/arm/mach-omap2/pm34xx.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 2f864e4..63a3e1d 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -311,11 +311,6 @@ static irqreturn_t prcm_interrupt_handler (int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
>  
> -static void restore_control_register(u32 val)
> -{
> -	__asm__ __volatile__ ("mcr p15, 0, %0, c1, c0, 0" : : "r" (val));
> -}
> -
>  /* Function to restore the table entry that was modified for enabling MMU */
>  static void restore_table_entry(void)
>  {
> @@ -337,7 +332,7 @@ static void restore_table_entry(void)
>  	control_reg_value = __raw_readl(scratchpad_address
>  					+ OMAP343X_CONTROL_REG_VALUE_OFFSET);
>  	/* This will enable caches and prediction */
> -	restore_control_register(control_reg_value);
> +	set_cr(control_reg_value);
>  }
>  
>  void omap_sram_idle(void)

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap3: pm: Use exported set_cr() instead of a custom one.
Date: Mon, 14 Feb 2011 16:08:10 -0800	[thread overview]
Message-ID: <871v3axiqd.fsf@ti.com> (raw)
In-Reply-To: <1297437132-1005-1-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Fri, 11 Feb 2011 20:42:11 +0530")

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> Remove the custom restore_control_register() and use the exported
> set_cr() instead to set the system control register(SCTRL) value.
>
> No functional change.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>

Tested/validated on ?

Kevin

> ---
>  arch/arm/mach-omap2/pm34xx.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 2f864e4..63a3e1d 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -311,11 +311,6 @@ static irqreturn_t prcm_interrupt_handler (int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
>  
> -static void restore_control_register(u32 val)
> -{
> -	__asm__ __volatile__ ("mcr p15, 0, %0, c1, c0, 0" : : "r" (val));
> -}
> -
>  /* Function to restore the table entry that was modified for enabling MMU */
>  static void restore_table_entry(void)
>  {
> @@ -337,7 +332,7 @@ static void restore_table_entry(void)
>  	control_reg_value = __raw_readl(scratchpad_address
>  					+ OMAP343X_CONTROL_REG_VALUE_OFFSET);
>  	/* This will enable caches and prediction */
> -	restore_control_register(control_reg_value);
> +	set_cr(control_reg_value);
>  }
>  
>  void omap_sram_idle(void)

  parent reply	other threads:[~2011-02-15  0:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 15:12 [PATCH] omap3: pm: Use exported set_cr() instead of a custom one Santosh Shilimkar
2011-02-11 15:12 ` Santosh Shilimkar
2011-02-11 15:12 ` [PATCH] omap3: cpuidle: Add description field to each C-state Santosh Shilimkar
2011-02-11 15:12   ` Santosh Shilimkar
2011-02-11 17:07   ` Jarkko Nikula
2011-02-11 17:07     ` Jarkko Nikula
2011-02-12  7:42     ` Santosh Shilimkar
2011-02-12  7:42       ` Santosh Shilimkar
2011-03-04  1:41   ` Kevin Hilman
2011-03-04  1:41     ` Kevin Hilman
2011-02-15  0:08 ` Kevin Hilman [this message]
2011-02-15  0:08   ` [PATCH] omap3: pm: Use exported set_cr() instead of a custom one Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871v3axiqd.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.