From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Jeff Garzik <jeff@garzik.org>,
Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>,
netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth Add SH7619 support
Date: Fri, 01 Aug 2008 15:32:28 +0000 [thread overview]
Message-ID: <871w18ycmr.wl%ysato@users.sourceforge.jp> (raw)
In-Reply-To: <29ab51dc0807312048hfa9cd88pb90d1a7520bb3f99@mail.gmail.com>
At Fri, 1 Aug 2008 12:48:27 +0900,
Nobuhiro Iwamatsu wrote:
>
> Hi, Sato-san.
>
> 2008/8/1 Yoshinori Sato <ysato@users.sourceforge.jp>:
> > SH7619 have same SH7710 ethernet controler.
> > Add support for sh_eth driver.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> >
>
> <snip>
>
> >
> > diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
> > index 45ad1b0..ca3cc5f 100644
> > --- a/drivers/net/sh_eth.h
> > +++ b/drivers/net/sh_eth.h
> > @@ -143,10 +143,11 @@
> >
>
> <snip>
>
> > +
> > +/* CPU endian from/to EDMAC endian */
> > +#if !defined(CONFIG_CPU_SUBTYPE_SH7619)
> > +#define cpu_to_edmac(x) cpu_to_le32(x)
> > +#define edmac_to_cpu(x) le32_to_cpu(x)
> > +#else
> > +#define cpu_to_edmac(x) cpu_to_be32(x)
> > +#define edmac_to_cpu(x) be32_to_cpu(x)
> > +#endif
> > +
> > #endif
> I think that this depends on an endian not CPU dependence.
I agree.
But I'm no idea.
Are you have good idea?
> Best regards,
> Nobuhiro
WARNING: multiple messages have this Message-ID (diff)
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: "Nobuhiro Iwamatsu" <iwamatsu@nigauri.org>
Cc: "Jeff Garzik" <jeff@garzik.org>,
"Nobuhiro Iwamatsu" <iwamatsu.nobuhiro@renesas.com>,
netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth Add SH7619 support
Date: Fri, 01 Aug 2008 11:32:28 -0400 [thread overview]
Message-ID: <871w18ycmr.wl%ysato@users.sourceforge.jp> (raw)
In-Reply-To: <29ab51dc0807312048hfa9cd88pb90d1a7520bb3f99@mail.gmail.com>
At Fri, 1 Aug 2008 12:48:27 +0900,
Nobuhiro Iwamatsu wrote:
>
> Hi, Sato-san.
>
> 2008/8/1 Yoshinori Sato <ysato@users.sourceforge.jp>:
> > SH7619 have same SH7710 ethernet controler.
> > Add support for sh_eth driver.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> >
>
> <snip>
>
> >
> > diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
> > index 45ad1b0..ca3cc5f 100644
> > --- a/drivers/net/sh_eth.h
> > +++ b/drivers/net/sh_eth.h
> > @@ -143,10 +143,11 @@
> >
>
> <snip>
>
> > +
> > +/* CPU endian from/to EDMAC endian */
> > +#if !defined(CONFIG_CPU_SUBTYPE_SH7619)
> > +#define cpu_to_edmac(x) cpu_to_le32(x)
> > +#define edmac_to_cpu(x) le32_to_cpu(x)
> > +#else
> > +#define cpu_to_edmac(x) cpu_to_be32(x)
> > +#define edmac_to_cpu(x) be32_to_cpu(x)
> > +#endif
> > +
> > #endif
> I think that this depends on an endian not CPU dependence.
I agree.
But I'm no idea.
Are you have good idea?
> Best regards,
> Nobuhiro
next prev parent reply other threads:[~2008-08-01 15:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 23:35 [PATCH] sh_eth Add SH7619 support Yoshinori Sato
2008-07-31 23:35 ` Yoshinori Sato
2008-08-01 3:48 ` Nobuhiro Iwamatsu
2008-08-01 3:48 ` Nobuhiro Iwamatsu
2008-08-01 15:32 ` Yoshinori Sato [this message]
2008-08-01 15:32 ` Yoshinori Sato
2008-08-02 7:30 ` Simon Horman
2008-08-02 7:30 ` Simon Horman
2008-08-02 15:34 ` Yoshinori Sato
2008-08-02 15:34 ` Yoshinori Sato
2008-08-03 19:23 ` Paul Mundt
2008-08-03 19:23 ` Paul Mundt
2008-08-05 19:21 ` Yoshinori Sato
2008-08-05 19:21 ` Yoshinori Sato
2008-08-06 2:36 ` Paul Mundt
2008-08-06 2:36 ` Paul Mundt
2008-08-06 7:38 ` Nobuhiro Iwamatsu
2008-08-06 7:38 ` Nobuhiro Iwamatsu
2008-08-06 23:49 ` [PATCH 1/2] sh_eth Add SH7619 support (driver) Yoshinori Sato
2008-08-06 23:49 ` Yoshinori Sato
2008-08-07 6:23 ` Jeff Garzik
2008-08-07 6:23 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871w18ycmr.wl%ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=iwamatsu.nobuhiro@renesas.com \
--cc=iwamatsu@nigauri.org \
--cc=jeff@garzik.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.