Re: [PATCH v8 5/7] clk: nuvoton: ma35d1: Reparent SYSPLL correctly

[Miquel Raynal <miquel.raynal@bootlin.com>]

On 13/10/2026 at 19:37:51 +02, Jerome Brunet <jbrunet@baylibre.com> wrote:

>> > So 2 possibilities:
>> > * You just need the .hw then I don't really get why you are doing it differently
>> >   for this clock ?
>> 
>> True.
>> 
>> > * OR, this is one of the those clock where you want to check DT first then
>> 
>> It is not.
>> 
>> >   fallback to a fixed clock, then yes you need parent_data. don't forget
>> >   the fw_name (which I did not see here) and use a local variable for that,
>> >   not a global
>> >
>> > Did I miss something ?
>> 
>> You got it absolutely right, and while implementing the change I
>> remember why I used the name instead of the hw pointer:
>> 
>>      clk_hw_register_fixed_rate_parent_hw() exists, but
>> devm_clk_hw_register_fixed_rate_parent_hw() did not.
>> 
>> So since it looks like most of these helpers have their devm_
>> counterpart, I will add this new helper in clk-provider.h. I plan on
>> doing that addition in this commit because I think that is what Boyd
>> used to prefer, but I can add it in a preparation patch that is your own
>> preference, I don't mind.
>
> Separate patch for the new helper please. Same series is fine.

Ack, thanks.