All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tests: add test for json-streamer.c error recovery
Date: Tue, 21 Apr 2026 13:18:26 +0200	[thread overview]
Message-ID: <87340o7e9p.fsf@pond.sub.org> (raw)
In-Reply-To: <CABgObfZQBj5tpi49E83fLs9+azwDE-aPiD_Jue7bzOXAPSXntg@mail.gmail.com> (Paolo Bonzini's message of "Mon, 20 Apr 2026 13:00:40 +0100")

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il lun 20 apr 2026, 12:53 Markus Armbruster <armbru@redhat.com> ha scritto:
>
>> > Before rewriting the error recovery code to work in a push parsing
>> > setup, make sure that we have tests for it.
>> >
>> > Cover various cases of invalid JSON, to check that structural
>> > recovery based on balanced brackets and braces works; and
>> > lexer-based recovery which documents "\f" as a sure fire
>> > way to reset the lexer.
>>
>> How is this related to tests/unit/check-qjson.c?
>>
>
> It tests at a lower level, talking directly to the json-streamer.c API.
> check-qjson.c only uses qobject_from_json() so it never tests more than one
> (attempted) JSON object in the input.

I see.

There's overlap between the two.  More on that in the review I'm about
to send.

Thanks!



  reply	other threads:[~2026-04-21 11:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  9:59 [PATCH] tests: add test for json-streamer.c error recovery Paolo Bonzini
2026-04-20 11:53 ` Markus Armbruster
2026-04-20 12:00   ` Paolo Bonzini
2026-04-21 11:18     ` Markus Armbruster [this message]
2026-04-21 11:29 ` Markus Armbruster
2026-04-21 22:39   ` Paolo Bonzini
2026-04-23  6:57     ` Markus Armbruster
2026-04-23  6:55 ` Markus Armbruster
2026-04-23 16:24   ` Paolo Bonzini
2026-04-23 17:30     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87340o7e9p.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.