All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] tests: add test for json-streamer.c error recovery
Date: Thu, 23 Apr 2026 19:30:01 +0200	[thread overview]
Message-ID: <878qadmvom.fsf@pond.sub.org> (raw)
In-Reply-To: <CABgObfa954MMVPH==coTOAFxt_dHUvSiDDVHFPnA3aTL6L8F1Q@mail.gmail.com> (Paolo Bonzini's message of "Thu, 23 Apr 2026 18:24:19 +0200")

Paolo Bonzini <pbonzini@redhat.com> writes:

> On Thu, Apr 23, 2026 at 8:56 AM Markus Armbruster <armbru@redhat.com> wrote:
>> > +    } else {
>> > +        qobject_unref(r->result);
>>
>> Unexpected calls to parse_emit() won't be detected as long as the last
>> one yields the expected expression.  Worth detecting?  I'm not quite
>> sure.  As far as I can tell, this is not reached at the moment.
>
> It's only covered in /errors/multiple_values of tests/unit/check-qson.c, yes.
>
>> The stupidest way to detect is to assert r->result is still null.
>
> I'm all for simplicity.
>
>> Can't do that if we want to cover parsing multiple JSON expressions in
>> sequence.  Collect all the results in an array?
>
> Yes, but not now. For now the assert will do.

Makes sense.  Thanks!



      reply	other threads:[~2026-04-23 17:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  9:59 [PATCH] tests: add test for json-streamer.c error recovery Paolo Bonzini
2026-04-20 11:53 ` Markus Armbruster
2026-04-20 12:00   ` Paolo Bonzini
2026-04-21 11:18     ` Markus Armbruster
2026-04-21 11:29 ` Markus Armbruster
2026-04-21 22:39   ` Paolo Bonzini
2026-04-23  6:57     ` Markus Armbruster
2026-04-23  6:55 ` Markus Armbruster
2026-04-23 16:24   ` Paolo Bonzini
2026-04-23 17:30     ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qadmvom.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.