[PATCH libevl] evl-test: return non-zero status when tests fail with -k

[PATCH libevl] evl-test: return non-zero status when tests fail with -k

[Tobias Schaffner]

The -k option of evl-test allows the test suite to continue running
after a test failure. However, evl-test currently exits with status 0
even if one or more tests have failed.

Track the failure status and return a non-zero exit code when any test
failed.

Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
---
 utils/evl-test | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/utils/evl-test b/utils/evl-test
index b2d3a7f..0d0ca81 100644
--- a/utils/evl-test
+++ b/utils/evl-test
@@ -68,6 +68,8 @@ if test x$do_list = xtrue; then
    exit 0
 fi
 
+result=0
+
 for t in $test_list; do
     test \! -x $t && echo "$(basename $0): $(basename $t): no such test" && exit 2
     # Swap stdout<->stderr for the test, capturing stderr into $log.
@@ -83,9 +85,10 @@ for t in $test_list; do
 	    echo "$(basename $t): no kernel support"
 	else
 	    echo "** $(basename $t): BROKEN"
-	    test x$keep_going = xfalse && exit $status
+	    result=$status
+	    test x$keep_going = xfalse && break
 	fi
     fi
 done
 
-exit 0
+exit $result
-- 
2.43.0

Re: [PATCH libevl] evl-test: return non-zero status when tests fail with -k

[Philippe Gerum]

Tobias Schaffner <tobias.schaffner@siemens.com> writes:

> The -k option of evl-test allows the test suite to continue running
> after a test failure. However, evl-test currently exits with status 0
> even if one or more tests have failed.
>
> Track the failure status and return a non-zero exit code when any test
> failed.
>
> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> ---
>  utils/evl-test | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/utils/evl-test b/utils/evl-test
> index b2d3a7f..0d0ca81 100644
> --- a/utils/evl-test
> +++ b/utils/evl-test
> @@ -68,6 +68,8 @@ if test x$do_list = xtrue; then
>     exit 0
>  fi
>  
> +result=0
> +
>  for t in $test_list; do
>      test \! -x $t && echo "$(basename $0): $(basename $t): no such test" && exit 2
>      # Swap stdout<->stderr for the test, capturing stderr into $log.
> @@ -83,9 +85,10 @@ for t in $test_list; do
>  	    echo "$(basename $t): no kernel support"
>  	else
>  	    echo "** $(basename $t): BROKEN"
> -	    test x$keep_going = xfalse && exit $status
> +	    result=$status
> +	    test x$keep_going = xfalse && break
>  	fi
>      fi
>  done
>  
> -exit 0
> +exit $result

Merged, thanks.

-- 
Philippe.