From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.li@nxp.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-iio@vger.kernel.org,
"Carlos Song" <carlos.song@nxp.com>
Subject: Re: [PATCH v2 2/4] i3c: master: svc: Add basic HDR mode support
Date: Mon, 29 Sep 2025 18:04:46 +0200 [thread overview]
Message-ID: <873485i6sh.fsf@bootlin.com> (raw)
In-Reply-To: <aNqr8+ehPehq41gw@lizhi-Precision-Tower-5810> (Frank Li's message of "Mon, 29 Sep 2025 11:55:31 -0400")
On 29/09/2025 at 11:55:31 -04, Frank Li <Frank.li@nxp.com> wrote:
> On Mon, Sep 29, 2025 at 05:38:03PM +0200, Miquel Raynal wrote:
>> Hi Frank,
>>
> ...
>
>> > @@ -1858,7 +1913,7 @@ static const struct i3c_master_controller_ops svc_i3c_master_ops = {
>> > .do_daa = svc_i3c_master_do_daa,
>> > .supports_ccc_cmd = svc_i3c_master_supports_ccc_cmd,
>> > .send_ccc_cmd = svc_i3c_master_send_ccc_cmd,
>> > - .priv_xfers = svc_i3c_master_priv_xfers,
>> > + .i3c_xfers = svc_i3c_master_i3c_xfers,
>>
>> Didn't you change this name in patch 1? If you kept both naming, it's
>> fine, otherwise you must do the switch in patch 1 as well to make sure
>> you don't break the build in the middle of the series.
>
> We keep both API for while. After first patch apply, I change all drivers
> to i3c_xfers, then remove old .priv_xfers.
Fine. Maybe mark it deprecated with a comment in the core? (I haven't
checked).
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.li@nxp.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-iio@vger.kernel.org,
"Carlos Song" <carlos.song@nxp.com>
Subject: Re: [PATCH v2 2/4] i3c: master: svc: Add basic HDR mode support
Date: Mon, 29 Sep 2025 18:04:46 +0200 [thread overview]
Message-ID: <873485i6sh.fsf@bootlin.com> (raw)
In-Reply-To: <aNqr8+ehPehq41gw@lizhi-Precision-Tower-5810> (Frank Li's message of "Mon, 29 Sep 2025 11:55:31 -0400")
On 29/09/2025 at 11:55:31 -04, Frank Li <Frank.li@nxp.com> wrote:
> On Mon, Sep 29, 2025 at 05:38:03PM +0200, Miquel Raynal wrote:
>> Hi Frank,
>>
> ...
>
>> > @@ -1858,7 +1913,7 @@ static const struct i3c_master_controller_ops svc_i3c_master_ops = {
>> > .do_daa = svc_i3c_master_do_daa,
>> > .supports_ccc_cmd = svc_i3c_master_supports_ccc_cmd,
>> > .send_ccc_cmd = svc_i3c_master_send_ccc_cmd,
>> > - .priv_xfers = svc_i3c_master_priv_xfers,
>> > + .i3c_xfers = svc_i3c_master_i3c_xfers,
>>
>> Didn't you change this name in patch 1? If you kept both naming, it's
>> fine, otherwise you must do the switch in patch 1 as well to make sure
>> you don't break the build in the middle of the series.
>
> We keep both API for while. After first patch apply, I change all drivers
> to i3c_xfers, then remove old .priv_xfers.
Fine. Maybe mark it deprecated with a comment in the core? (I haven't
checked).
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-09-29 16:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 14:30 [PATCH v2 0/4] i3c: Add basic HDR mode support Frank Li
2025-09-24 14:30 ` Frank Li
2025-09-24 14:30 ` [PATCH v2 1/4] i3c: Add HDR API support Frank Li
2025-09-24 14:30 ` Frank Li
2025-09-24 14:30 ` [PATCH v2 2/4] i3c: master: svc: Add basic HDR mode support Frank Li
2025-09-24 14:30 ` Frank Li
2025-09-29 15:38 ` Miquel Raynal
2025-09-29 15:38 ` Miquel Raynal
2025-09-29 15:55 ` Frank Li
2025-09-29 15:55 ` Frank Li
2025-09-29 16:04 ` Miquel Raynal [this message]
2025-09-29 16:04 ` Miquel Raynal
2025-09-24 14:30 ` [PATCH v2 3/4] dt-bindings: trivial-devices: add MEMSIC 3-axis magnetometer Frank Li
2025-09-24 14:30 ` Frank Li
2025-09-24 14:30 ` [PATCH v2 4/4] iio: magnetometer: Add mmc5633 sensor Frank Li
2025-09-24 14:30 ` Frank Li
2025-09-24 21:22 ` Adrian Fluturel
2025-09-25 4:19 ` Frank Li
2025-09-27 18:58 ` Jonathan Cameron
2025-09-27 18:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873485i6sh.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy@kernel.org \
--cc=carlos.song@nxp.com \
--cc=dlechner@baylibre.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.