From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libcurl: fix build w/ threads + c-ares
Date: Sun, 08 Jun 2025 06:45:15 +0300 [thread overview]
Message-ID: <8734cazyk4.fsf@tarshish> (raw)
In-Reply-To: <20250607190703.2408025-1-peter@korsgaard.com> (Peter Korsgaard's message of "Sat, 7 Jun 2025 21:07:03 +0200")
Hi Peter,
On Sat, Jun 07 2025, Peter Korsgaard wrote:
> Fixes:
> https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/
>
> Since curl 8.14.0 with commit d364f1347f05 ("configure: catch asking for
> double resolver without https-rr"), configure errors out when
> --enabled-threaded-resolver is used together with --enable-ares (unless the
> experimental HTTPS-RR support is enabled), so disable the threaded resolver
> when c-ares is enabled.
>
> https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> package/libcurl/libcurl.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk
> index 8501910ac5..5a3a668f06 100644
> --- a/package/libcurl/libcurl.mk
> +++ b/package/libcurl/libcurl.mk
> @@ -36,7 +36,9 @@ LIBCURL_CONF_OPTS = \
> # https://nvd.nist.gov/vuln/detail/CVE-2024-32928
> LIBCURL_IGNORE_CVES += CVE-2024-32928
>
> -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +# threaded resolver cannot be used with c-ares
> +# https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)x$(BR2_PACKAGE_C_ARES)),yx)
> LIBCURL_CONF_OPTS += --enable-threaded-resolver
> else
> LIBCURL_CONF_OPTS += --disable-threaded-resolver
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-06-08 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 19:07 [Buildroot] [PATCH] package/libcurl: fix build w/ threads + c-ares Peter Korsgaard via buildroot
2025-06-08 3:45 ` Baruch Siach via buildroot [this message]
2025-06-08 11:30 ` Julien Olivain
2025-06-12 20:26 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734cazyk4.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.