[Buildroot] [PATCH] package/libcurl: fix build w/ threads + c-ares

[Buildroot] [PATCH] package/libcurl: fix build w/ threads + c-ares

[Peter Korsgaard via buildroot]

Fixes:
https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/

Since curl 8.14.0 with commit d364f1347f05 ("configure: catch asking for
double resolver without https-rr"), configure errors out when
--enabled-threaded-resolver is used together with --enable-ares (unless the
experimental HTTPS-RR support is enabled), so disable the threaded resolver
when c-ares is enabled.

https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/libcurl/libcurl.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk
index 8501910ac5..5a3a668f06 100644
--- a/package/libcurl/libcurl.mk
+++ b/package/libcurl/libcurl.mk
@@ -36,7 +36,9 @@ LIBCURL_CONF_OPTS = \
 # https://nvd.nist.gov/vuln/detail/CVE-2024-32928
 LIBCURL_IGNORE_CVES += CVE-2024-32928
 
-ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+# threaded resolver cannot be used with c-ares
+# https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)x$(BR2_PACKAGE_C_ARES)),yx)
 LIBCURL_CONF_OPTS += --enable-threaded-resolver
 else
 LIBCURL_CONF_OPTS += --disable-threaded-resolver
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libcurl: fix build w/ threads + c-ares

[Baruch Siach via buildroot]

Hi Peter,

On Sat, Jun 07 2025, Peter Korsgaard wrote:

> Fixes:
> https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/
>
> Since curl 8.14.0 with commit d364f1347f05 ("configure: catch asking for
> double resolver without https-rr"), configure errors out when
> --enabled-threaded-resolver is used together with --enable-ares (unless the
> experimental HTTPS-RR support is enabled), so disable the threaded resolver
> when c-ares is enabled.
>
> https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Reviewed-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

> ---
>  package/libcurl/libcurl.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk
> index 8501910ac5..5a3a668f06 100644
> --- a/package/libcurl/libcurl.mk
> +++ b/package/libcurl/libcurl.mk
> @@ -36,7 +36,9 @@ LIBCURL_CONF_OPTS = \
>  # https://nvd.nist.gov/vuln/detail/CVE-2024-32928
>  LIBCURL_IGNORE_CVES += CVE-2024-32928
>  
> -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +# threaded resolver cannot be used with c-ares
> +# https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)x$(BR2_PACKAGE_C_ARES)),yx)
>  LIBCURL_CONF_OPTS += --enable-threaded-resolver
>  else
>  LIBCURL_CONF_OPTS += --disable-threaded-resolver

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libcurl: fix build w/ threads + c-ares

[Julien Olivain]

On 07/06/2025 21:07, Peter Korsgaard via buildroot wrote:
> Fixes:
> https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/
> 
> Since curl 8.14.0 with commit d364f1347f05 ("configure: catch asking 
> for
> double resolver without https-rr"), configure errors out when
> --enabled-threaded-resolver is used together with --enable-ares (unless 
> the
> experimental HTTPS-RR support is enabled), so disable the threaded 
> resolver
> when c-ares is enabled.
> 
> https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libcurl: fix build w/ threads + c-ares

[Arnout Vandecappelle via buildroot]

On 07/06/2025 21:07, Peter Korsgaard via buildroot wrote:
> Fixes:
> https://autobuild.buildroot.net/results/680b825b93989e6aef247593c198094a6ed916f7/
> 
> Since curl 8.14.0 with commit d364f1347f05 ("configure: catch asking for
> double resolver without https-rr"), configure errors out when
> --enabled-threaded-resolver is used together with --enable-ares (unless the
> experimental HTTPS-RR support is enabled), so disable the threaded resolver
> when c-ares is enabled.
> 
> https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   package/libcurl/libcurl.mk | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk
> index 8501910ac5..5a3a668f06 100644
> --- a/package/libcurl/libcurl.mk
> +++ b/package/libcurl/libcurl.mk
> @@ -36,7 +36,9 @@ LIBCURL_CONF_OPTS = \
>   # https://nvd.nist.gov/vuln/detail/CVE-2024-32928
>   LIBCURL_IGNORE_CVES += CVE-2024-32928
>   
> -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +# threaded resolver cannot be used with c-ares
> +# https://github.com/curl/curl/commit/d364f1347f05c53eea5d25a15b4ad8a62ecc85b8
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)x$(BR2_PACKAGE_C_ARES)),yx)
>   LIBCURL_CONF_OPTS += --enable-threaded-resolver
>   else
>   LIBCURL_CONF_OPTS += --disable-threaded-resolver

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot