All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Maxim Kochetkov <fido_max@inbox.ru>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	peterz@infradead.org, elver@google.com, namcao@linutronix.de,
	samuel.holland@sifive.com, daniel.lezcano@linaro.org,
	apatel@ventanamicro.com
Cc: Maxim Kochetkov <fido_max@inbox.ru>
Subject: Re: [PATCH 1/1] time/sched_clock: move sched_clock_register() out of .init section
Date: Mon, 07 Apr 2025 08:26:11 +0200	[thread overview]
Message-ID: <8734ekwkqk.ffs@tglx> (raw)
In-Reply-To: <20250404050540.13507-1-fido_max@inbox.ru>

On Fri, Apr 04 2025 at 08:05, Maxim Kochetkov wrote:
> The sched_clock_register() is widely used by clocksource timer
> drivers. The __init prefix forces them to be initialized using
> macro TIMER_OF_DECLARE with __init prefixed function.

No, it does not. It requires that they are built in, not more.

> Clocksource devices can be consumers of some external irq, clocks,
> resets, e.t.c. Such devices can't be correctly probed if this
> dependencies are provided by platform drivers. Because of regular
> platform devices are not probed at this moment.
>
> We can convert clocksource drivers to platform device drivers to
> fix this issue, but __init prefix in sched_clock_register()
> prevents it.

Again. It does not. What the __init prefix prevents is that the driver
can be built as a module and loaded late.

> So lets drop __init prefix to allow platform device drivers to use
> sched_clock_register().

s/So let's//

"So let's" means nothing.

Also this has nothing to do with platform device drivers. It's all about
modules and nothing else.

Thanks,

        tglx

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Maxim Kochetkov <fido_max@inbox.ru>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	peterz@infradead.org, elver@google.com, namcao@linutronix.de,
	samuel.holland@sifive.com, daniel.lezcano@linaro.org,
	apatel@ventanamicro.com
Cc: Maxim Kochetkov <fido_max@inbox.ru>
Subject: Re: [PATCH 1/1] time/sched_clock: move sched_clock_register() out of .init section
Date: Mon, 07 Apr 2025 08:26:11 +0200	[thread overview]
Message-ID: <8734ekwkqk.ffs@tglx> (raw)
In-Reply-To: <20250404050540.13507-1-fido_max@inbox.ru>

On Fri, Apr 04 2025 at 08:05, Maxim Kochetkov wrote:
> The sched_clock_register() is widely used by clocksource timer
> drivers. The __init prefix forces them to be initialized using
> macro TIMER_OF_DECLARE with __init prefixed function.

No, it does not. It requires that they are built in, not more.

> Clocksource devices can be consumers of some external irq, clocks,
> resets, e.t.c. Such devices can't be correctly probed if this
> dependencies are provided by platform drivers. Because of regular
> platform devices are not probed at this moment.
>
> We can convert clocksource drivers to platform device drivers to
> fix this issue, but __init prefix in sched_clock_register()
> prevents it.

Again. It does not. What the __init prefix prevents is that the driver
can be built as a module and loaded late.

> So lets drop __init prefix to allow platform device drivers to use
> sched_clock_register().

s/So let's//

"So let's" means nothing.

Also this has nothing to do with platform device drivers. It's all about
modules and nothing else.

Thanks,

        tglx

  reply	other threads:[~2025-04-07  6:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  5:05 [PATCH 1/1] time/sched_clock: move sched_clock_register() out of .init section Maxim Kochetkov
2025-04-04  5:05 ` Maxim Kochetkov
2025-04-07  6:26 ` Thomas Gleixner [this message]
2025-04-07  6:26   ` Thomas Gleixner
2025-04-07  7:25   ` Maxim Kochetkov
2025-04-07  7:25     ` Maxim Kochetkov
2025-04-07 21:11     ` Thomas Gleixner
2025-04-07 21:11       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734ekwkqk.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=apatel@ventanamicro.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=elver@google.com \
    --cc=fido_max@inbox.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=namcao@linutronix.de \
    --cc=peterz@infradead.org \
    --cc=samuel.holland@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.