Re: [PATCH v3 0/5] rust: Add bug/warn abstractions

From: Andreas Hindborg <a.hindborg@kernel.org>
To: "FUJITA Tomonori" <fujita.tomonori@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,  <rust-for-linux@vger.kernel.org>,
	<x86@kernel.org>,  <linux-riscv@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	 <loongarch@lists.linux.dev>, <tglx@linutronix.de>,
	 <mingo@redhat.com>,  <bp@alien8.de>,
	<dave.hansen@linux.intel.com>,  <peterz@infradead.org>,
	 <hpa@zytor.com>, <paul.walmsley@sifive.com>,
	 <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	 <catalin.marinas@arm.com>,  <will@kernel.org>,
	<chenhuacai@kernel.org>,  <kernel@xen0n.name>,
	<tangyouling@loongson.cn>,  <hejinyang@loongson.cn>,
	<yangtiezhu@loongson.cn>,  <ojeda@kernel.org>,
	 <alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
	 <gary@garyguo.net>,  <bjorn3_gh@protonmail.com>,
	<benno.lossin@proton.me>,  <aliceryhl@google.com>,
	 <tmgross@umich.edu>
Subject: Re: [PATCH v3 0/5] rust: Add bug/warn abstractions
Date: Wed, 26 Feb 2025 20:39:45 +0100	[thread overview]
Message-ID: <8734g0v6ke.fsf@kernel.org> (raw)
In-Reply-To: <20250213135759.190006-1-fujita.tomonori@gmail.com> (FUJITA Tomonori's message of "Thu, 13 Feb 2025 22:57:54 +0900")

Hi Fujita,

"FUJITA Tomonori" <fujita.tomonori@gmail.com> writes:

> This patchset adds warn_on and warn_on_once macros with the bug/warn
> abstraction.
>
> Wrapping C's BUG/WARN macros does not work well for x86, RISC-V,
> ARM64, and LoongArch. Rust code needs to directly execute the same
> assembly code used on the C side. To avoid duplicating the assembly
> code, this approach mirrors what the static branch code does: it
> generates the assembly code for Rust using the C preprocessor at
> compile time.
>
> The 1st to 4th patches export the BUG/WARN assembly code for Rust on
> each architecture, with no functional changes on the C side. The
> changes for x86 and RISC-V are straightforward. However, the ARM64 and
> LoongArch assembly code are designed differently; they are used by
> both C inline assembly and assembly code. As a result, sharing this
> code with Rust is complicated.
>
> The last patch adds the bug abstraction with warn_on and warn_on_once
> implementations.
>
> This has been tested on x86, ARM64, and RISC-V (QEMU), with only a
> compile test performed for LoongArch.
>
> The assembly code can be used for both BUG and WARN, but currently
> only supports warn_on and warn_on_once. I will work on the remaining
> functionality after this abstraction is merged.
>

How does this series compare/overlap with [1] ?

Best regards,
Andreas Hindborg

[1] https://lore.kernel.org/all/20241126-pr_once_macros-v4-0-410b8ca9643e@tuta.io/