All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] docs: submit-checklist: Expand on build tests against different word sizes
@ 2025-01-30  7:28 Akira Yokosawa
  2025-02-10 18:01 ` Jonathan Corbet
  0 siblings, 1 reply; 2+ messages in thread
From: Akira Yokosawa @ 2025-01-30  7:28 UTC (permalink / raw)
  To: Jonathan Corbet; +Cc: Randy Dunlap, linux-doc, Akira Yokosawa

Existing sentence on cross-compilation that mentions ppc64 does not
make much sense in today's perspective.

Expand it for the benefits of testing against architectures of
different word sizes and endianness.

Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
---
v2: Split out change in the English doc from v1 [1].
    Keep Randy's Rb tag (as it was meant for the change in English doc).

[1] https://lore.kernel.org/20250128102805.112691-2-akiyks@gmail.com/
--
 Documentation/process/submit-checklist.rst | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/process/submit-checklist.rst b/Documentation/process/submit-checklist.rst
index e531dd504b6c..88b6358258d7 100644
--- a/Documentation/process/submit-checklist.rst
+++ b/Documentation/process/submit-checklist.rst
@@ -91,9 +91,12 @@ Build your code
      fix any issues.
 
 2) Builds on multiple CPU architectures by using local cross-compile tools
-   or some other build farm. Note that ppc64 is a good architecture for
-   cross-compilation checking because it tends to use ``unsigned long`` for
-   64-bit quantities.
+   or some other build farm.
+   Note that testing against architectures of different word sizes
+   (32- and 64-bit) and different endianness (big- and little-) is effective
+   in catching various portability issues due to false assumptions on
+   representable quantity range, data alignment, or endianness, among
+   others.
 
 3) Newly-added code has been compiled with ``gcc -W`` (use
    ``make KCFLAGS=-W``).  This will generate lots of noise, but is good

base-commit: 35ddd9f3c132a36856f58088bab06e873c1af871
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] docs: submit-checklist: Expand on build tests against different word sizes
  2025-01-30  7:28 [PATCH v2] docs: submit-checklist: Expand on build tests against different word sizes Akira Yokosawa
@ 2025-02-10 18:01 ` Jonathan Corbet
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2025-02-10 18:01 UTC (permalink / raw)
  To: Akira Yokosawa; +Cc: Randy Dunlap, linux-doc, Akira Yokosawa

Akira Yokosawa <akiyks@gmail.com> writes:

> Existing sentence on cross-compilation that mentions ppc64 does not
> make much sense in today's perspective.
>
> Expand it for the benefits of testing against architectures of
> different word sizes and endianness.
>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> v2: Split out change in the English doc from v1 [1].
>     Keep Randy's Rb tag (as it was meant for the change in English doc).
>
> [1] https://lore.kernel.org/20250128102805.112691-2-akiyks@gmail.com/
> --
>  Documentation/process/submit-checklist.rst | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/process/submit-checklist.rst b/Documentation/process/submit-checklist.rst
> index e531dd504b6c..88b6358258d7 100644
> --- a/Documentation/process/submit-checklist.rst
> +++ b/Documentation/process/submit-checklist.rst
> @@ -91,9 +91,12 @@ Build your code
>       fix any issues.
>  
>  2) Builds on multiple CPU architectures by using local cross-compile tools
> -   or some other build farm. Note that ppc64 is a good architecture for
> -   cross-compilation checking because it tends to use ``unsigned long`` for
> -   64-bit quantities.
> +   or some other build farm.
> +   Note that testing against architectures of different word sizes
> +   (32- and 64-bit) and different endianness (big- and little-) is effective
> +   in catching various portability issues due to false assumptions on
> +   representable quantity range, data alignment, or endianness, among
> +   others.
>  

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-10 18:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-30  7:28 [PATCH v2] docs: submit-checklist: Expand on build tests against different word sizes Akira Yokosawa
2025-02-10 18:01 ` Jonathan Corbet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.