* [PATCH] KVM: arm64: Pass on SVE mapping failures
@ 2024-11-12 10:56 James Clark
2024-11-12 15:40 ` Marc Zyngier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: James Clark @ 2024-11-12 10:56 UTC (permalink / raw)
To: tabba, maz, kvmarm, oliver.upton
Cc: James Clark, Joey Gouly, Suzuki K Poulose, Zenghui Yu,
Catalin Marinas, Will Deacon, Pierre-Clément Tosi,
linux-arm-kernel, linux-kernel
This function can fail but its return value isn't passed onto the
caller. Presumably this could result in a broken state.
Fixes: 66d5b53e20a6 ("KVM: arm64: Allocate memory mapped at hyp for host sve state in pKVM")
Signed-off-by: James Clark <james.clark@linaro.org>
---
arch/arm64/kvm/hyp/nvhe/setup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/kvm/hyp/nvhe/setup.c b/arch/arm64/kvm/hyp/nvhe/setup.c
index 8fec099c2775..cbdd18cd3f98 100644
--- a/arch/arm64/kvm/hyp/nvhe/setup.c
+++ b/arch/arm64/kvm/hyp/nvhe/setup.c
@@ -146,8 +146,7 @@ static int recreate_hyp_mappings(phys_addr_t phys, unsigned long size,
return ret;
}
- pkvm_create_host_sve_mappings();
- return 0;
+ return pkvm_create_host_sve_mappings();
}
static void update_nvhe_init_params(void)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Pass on SVE mapping failures
2024-11-12 10:56 [PATCH] KVM: arm64: Pass on SVE mapping failures James Clark
@ 2024-11-12 15:40 ` Marc Zyngier
2024-11-12 15:41 ` Fuad Tabba
2024-11-12 19:13 ` Oliver Upton
2 siblings, 0 replies; 4+ messages in thread
From: Marc Zyngier @ 2024-11-12 15:40 UTC (permalink / raw)
To: James Clark
Cc: tabba, kvmarm, oliver.upton, Joey Gouly, Suzuki K Poulose,
Zenghui Yu, Catalin Marinas, Will Deacon,
Pierre-Clément Tosi, linux-arm-kernel, linux-kernel
On Tue, 12 Nov 2024 10:56:03 +0000,
James Clark <james.clark@linaro.org> wrote:
>
> This function can fail but its return value isn't passed onto the
> caller. Presumably this could result in a broken state.
>
> Fixes: 66d5b53e20a6 ("KVM: arm64: Allocate memory mapped at hyp for host sve state in pKVM")
> Signed-off-by: James Clark <james.clark@linaro.org>
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Pass on SVE mapping failures
2024-11-12 10:56 [PATCH] KVM: arm64: Pass on SVE mapping failures James Clark
2024-11-12 15:40 ` Marc Zyngier
@ 2024-11-12 15:41 ` Fuad Tabba
2024-11-12 19:13 ` Oliver Upton
2 siblings, 0 replies; 4+ messages in thread
From: Fuad Tabba @ 2024-11-12 15:41 UTC (permalink / raw)
To: James Clark
Cc: maz, kvmarm, oliver.upton, Joey Gouly, Suzuki K Poulose,
Zenghui Yu, Catalin Marinas, Will Deacon,
Pierre-Clément Tosi, linux-arm-kernel, linux-kernel
On Tue, 12 Nov 2024 at 10:56, James Clark <james.clark@linaro.org> wrote:
>
> This function can fail but its return value isn't passed onto the
> caller. Presumably this could result in a broken state.
>
> Fixes: 66d5b53e20a6 ("KVM: arm64: Allocate memory mapped at hyp for host sve state in pKVM")
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> arch/arm64/kvm/hyp/nvhe/setup.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/setup.c b/arch/arm64/kvm/hyp/nvhe/setup.c
> index 8fec099c2775..cbdd18cd3f98 100644
> --- a/arch/arm64/kvm/hyp/nvhe/setup.c
> +++ b/arch/arm64/kvm/hyp/nvhe/setup.c
> @@ -146,8 +146,7 @@ static int recreate_hyp_mappings(phys_addr_t phys, unsigned long size,
> return ret;
> }
>
> - pkvm_create_host_sve_mappings();
> - return 0;
> + return pkvm_create_host_sve_mappings();
> }
Reviewed-by: Fuad Tabba <tabba@google.com>
Thanks,
/fuad
>
> static void update_nvhe_init_params(void)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Pass on SVE mapping failures
2024-11-12 10:56 [PATCH] KVM: arm64: Pass on SVE mapping failures James Clark
2024-11-12 15:40 ` Marc Zyngier
2024-11-12 15:41 ` Fuad Tabba
@ 2024-11-12 19:13 ` Oliver Upton
2 siblings, 0 replies; 4+ messages in thread
From: Oliver Upton @ 2024-11-12 19:13 UTC (permalink / raw)
To: tabba, maz, kvmarm, James Clark
Cc: Oliver Upton, Joey Gouly, Suzuki K Poulose, Zenghui Yu,
Catalin Marinas, Will Deacon, Pierre-Clément Tosi,
linux-arm-kernel, linux-kernel
On Tue, 12 Nov 2024 10:56:03 +0000, James Clark wrote:
> This function can fail but its return value isn't passed onto the
> caller. Presumably this could result in a broken state.
>
>
Applied to next, thanks!
[1/1] KVM: arm64: Pass on SVE mapping failures
https://git.kernel.org/kvmarm/kvmarm/c/60ad25e14ab5
--
Best,
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-12 19:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 10:56 [PATCH] KVM: arm64: Pass on SVE mapping failures James Clark
2024-11-12 15:40 ` Marc Zyngier
2024-11-12 15:41 ` Fuad Tabba
2024-11-12 19:13 ` Oliver Upton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.