All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Ivan Orlov <ivan.orlov0322@gmail.com>,
	Naveen N Rao <naveen@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Takashi Iwai <tiwai@suse.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	linux-tegra@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Daniel Mack <daniel@zonque.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] sound: Switch back to struct platform_driver::remove()
Date: Tue, 29 Oct 2024 10:05:21 +0100	[thread overview]
Message-ID: <8734kf2sa6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241029073748.508077-2-u.kleine-koenig@baylibre.com>

On Tue, 29 Oct 2024 08:37:47 +0100,
Uwe Kleine-König wrote:
> 
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
> 
> Convert all platform drivers below sound to use .remove(), with
> the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
> 
> On the way do a few whitespace changes to make indention consistent.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> I did a single patch for all of sound. sound/soc was already converted
> separately, so isn't mixed in here. While I usually prefer to do one
> logical change per patch, this seems to be overengineering here as the
> individual changes are really trivial and shouldn't be much in the way
> for stable backports. But I'll happily split the patch if you prefer it
> split.

It's fine to do this in a single shot.

I suppose this can be applied for 6.13, not necessarily to be merged
for 6.12-rc?


thanks,

Takashi


WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Ivan Orlov <ivan.orlov0322@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Naveen N Rao <naveen@kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] sound: Switch back to struct platform_driver::remove()
Date: Tue, 29 Oct 2024 10:05:21 +0100	[thread overview]
Message-ID: <8734kf2sa6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241029073748.508077-2-u.kleine-koenig@baylibre.com>

On Tue, 29 Oct 2024 08:37:47 +0100,
Uwe Kleine-König wrote:
> 
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
> 
> Convert all platform drivers below sound to use .remove(), with
> the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
> 
> On the way do a few whitespace changes to make indention consistent.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> I did a single patch for all of sound. sound/soc was already converted
> separately, so isn't mixed in here. While I usually prefer to do one
> logical change per patch, this seems to be overengineering here as the
> individual changes are really trivial and shouldn't be much in the way
> for stable backports. But I'll happily split the patch if you prefer it
> split.

It's fine to do this in a single shot.

I suppose this can be applied for 6.13, not necessarily to be merged
for 6.12-rc?


thanks,

Takashi

  reply	other threads:[~2024-10-29  9:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29  7:37 [PATCH] sound: Switch back to struct platform_driver::remove() Uwe Kleine-König
2024-10-29  7:37 ` Uwe Kleine-König
2024-10-29  9:05 ` Takashi Iwai [this message]
2024-10-29  9:05   ` Takashi Iwai
2024-10-29  9:23   ` Uwe Kleine-König
2024-10-29  9:23     ` Uwe Kleine-König
2024-10-30 13:49 ` Takashi Iwai
2024-10-30 13:49   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734kf2sa6.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=ivan.orlov0322@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=naveen@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=perex@perex.cz \
    --cc=robert.jarzmik@free.fr \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.