All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org, "Michael Roth" <michael.roth@amd.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths
Date: Wed, 07 Aug 2024 13:21:25 +0200	[thread overview]
Message-ID: <8734ngwpca.fsf@pond.sub.org> (raw)
In-Reply-To: <ZrNTxb8go0xqfE3R@redhat.com> ("Daniel P. Berrangé"'s message of "Wed, 7 Aug 2024 12:00:21 +0100")

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé <berrange@redhat.com> writes:

[...]

>> > It is confusing that we have both shared stuff and QMP schema
>> > only stuff under the same location.
>> 
>> Which stuff in which location?
>
> There are multiple directories with 'qapi' in their name
>
>  - $SRC/include/qapi - all generic stuff for any consumer of QAPI
>  - $SRC/qapi - impl of generic stuff from $SRC/include/qapi, but
>                also the QMP schema for machine emulator
>  - $BUILD/qapi - generated code for QMP schema for machine emulator

   - scripts/qapi - the generator code

>
> I find it confusing that we have both generic QAPI code and the main
> machine emulator QMP schema in directories sharing the same 'qapi'
> name.

Got it.

Lack of separation between generic C infrastructure and specific schema
hasn't really annoyed me.  Possibly because the two are, for better or
worse, joined at the hip.  Except for the use of "qapi:" in commit
message titles; there I've at times felt a slight urge to distinguish
between schema work, C infrastructure work, and generator work.

Of course, other people's confusion trumps my non-annoyance.



  reply	other threads:[~2024-08-07 11:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07  9:34 [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths Philippe Mathieu-Daudé
2024-08-07  9:44 ` Daniel P. Berrangé
2024-08-07 10:50   ` Markus Armbruster
2024-08-07 11:00     ` Daniel P. Berrangé
2024-08-07 11:21       ` Markus Armbruster [this message]
2024-08-07 11:25         ` Daniel P. Berrangé
2024-08-07 12:01           ` Markus Armbruster
2024-08-07 12:09             ` Philippe Mathieu-Daudé
2024-08-08  8:53     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734ngwpca.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.