From: Baruch Siach <baruch@tkos.co.il>
To: "Christian König" <christian.koenig@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] doc: dma-buf: fix grammar typo
Date: Mon, 15 Apr 2024 18:40:25 +0300 [thread overview]
Message-ID: <8734rmws2b.fsf@tarshish> (raw)
In-Reply-To: <cba06e6f-06cb-4b0e-88df-d25d278fb4f2@amd.com>
Hi Christian,
On Mon, Apr 15 2024, Christian König wrote:
> Am 14.04.24 um 15:07 schrieb Baruch Siach:
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> Documentation/driver-api/dma-buf.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
>> index 0c153d79ccc4..29abf1eebf9f 100644
>> --- a/Documentation/driver-api/dma-buf.rst
>> +++ b/Documentation/driver-api/dma-buf.rst
>> @@ -77,7 +77,7 @@ consider though:
>> the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other
>> llseek operation will report -EINVAL.
>> - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE
>> for all
>> + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all
>
> Looks valid of hand, but checkpatch.pl complains about 2 errors (missing
> commit message for example) and a warning.
>
> Please fix and resend.
I only get the checkpatch.pl output listed below with one warning. What
parameters do you use?
WARNING: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit d242a446258e ("doc: dma-buf: fix grammar typo") has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Thanks,
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2024-04-15 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 13:07 [PATCH] doc: dma-buf: fix grammar typo Baruch Siach
2024-04-15 14:35 ` Christian König
2024-04-15 15:40 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734rmws2b.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.