* [PATCH] doc: dma-buf: fix grammar typo
@ 2024-04-14 13:07 Baruch Siach
2024-04-15 14:35 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2024-04-14 13:07 UTC (permalink / raw)
To: Sumit Semwal, Christian König
Cc: linux-media, dri-devel, linaro-mm-sig, Baruch Siach
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
Documentation/driver-api/dma-buf.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
index 0c153d79ccc4..29abf1eebf9f 100644
--- a/Documentation/driver-api/dma-buf.rst
+++ b/Documentation/driver-api/dma-buf.rst
@@ -77,7 +77,7 @@ consider though:
the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other
llseek operation will report -EINVAL.
- If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE for all
+ If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all
cases. Userspace can use this to detect support for discovering the dma-buf
size using llseek.
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: dma-buf: fix grammar typo
2024-04-14 13:07 [PATCH] doc: dma-buf: fix grammar typo Baruch Siach
@ 2024-04-15 14:35 ` Christian König
2024-04-15 15:40 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2024-04-15 14:35 UTC (permalink / raw)
To: Baruch Siach, Sumit Semwal; +Cc: linux-media, dri-devel, linaro-mm-sig
Am 14.04.24 um 15:07 schrieb Baruch Siach:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> Documentation/driver-api/dma-buf.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
> index 0c153d79ccc4..29abf1eebf9f 100644
> --- a/Documentation/driver-api/dma-buf.rst
> +++ b/Documentation/driver-api/dma-buf.rst
> @@ -77,7 +77,7 @@ consider though:
> the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other
> llseek operation will report -EINVAL.
>
> - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE for all
> + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all
Looks valid of hand, but checkpatch.pl complains about 2 errors (missing
commit message for example) and a warning.
Please fix and resend.
Thanks,
Christian.
> cases. Userspace can use this to detect support for discovering the dma-buf
> size using llseek.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: dma-buf: fix grammar typo
2024-04-15 14:35 ` Christian König
@ 2024-04-15 15:40 ` Baruch Siach
0 siblings, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2024-04-15 15:40 UTC (permalink / raw)
To: Christian König; +Cc: Sumit Semwal, linux-media, dri-devel, linaro-mm-sig
Hi Christian,
On Mon, Apr 15 2024, Christian König wrote:
> Am 14.04.24 um 15:07 schrieb Baruch Siach:
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> Documentation/driver-api/dma-buf.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
>> index 0c153d79ccc4..29abf1eebf9f 100644
>> --- a/Documentation/driver-api/dma-buf.rst
>> +++ b/Documentation/driver-api/dma-buf.rst
>> @@ -77,7 +77,7 @@ consider though:
>> the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other
>> llseek operation will report -EINVAL.
>> - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE
>> for all
>> + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all
>
> Looks valid of hand, but checkpatch.pl complains about 2 errors (missing
> commit message for example) and a warning.
>
> Please fix and resend.
I only get the checkpatch.pl output listed below with one warning. What
parameters do you use?
WARNING: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit d242a446258e ("doc: dma-buf: fix grammar typo") has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Thanks,
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-15 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-14 13:07 [PATCH] doc: dma-buf: fix grammar typo Baruch Siach
2024-04-15 14:35 ` Christian König
2024-04-15 15:40 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.