From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Eugen Hristev <eugen.hristev@collabora.com>,
tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jaegeuk@kernel.org,
chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, brauner@kernel.org,
jack@suse.cz, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, kernel@collabora.com,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v15 6/9] ext4: Log error when lookup of encoded dentry fails
Date: Wed, 03 Apr 2024 10:39:59 -0400 [thread overview]
Message-ID: <8734s24iio.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <20240403042231.GH2576@sol.localdomain> (Eric Biggers's message of "Tue, 2 Apr 2024 21:22:31 -0700")
Eric Biggers <ebiggers@kernel.org> writes:
> On Tue, Apr 02, 2024 at 06:48:39PM +0300, Eugen Hristev via Linux-f2fs-devel wrote:
>> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>>
> I'm seeing this error when the volume is *not* in strict mode and a file has a
> name that is not valid UTF-8. That doesn't seem to be working as
> intended.
>
> mkfs.ext4 -F -O casefold /dev/vdb
> mount /dev/vdb /mnt
> mkdir /mnt/dir
> chattr +F /mnt/dir
> touch /mnt/dir/$'\xff'
Yes. This should work without warnings. When not in strict mode,
/mnt/dir/$'\xff' is just a valid filename which can only be
looked up with an exact-match name-under-lookup.
The issue is that we must propagate errors from utf8_strncasecmp in
generic_ci_match only if we are in strict mode. If not on strict mode, we
need to return not-match on error.
--
Gabriel Krisman Bertazi
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: brauner@kernel.org, kernel@collabora.com, tytso@mit.edu,
jack@suse.cz, linux-kernel@vger.kernel.org,
Eugen Hristev <eugen.hristev@collabora.com>,
linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v15 6/9] ext4: Log error when lookup of encoded dentry fails
Date: Wed, 03 Apr 2024 10:39:59 -0400 [thread overview]
Message-ID: <8734s24iio.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <20240403042231.GH2576@sol.localdomain> (Eric Biggers's message of "Tue, 2 Apr 2024 21:22:31 -0700")
Eric Biggers <ebiggers@kernel.org> writes:
> On Tue, Apr 02, 2024 at 06:48:39PM +0300, Eugen Hristev via Linux-f2fs-devel wrote:
>> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>>
> I'm seeing this error when the volume is *not* in strict mode and a file has a
> name that is not valid UTF-8. That doesn't seem to be working as
> intended.
>
> mkfs.ext4 -F -O casefold /dev/vdb
> mount /dev/vdb /mnt
> mkdir /mnt/dir
> chattr +F /mnt/dir
> touch /mnt/dir/$'\xff'
Yes. This should work without warnings. When not in strict mode,
/mnt/dir/$'\xff' is just a valid filename which can only be
looked up with an exact-match name-under-lookup.
The issue is that we must propagate errors from utf8_strncasecmp in
generic_ci_match only if we are in strict mode. If not on strict mode, we
need to return not-match on error.
--
Gabriel Krisman Bertazi
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-04-03 14:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 15:48 [PATCH v15 0/9] Cache insensitive cleanup for ext4/f2fs Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-02 15:48 ` [PATCH v15 1/9] ext4: Simplify the handling of cached insensitive names Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-02 15:48 ` [PATCH v15 2/9] f2fs: " Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-03 3:30 ` Eric Biggers
2024-04-03 3:30 ` [f2fs-dev] " Eric Biggers
2024-04-02 15:48 ` [PATCH v15 3/9] libfs: Introduce case-insensitive string comparison helper Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-03 3:36 ` Eric Biggers
2024-04-03 3:36 ` [f2fs-dev] " Eric Biggers
2024-04-02 15:48 ` [PATCH v15 4/9] ext4: Reuse generic_ci_match for ci comparisons Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-03 3:43 ` Eric Biggers
2024-04-03 3:43 ` [f2fs-dev] " Eric Biggers
2024-04-03 4:20 ` Eric Biggers
2024-04-03 4:20 ` [f2fs-dev] " Eric Biggers
2024-04-02 15:48 ` [PATCH v15 5/9] f2fs: " Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-02 15:48 ` [PATCH v15 6/9] ext4: Log error when lookup of encoded dentry fails Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-03 4:22 ` Eric Biggers
2024-04-03 4:22 ` Eric Biggers
2024-04-03 14:39 ` Gabriel Krisman Bertazi [this message]
2024-04-03 14:39 ` Gabriel Krisman Bertazi
2024-04-02 15:48 ` [PATCH v15 7/9] f2fs: " Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-03 4:25 ` Eric Biggers
2024-04-03 4:25 ` Eric Biggers
2024-04-04 14:50 ` Eugen Hristev
2024-04-04 14:50 ` Eugen Hristev via Linux-f2fs-devel
2024-04-04 23:05 ` Gabriel Krisman Bertazi
2024-04-04 23:05 ` Gabriel Krisman Bertazi
2024-04-02 15:48 ` [PATCH v15 8/9] ext4: Move CONFIG_UNICODE defguards into the code flow Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-04-02 15:48 ` [PATCH v15 9/9] f2fs: " Eugen Hristev
2024-04-02 15:48 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734s24iio.fsf@mailhost.krisman.be \
--to=krisman@suse.de \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.