From: Cornelia Huck <cohuck@redhat.com>
To: "Pape, Andreas (ADITG/ESS3)" <apape@de.adit-jv.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>
Subject: Re: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz
Date: Thu, 08 Feb 2024 07:56:55 +0100 [thread overview]
Message-ID: <8734u3igug.fsf@redhat.com> (raw)
In-Reply-To: <10d461c112924dce8f29215359889b7b@de.adit-jv.com>
On Mon, Feb 05 2024, "Pape, Andreas (ADITG/ESS3)" <apape@de.adit-jv.com> wrote:
> 24kHz is used for 'super wideband' voice transmission 12kHz is added 'for completeness'
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/184
>
> Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
> ---
> device-types/sound/description.tex | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/sound/description.tex b/device-types/sound/description.tex
> index 54c9c8e..bad4415 100644
> --- a/device-types/sound/description.tex
> +++ b/device-types/sound/description.tex
> @@ -504,7 +504,9 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
> VIRTIO_SND_PCM_RATE_96000,
> VIRTIO_SND_PCM_RATE_176400,
> VIRTIO_SND_PCM_RATE_192000,
> - VIRTIO_SND_PCM_RATE_384000
> + VIRTIO_SND_PCM_RATE_384000,
> + VIRTIO_SND_PCM_RATE_12000,
> + VIRTIO_SND_PCM_RATE_24000
> };
>
> struct virtio_snd_pcm_info {
I think there had been a Reviewed-by: for a previous iteration of this
patch? We can add it while applying (after voting, which I'm going to
initiate); but I'd appreciate it if the previous reviewer could reply
here again.
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: "Pape, Andreas (ADITG/ESS3)" <apape@de.adit-jv.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>
Subject: [virtio-dev] Re: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz
Date: Thu, 08 Feb 2024 07:56:55 +0100 [thread overview]
Message-ID: <8734u3igug.fsf@redhat.com> (raw)
In-Reply-To: <10d461c112924dce8f29215359889b7b@de.adit-jv.com>
On Mon, Feb 05 2024, "Pape, Andreas (ADITG/ESS3)" <apape@de.adit-jv.com> wrote:
> 24kHz is used for 'super wideband' voice transmission 12kHz is added 'for completeness'
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/184
>
> Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
> ---
> device-types/sound/description.tex | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/sound/description.tex b/device-types/sound/description.tex
> index 54c9c8e..bad4415 100644
> --- a/device-types/sound/description.tex
> +++ b/device-types/sound/description.tex
> @@ -504,7 +504,9 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
> VIRTIO_SND_PCM_RATE_96000,
> VIRTIO_SND_PCM_RATE_176400,
> VIRTIO_SND_PCM_RATE_192000,
> - VIRTIO_SND_PCM_RATE_384000
> + VIRTIO_SND_PCM_RATE_384000,
> + VIRTIO_SND_PCM_RATE_12000,
> + VIRTIO_SND_PCM_RATE_24000
> };
>
> struct virtio_snd_pcm_info {
I think there had been a Reviewed-by: for a previous iteration of this
patch? We can add it while applying (after voting, which I'm going to
initiate); but I'd appreciate it if the previous reviewer could reply
here again.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2024-02-08 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 14:41 [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz Pape, Andreas (ADITG/ESS3)
2024-02-08 6:56 ` Cornelia Huck [this message]
2024-02-08 6:56 ` [virtio-dev] " Cornelia Huck
2024-02-09 7:32 ` Pape, Andreas (ADITG/ESS3)
2024-02-14 6:10 ` Anton Yakovlev
2024-02-14 6:10 ` [virtio-dev] " Anton Yakovlev
2024-02-14 10:31 ` Cornelia Huck
2024-02-14 10:31 ` [virtio-dev] " Cornelia Huck
-- strict thread matches above, loose matches on Subject: below --
2024-02-05 10:22 Pape, Andreas (ADITG/ESS3)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734u3igug.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=apape@de.adit-jv.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.