From: Jonathan Corbet <corbet@lwn.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Yangtao Li <frank.li@vivo.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: f2fs: specify extent cache for read explicitly
Date: Tue, 18 Apr 2023 07:47:29 -0600 [thread overview]
Message-ID: <87354xe1zi.fsf@meer.lwn.net> (raw)
In-Reply-To: <4517330a-00a3-220f-2fc5-a9ef4aba5ea8@gmail.com>
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> On 4/17/23 11:41, Yangtao Li wrote:
>> Let's descrbie it's read extent cache.
>
> "Clarify the fact that extent_cache and noextent_cache toggle read
> extent cache on or off."
Please stop nit-picking patches. This is good enough, though I might
fix the "describe" typo on the way in.
>> -extent_cache Enable an extent cache based on rb-tree, it can cache
>> - as many as extent which map between contiguous logical
>> +extent_cache Enable a read extent cache based on rb-tree, it can cache
> "... . It can cache ..."
Bagas. Enough. Seriously.
>> noinline_data Disable the inline data feature, inline data feature is
>> enabled by default.
>
> "Disable inline data feature, for which the feature is enabled by
> default." (submit as separate patch).
And please stop trying to make additional work for others. If you want
to improve something, submit a patch yourself.
jon
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Yangtao Li <frank.li@vivo.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] docs: f2fs: specify extent cache for read explicitly
Date: Tue, 18 Apr 2023 07:47:29 -0600 [thread overview]
Message-ID: <87354xe1zi.fsf@meer.lwn.net> (raw)
In-Reply-To: <4517330a-00a3-220f-2fc5-a9ef4aba5ea8@gmail.com>
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> On 4/17/23 11:41, Yangtao Li wrote:
>> Let's descrbie it's read extent cache.
>
> "Clarify the fact that extent_cache and noextent_cache toggle read
> extent cache on or off."
Please stop nit-picking patches. This is good enough, though I might
fix the "describe" typo on the way in.
>> -extent_cache Enable an extent cache based on rb-tree, it can cache
>> - as many as extent which map between contiguous logical
>> +extent_cache Enable a read extent cache based on rb-tree, it can cache
> "... . It can cache ..."
Bagas. Enough. Seriously.
>> noinline_data Disable the inline data feature, inline data feature is
>> enabled by default.
>
> "Disable inline data feature, for which the feature is enabled by
> default." (submit as separate patch).
And please stop trying to make additional work for others. If you want
to improve something, submit a patch yourself.
jon
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-04-18 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 4:41 [PATCH v2] docs: f2fs: specify extent cache for read explicitly Yangtao Li
2023-04-17 4:41 ` [f2fs-dev] " Yangtao Li via Linux-f2fs-devel
2023-04-18 2:10 ` Bagas Sanjaya
2023-04-18 2:10 ` [f2fs-dev] " Bagas Sanjaya
2023-04-18 13:47 ` Jonathan Corbet [this message]
2023-04-18 13:47 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87354xe1zi.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=bagasdotme@gmail.com \
--cc=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.