* [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
@ 2023-01-19 19:49 ` Alan Previn
0 siblings, 0 replies; 15+ messages in thread
From: Alan Previn @ 2023-01-19 19:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Vivi, Daniele Ceraolo Spurio, dri-devel, Alan Previn, Rodrigo
The Driver-FLR flow may inadvertently exit early before the full
completion of the re-init of the internal HW state if we only poll
GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
we need a two-step completion wait-for-completion flow that also
involves GU_CNTL. See the patch and new code comments for detail.
This is new direction from HW architecture folks.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
---
drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 8dee9e62a73e..959869e2ff05 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
/* Trigger the actual Driver-FLR */
intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
+ /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
+ ret = intel_wait_for_register_fw(uncore, GU_CNTL,
+ DRIVERFLR_STATUS, 0,
+ flr_timeout_ms);
+
+ /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
DRIVERFLR_STATUS, DRIVERFLR_STATUS,
flr_timeout_ms);
@@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
return;
}
+ /* Write 1 to clear GU_DEBUG's sticky completion status bit */
intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
}
base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
--
2.39.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-19 19:49 ` Alan Previn
@ 2023-01-19 19:57 ` Rodrigo Vivi
-1 siblings, 0 replies; 15+ messages in thread
From: Rodrigo Vivi @ 2023-01-19 19:57 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx, Vivi, dri-devel
On Thu, Jan 19, 2023 at 11:49:55AM -0800, Alan Previn wrote:
> The Driver-FLR flow may inadvertently exit early before the full
> completion of the re-init of the internal HW state if we only poll
> GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> we need a two-step completion wait-for-completion flow that also
> involves GU_CNTL. See the patch and new code comments for detail.
> This is new direction from HW architecture folks.
Do we have this documented anywhere?
but the patch looks good to me...
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 8dee9e62a73e..959869e2ff05 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> /* Trigger the actual Driver-FLR */
> intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
>
> + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
> + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> + DRIVERFLR_STATUS, 0,
> + flr_timeout_ms);
> +
> + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
> ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> flr_timeout_ms);
> @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> return;
> }
>
> + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
> intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> }
>
>
> base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
@ 2023-01-19 19:57 ` Rodrigo Vivi
0 siblings, 0 replies; 15+ messages in thread
From: Rodrigo Vivi @ 2023-01-19 19:57 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx, Daniele Ceraolo Spurio, Vivi, dri-devel
On Thu, Jan 19, 2023 at 11:49:55AM -0800, Alan Previn wrote:
> The Driver-FLR flow may inadvertently exit early before the full
> completion of the re-init of the internal HW state if we only poll
> GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> we need a two-step completion wait-for-completion flow that also
> involves GU_CNTL. See the patch and new code comments for detail.
> This is new direction from HW architecture folks.
Do we have this documented anywhere?
but the patch looks good to me...
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 8dee9e62a73e..959869e2ff05 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> /* Trigger the actual Driver-FLR */
> intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
>
> + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
> + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> + DRIVERFLR_STATUS, 0,
> + flr_timeout_ms);
> +
> + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
> ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> flr_timeout_ms);
> @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> return;
> }
>
> + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
> intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> }
>
>
> base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-19 19:57 ` Rodrigo Vivi
@ 2023-01-19 21:34 ` Teres Alexis, Alan Previn
-1 siblings, 0 replies; 15+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-01-19 21:34 UTC (permalink / raw)
To: Vivi, Rodrigo
Cc: Vivi@freedesktop.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Forwarded offline. Let's hold off R-B or merging until I verify that hw spec update is finalized to be exactly as what this patch is (probably a minor delay).
On Thu, 2023-01-19 at 14:57 -0500, Vivi, Rodrigo wrote:
> On Thu, Jan 19, 2023 at 11:49:55AM -0800, Alan Previn wrote:
> > The Driver-FLR flow may inadvertently exit early before the full
> > completion of the re-init of the internal HW state if we only poll
> > GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> > we need a two-step completion wait-for-completion flow that also
> > involves GU_CNTL. See the patch and new code comments for detail.
> > This is new direction from HW architecture folks.
>
> Do we have this documented anywhere?
>
> but the patch looks good to me...
>
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> > Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> > ---
> > drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> > index 8dee9e62a73e..959869e2ff05 100644
> > --- a/drivers/gpu/drm/i915/intel_uncore.c
> > +++ b/drivers/gpu/drm/i915/intel_uncore.c
> > @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > /* Trigger the actual Driver-FLR */
> > intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
> >
> > + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
> > + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> > + DRIVERFLR_STATUS, 0,
> > + flr_timeout_ms);
> > +
> > + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
> > ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> > DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> > flr_timeout_ms);
> > @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > return;
> > }
> >
> > + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
> > intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> > }
> >
> >
> > base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
> > --
> > 2.39.0
> >
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
@ 2023-01-19 21:34 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 15+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-01-19 21:34 UTC (permalink / raw)
To: Vivi, Rodrigo
Cc: Vivi@freedesktop.org, Ceraolo Spurio, Daniele,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Forwarded offline. Let's hold off R-B or merging until I verify that hw spec update is finalized to be exactly as what this patch is (probably a minor delay).
On Thu, 2023-01-19 at 14:57 -0500, Vivi, Rodrigo wrote:
> On Thu, Jan 19, 2023 at 11:49:55AM -0800, Alan Previn wrote:
> > The Driver-FLR flow may inadvertently exit early before the full
> > completion of the re-init of the internal HW state if we only poll
> > GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> > we need a two-step completion wait-for-completion flow that also
> > involves GU_CNTL. See the patch and new code comments for detail.
> > This is new direction from HW architecture folks.
>
> Do we have this documented anywhere?
>
> but the patch looks good to me...
>
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> > Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> > ---
> > drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> > index 8dee9e62a73e..959869e2ff05 100644
> > --- a/drivers/gpu/drm/i915/intel_uncore.c
> > +++ b/drivers/gpu/drm/i915/intel_uncore.c
> > @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > /* Trigger the actual Driver-FLR */
> > intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
> >
> > + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
> > + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> > + DRIVERFLR_STATUS, 0,
> > + flr_timeout_ms);
> > +
> > + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
> > ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> > DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> > flr_timeout_ms);
> > @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > return;
> > }
> >
> > + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
> > intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> > }
> >
> >
> > base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
> > --
> > 2.39.0
> >
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-19 19:49 ` Alan Previn
(?)
(?)
@ 2023-01-19 20:37 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-01-19 20:37 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5056 bytes --]
== Series Details ==
Series: series starting with [1/1] drm/i915/gsc: Fix the Driver-FLR completion
URL : https://patchwork.freedesktop.org/series/113112/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12613 -> Patchwork_113112v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/index.html
Participating hosts (38 -> 35)
------------------------------
Missing (3): fi-kbl-soraka fi-rkl-11600 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113112v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_module_load@load:
- {bat-dg2-8}: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/bat-dg2-8/igt@i915_module_load@load.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/bat-dg2-8/igt@i915_module_load@load.html
Known issues
------------
Here are the changes found in Patchwork_113112v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][3] -> [FAIL][4] ([i915#7229])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/fi-apl-guc/igt@gem_lmem_swapping@basic.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-apl-guc: NOTRUN -> [SKIP][6] ([fdo#109271]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/fi-apl-guc/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- {bat-adlp-6}: [DMESG-FAIL][7] ([i915#7699]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/bat-adlp-6/igt@i915_selftest@live@migrate.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/bat-adlp-6/igt@i915_selftest@live@migrate.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-n3050: [FAIL][9] ([i915#6298]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-3:
- {bat-dg2-9}: [FAIL][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-3.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-3.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-apl-guc: [DMESG-WARN][13] -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/fi-apl-guc/igt@prime_self_import@basic-with_one_bo_two_files.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/fi-apl-guc/igt@prime_self_import@basic-with_one_bo_two_files.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7834]: https://gitlab.freedesktop.org/drm/intel/issues/7834
Build changes
-------------
* Linux: CI_DRM_12613 -> Patchwork_113112v1
CI-20190529: 20190529
CI_DRM_12613: c79a53a6143abdc789b46eb24cd7ce00924be491 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7126: 3aa9364a1e478010aba0d3dfe9183486560ecc60 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113112v1: c79a53a6143abdc789b46eb24cd7ce00924be491 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
77a28ed7bb80 drm/i915/gsc: Fix the Driver-FLR completion
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/index.html
[-- Attachment #2: Type: text/html, Size: 5666 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-19 19:49 ` Alan Previn
@ 2023-01-20 8:27 ` Gupta, Anshuman
-1 siblings, 0 replies; 15+ messages in thread
From: Gupta, Anshuman @ 2023-01-20 8:27 UTC (permalink / raw)
To: Teres Alexis, Alan Previn, intel-gfx@lists.freedesktop.org
Cc: Vivi@freedesktop.org, Teres Alexis, Alan Previn,
dri-devel@lists.freedesktop.org, Vivi, Rodrigo
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Alan
> Previn
> Sent: Friday, January 20, 2023 1:20 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Vivi@freedesktop.org; dri-devel@lists.freedesktop.org; Teres Alexis,
> Alan Previn <alan.previn.teres.alexis@intel.com>; Vivi, Rodrigo
> <rodrigo.vivi@intel.com>
> Subject: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
>
> The Driver-FLR flow may inadvertently exit early before the full completion
> of the re-init of the internal HW state if we only poll GU_DEBUG Bit31 (polling
> for it to toggle from 0 -> 1). Instead we need a two-step completion wait-for-
> completion flow that also involves GU_CNTL. See the patch and new code
> comments for detail.
> This is new direction from HW architecture folks.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was
> loaded")
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c
> b/drivers/gpu/drm/i915/intel_uncore.c
> index 8dee9e62a73e..959869e2ff05 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore
> *uncore)
> /* Trigger the actual Driver-FLR */
> intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
>
> + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown
> to complete */
> + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> + DRIVERFLR_STATUS, 0,
> + flr_timeout_ms);
We need an error here if above wait timeout then below wait is essentially a NOP.
And driver may return before completion of FLR.
Thanks,
Anshuman Gupta.
> +
> + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init
> +to complete */
> ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> DRIVERFLR_STATUS,
> DRIVERFLR_STATUS,
> flr_timeout_ms);
> @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore
> *uncore)
> return;
> }
>
> + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
> intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS); }
>
>
> base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
> --
> 2.39.0
^ permalink raw reply [flat|nested] 15+ messages in thread* RE: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
@ 2023-01-20 8:27 ` Gupta, Anshuman
0 siblings, 0 replies; 15+ messages in thread
From: Gupta, Anshuman @ 2023-01-20 8:27 UTC (permalink / raw)
To: Teres Alexis, Alan Previn, intel-gfx@lists.freedesktop.org
Cc: Vivi@freedesktop.org, Teres Alexis, Alan Previn,
dri-devel@lists.freedesktop.org, Vivi, Rodrigo
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Alan
> Previn
> Sent: Friday, January 20, 2023 1:20 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Vivi@freedesktop.org; dri-devel@lists.freedesktop.org; Teres Alexis,
> Alan Previn <alan.previn.teres.alexis@intel.com>; Vivi, Rodrigo
> <rodrigo.vivi@intel.com>
> Subject: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
>
> The Driver-FLR flow may inadvertently exit early before the full completion
> of the re-init of the internal HW state if we only poll GU_DEBUG Bit31 (polling
> for it to toggle from 0 -> 1). Instead we need a two-step completion wait-for-
> completion flow that also involves GU_CNTL. See the patch and new code
> comments for detail.
> This is new direction from HW architecture folks.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was
> loaded")
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c
> b/drivers/gpu/drm/i915/intel_uncore.c
> index 8dee9e62a73e..959869e2ff05 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore
> *uncore)
> /* Trigger the actual Driver-FLR */
> intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
>
> + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown
> to complete */
> + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> + DRIVERFLR_STATUS, 0,
> + flr_timeout_ms);
We need an error here if above wait timeout then below wait is essentially a NOP.
And driver may return before completion of FLR.
Thanks,
Anshuman Gupta.
> +
> + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init
> +to complete */
> ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> DRIVERFLR_STATUS,
> DRIVERFLR_STATUS,
> flr_timeout_ms);
> @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore
> *uncore)
> return;
> }
>
> + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
> intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS); }
>
>
> base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
> --
> 2.39.0
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-20 8:27 ` Gupta, Anshuman
(?)
@ 2023-01-20 16:41 ` Teres Alexis, Alan Previn
-1 siblings, 0 replies; 15+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-01-20 16:41 UTC (permalink / raw)
To: Gupta, Anshuman, intel-gfx@lists.freedesktop.org
Cc: Vivi@freedesktop.org, dri-devel@lists.freedesktop.org,
Vivi, Rodrigo
On Fri, 2023-01-20 at 08:27 +0000, Gupta, Anshuman wrote:
>
>
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Alan
> > Previn
> > Sent: Friday, January 20, 2023 1:20 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Vivi@freedesktop.org; dri-devel@lists.freedesktop.org; Teres Alexis,
> > Alan Previn <alan.previn.teres.alexis@intel.com>; Vivi, Rodrigo
> > <rodrigo.vivi@intel.com>
> > Subject: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
> >
> >
alan:snip..
> > + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown
> > to complete */
> > + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> > + DRIVERFLR_STATUS, 0,
> > + flr_timeout_ms);
> We need an error here if above wait timeout then below wait is essentially a NOP.
> And driver may return before completion of FLR.
> Thanks,
> Anshuman Gupta.
alan: my bad - good catch - will fix.
alan:snip..
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-19 19:49 ` Alan Previn
@ 2023-01-20 9:14 ` Jani Nikula
-1 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2023-01-20 9:14 UTC (permalink / raw)
To: Alan Previn, intel-gfx; +Cc: Vivi, Alan Previn, dri-devel, Rodrigo
On Thu, 19 Jan 2023, Alan Previn <alan.previn.teres.alexis@intel.com> wrote:
> The Driver-FLR flow may inadvertently exit early before the full
> completion of the re-init of the internal HW state if we only poll
> GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> we need a two-step completion wait-for-completion flow that also
> involves GU_CNTL. See the patch and new code comments for detail.
> This is new direction from HW architecture folks.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 8dee9e62a73e..959869e2ff05 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> /* Trigger the actual Driver-FLR */
> intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
>
> + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
Please don't use comments to repeat what the code already says.
Here, you could just say, "Wait for hardware teardown to complete",
which describes what the code does at a higher level, but does not
duplicate any of it.
> + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> + DRIVERFLR_STATUS, 0,
> + flr_timeout_ms);
> +
> + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
"Wait for hardware/firmware re-init to complete"
> ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> flr_timeout_ms);
> @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> return;
> }
>
> + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
"Clear sticky completion status" maybe?
> intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> }
>
>
> base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
@ 2023-01-20 9:14 ` Jani Nikula
0 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2023-01-20 9:14 UTC (permalink / raw)
To: Alan Previn, intel-gfx
Cc: Vivi, Daniele Ceraolo Spurio, Alan Previn, dri-devel, Rodrigo
On Thu, 19 Jan 2023, Alan Previn <alan.previn.teres.alexis@intel.com> wrote:
> The Driver-FLR flow may inadvertently exit early before the full
> completion of the re-init of the internal HW state if we only poll
> GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> we need a two-step completion wait-for-completion flow that also
> involves GU_CNTL. See the patch and new code comments for detail.
> This is new direction from HW architecture folks.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 8dee9e62a73e..959869e2ff05 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> /* Trigger the actual Driver-FLR */
> intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
>
> + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
Please don't use comments to repeat what the code already says.
Here, you could just say, "Wait for hardware teardown to complete",
which describes what the code does at a higher level, but does not
duplicate any of it.
> + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> + DRIVERFLR_STATUS, 0,
> + flr_timeout_ms);
> +
> + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
"Wait for hardware/firmware re-init to complete"
> ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> flr_timeout_ms);
> @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> return;
> }
>
> + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
"Clear sticky completion status" maybe?
> intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> }
>
>
> base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-20 9:14 ` Jani Nikula
@ 2023-01-20 16:42 ` Teres Alexis, Alan Previn
-1 siblings, 0 replies; 15+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-01-20 16:42 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com
Cc: Vivi@freedesktop.org, dri-devel@lists.freedesktop.org,
Vivi, Rodrigo
Thanks for reviewing - sounds good - will fix those comments up as per your recommendation.
On Fri, 2023-01-20 at 11:14 +0200, Jani Nikula wrote:
> On Thu, 19 Jan 2023, Alan Previn <alan.previn.teres.alexis@intel.com> wrote:
> > The Driver-FLR flow may inadvertently exit early before the full
> > completion of the re-init of the internal HW state if we only poll
> > GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> > we need a two-step completion wait-for-completion flow that also
> > involves GU_CNTL. See the patch and new code comments for detail.
> > This is new direction from HW architecture folks.
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> > Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> > ---
> > drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> > index 8dee9e62a73e..959869e2ff05 100644
> > --- a/drivers/gpu/drm/i915/intel_uncore.c
> > +++ b/drivers/gpu/drm/i915/intel_uncore.c
> > @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > /* Trigger the actual Driver-FLR */
> > intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
> >
> > + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
>
> Please don't use comments to repeat what the code already says.
>
> Here, you could just say, "Wait for hardware teardown to complete",
> which describes what the code does at a higher level, but does not
> duplicate any of it.
>
> > + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> > + DRIVERFLR_STATUS, 0,
> > + flr_timeout_ms);
> > +
> > + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
>
> "Wait for hardware/firmware re-init to complete"
>
> > ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> > DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> > flr_timeout_ms);
> > @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > return;
> > }
> >
> > + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
>
> "Clear sticky completion status" maybe?
>
> > intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> > }
> >
> >
> > base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
@ 2023-01-20 16:42 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 15+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-01-20 16:42 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com
Cc: Vivi@freedesktop.org, Ceraolo Spurio, Daniele,
dri-devel@lists.freedesktop.org, Vivi, Rodrigo
Thanks for reviewing - sounds good - will fix those comments up as per your recommendation.
On Fri, 2023-01-20 at 11:14 +0200, Jani Nikula wrote:
> On Thu, 19 Jan 2023, Alan Previn <alan.previn.teres.alexis@intel.com> wrote:
> > The Driver-FLR flow may inadvertently exit early before the full
> > completion of the re-init of the internal HW state if we only poll
> > GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> > we need a two-step completion wait-for-completion flow that also
> > involves GU_CNTL. See the patch and new code comments for detail.
> > This is new direction from HW architecture folks.
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> > Fixes: 5a44fcd73498 ("drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded")
> > ---
> > drivers/gpu/drm/i915/intel_uncore.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> > index 8dee9e62a73e..959869e2ff05 100644
> > --- a/drivers/gpu/drm/i915/intel_uncore.c
> > +++ b/drivers/gpu/drm/i915/intel_uncore.c
> > @@ -2748,6 +2748,12 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > /* Trigger the actual Driver-FLR */
> > intel_uncore_rmw_fw(uncore, GU_CNTL, 0, DRIVERFLR);
> >
> > + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown to complete */
>
> Please don't use comments to repeat what the code already says.
>
> Here, you could just say, "Wait for hardware teardown to complete",
> which describes what the code does at a higher level, but does not
> duplicate any of it.
>
> > + ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> > + DRIVERFLR_STATUS, 0,
> > + flr_timeout_ms);
> > +
> > + /* Completion: Step 2 - poll for 'DEBUG-BIT31 = 1' for hw/fw re-init to complete */
>
> "Wait for hardware/firmware re-init to complete"
>
> > ret = intel_wait_for_register_fw(uncore, GU_DEBUG,
> > DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> > flr_timeout_ms);
> > @@ -2756,6 +2762,7 @@ static void driver_initiated_flr(struct intel_uncore *uncore)
> > return;
> > }
> >
> > + /* Write 1 to clear GU_DEBUG's sticky completion status bit */
>
> "Clear sticky completion status" maybe?
>
> > intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> > }
> >
> >
> > base-commit: 0a0ee61784df01ac098a92bd43673ee30c629f13
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/gsc: Fix the Driver-FLR completion
2023-01-19 19:49 ` Alan Previn
` (4 preceding siblings ...)
(?)
@ 2023-01-20 22:18 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-01-20 22:18 UTC (permalink / raw)
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 19331 bytes --]
== Series Details ==
Series: series starting with [1/1] drm/i915/gsc: Fix the Driver-FLR completion
URL : https://patchwork.freedesktop.org/series/113112/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12613_full -> Patchwork_113112v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/index.html
Participating hosts (12 -> 11)
------------------------------
Additional (1): shard-rkl0
Missing (2): pig-skl-6260u pig-kbl-iris
Known issues
------------
Here are the changes found in Patchwork_113112v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-glk2/igt@gem_exec_fair@basic-none@rcs0.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2346])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible@a-hdmi-a1:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#407])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk1/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-hdmi-a1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-glk4/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-hdmi-a1.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][7] ([i915#7742]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@fbdev@unaligned-read:
- {shard-rkl}: [SKIP][9] ([i915#2582]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@fbdev@unaligned-read.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@fbdev@unaligned-read.html
* igt@gem_eio@suspend:
- {shard-rkl}: [FAIL][11] ([i915#7052]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@gem_eio@suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@gem_eio@suspend.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][13] ([i915#2842]) -> [PASS][14] +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][15] ([i915#3281]) -> [PASS][16] +12 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-6/igt@gem_exec_reloc@basic-wc-read-noreloc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-5/igt@gem_exec_reloc@basic-wc-read-noreloc.html
* igt@gem_pread@self:
- {shard-rkl}: [SKIP][17] ([i915#3282]) -> [PASS][18] +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-1/igt@gem_pread@self.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-5/igt@gem_pread@self.html
* igt@gen9_exec_parse@batch-invalid-length:
- {shard-rkl}: [SKIP][19] ([i915#2527]) -> [PASS][20] +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-6/igt@gen9_exec_parse@batch-invalid-length.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-5/igt@gen9_exec_parse@batch-invalid-length.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][21] ([i915#5334]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk2/igt@i915_selftest@live@gt_heartbeat.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-glk7/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_suspend@fence-restore-untiled:
- {shard-rkl}: [FAIL][23] ([fdo#103375]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@i915_suspend@fence-restore-untiled.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- {shard-rkl}: [SKIP][25] ([i915#1845] / [i915#4098]) -> [PASS][26] +32 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][27] ([i915#2346]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-rkl}: [SKIP][29] ([i915#1849] / [i915#4098]) -> [PASS][30] +29 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
* igt@kms_plane@pixel-format@pipe-b-planes:
- {shard-rkl}: [SKIP][31] ([i915#1849]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-1/igt@kms_plane@pixel-format@pipe-b-planes.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@kms_plane@pixel-format@pipe-b-planes.html
* igt@kms_psr@cursor_render:
- {shard-rkl}: [SKIP][33] ([i915#1072]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@kms_psr@cursor_render.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@kms_psr@cursor_render.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- {shard-rkl}: [SKIP][35] ([i915#5461]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b:
- {shard-rkl}: [SKIP][37] ([i915#4098]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-3/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- {shard-rkl}: [SKIP][39] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-1/igt@kms_universal_plane@universal-plane-pipe-b-functional.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-b-functional.html
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][41] ([fdo#109289]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-3/igt@perf@gen12-oa-tlb-invalidate.html
* igt@prime_vgem@basic-fence-flip:
- {shard-rkl}: [SKIP][43] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12613/shard-rkl-1/igt@prime_vgem@basic-fence-flip.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12613 -> Patchwork_113112v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12613: c79a53a6143abdc789b46eb24cd7ce00924be491 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7126: 3aa9364a1e478010aba0d3dfe9183486560ecc60 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113112v1: c79a53a6143abdc789b46eb24cd7ce00924be491 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113112v1/index.html
[-- Attachment #2: Type: text/html, Size: 12943 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread