Re: [Intel-gfx] [PATCH 08/12] drm/i915: Define more VBT driver features block bits

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 15 Jul 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Define some additoonal bits in the driver features VBT block.

*additional

>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index c04937aa75b2..2feba1e69a6d 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -575,14 +575,19 @@ struct bdb_driver_features {
>  
>  	/* Driver Flags 1 */
>  	u8 static_display:1;					/* 163+ */
> -	u8 reserved2:7;
> +	u8 embedded_platform:1;					/* 163+ */
> +	u8 display_subsystem_enable:1;				/* 163+ */
> +	u8 reserved0:5;
>  
>  	u16 legacy_crt_max_x;
>  	u16 legacy_crt_max_y;
>  	u8 legacy_crt_max_refresh;
>  
>  	/* Extended Driver Bits 2 */
> -	u8 hdmi_termination;
> +	u8 hdmi_termination:1;
> +	u8 cea861d_hdmi_support:1;
> +	u8 self_refresh_enable:1;
> +	u8 reserved1:5;
>  
>  	u8 custom_vbt_version;					/* 165+ */
>  
> @@ -598,9 +603,10 @@ struct bdb_driver_features {
>  	u16 tbt_enabled:1;					/* 165+ */
>  	u16 psr_enabled:1;					/* 165-227 */
>  	u16 ips_enabled:1;					/* 165+ */
> -	u16 reserved3:1;
> +	u16 dpfs_enabled:1;					/* 165+ */
>  	u16 dmrrs_enabled:1;					/* 174-227 */
> -	u16 reserved4:2;
> +	u16 adt_enabled:1;					/* ???-228 */
> +	u16 hpd_wake:1;						/* 201-240 */
>  	u16 pc_feature_valid:1;
>  } __packed;

-- 
Jani Nikula, Intel Open Source Graphics Center