Re: [Intel-gfx] [PATCH 09/12] drm/i915: Define all possible VBT device handles

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 15 Jul 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We already have LFP1 and LFP2 device handles define. Just
> add all the rest as well.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 2feba1e69a6d..f56c869e106f 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -197,6 +197,15 @@ struct bdb_general_features {
>  #define GPIO_PIN_ADD_DDC_I2C	0x06 /* "ADDCARD DDC/I2C GPIO pins" */
>  
>  /* Device handle */
> +#define DEVICE_HANDLE_CRT	0x0001
> +#define DEVICE_HANDLE_EFP1	0x0004
> +#define DEVICE_HANDLE_EFP2	0x0040
> +#define DEVICE_HANDLE_EFP3	0x0020
> +#define DEVICE_HANDLE_EFP4	0x0010 /* 194+ */
> +#define DEVICE_HANDLE_EFP5	0x0002 /* 215+ */
> +#define DEVICE_HANDLE_EFP6	0x0001 /* 217+ */
> +#define DEVICE_HANDLE_EFP7	0x0100 /* 217+ */
> +#define DEVICE_HANDLE_EFP8	0x0200 /* 217+ */
>  #define DEVICE_HANDLE_LFP1	0x0008
>  #define DEVICE_HANDLE_LFP2	0x0080

-- 
Jani Nikula, Intel Open Source Graphics Center