* [PATCH] KVM: arm64: fix compile error because of shift overflow
@ 2022-08-09 9:41 ` Yang Yingliang
0 siblings, 0 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-08-09 9:41 UTC (permalink / raw)
To: linux-kernel, kvmarm, linux-arm-kernel; +Cc: maz
Change the mask to unsigned to fix the following fix compile error
because of shift overflow when using low verison gcc(mine version is 7.5):
In function ‘kvm_vm_ioctl_set_device_addr.isra.38’,
inlined from ‘kvm_arch_vm_ioctl’ at arch/arm64/kvm/arm.c:1454:10:
././include/linux/compiler_types.h:354:38: error: call to ‘__compiletime_assert_599’ \
declared with attribute error: FIELD_GET: mask is not constant
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
Fixes: 9f968c9266aa ("KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
arch/arm64/include/uapi/asm/kvm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
index 3bb134355874..04ffa13d5e0a 100644
--- a/arch/arm64/include/uapi/asm/kvm.h
+++ b/arch/arm64/include/uapi/asm/kvm.h
@@ -77,7 +77,7 @@ struct kvm_regs {
#define KVM_ARM_DEVICE_TYPE_SHIFT 0
#define KVM_ARM_DEVICE_TYPE_MASK (0xffff << KVM_ARM_DEVICE_TYPE_SHIFT)
#define KVM_ARM_DEVICE_ID_SHIFT 16
-#define KVM_ARM_DEVICE_ID_MASK (0xffff << KVM_ARM_DEVICE_ID_SHIFT)
+#define KVM_ARM_DEVICE_ID_MASK (0xffffu << KVM_ARM_DEVICE_ID_SHIFT)
/* Supported device IDs */
#define KVM_ARM_DEVICE_VGIC_V2 0
--
2.25.1
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] KVM: arm64: fix compile error because of shift overflow
@ 2022-08-09 9:41 ` Yang Yingliang
0 siblings, 0 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-08-09 9:41 UTC (permalink / raw)
To: linux-kernel, kvmarm, linux-arm-kernel; +Cc: maz
Change the mask to unsigned to fix the following fix compile error
because of shift overflow when using low verison gcc(mine version is 7.5):
In function ‘kvm_vm_ioctl_set_device_addr.isra.38’,
inlined from ‘kvm_arch_vm_ioctl’ at arch/arm64/kvm/arm.c:1454:10:
././include/linux/compiler_types.h:354:38: error: call to ‘__compiletime_assert_599’ \
declared with attribute error: FIELD_GET: mask is not constant
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
Fixes: 9f968c9266aa ("KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
arch/arm64/include/uapi/asm/kvm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
index 3bb134355874..04ffa13d5e0a 100644
--- a/arch/arm64/include/uapi/asm/kvm.h
+++ b/arch/arm64/include/uapi/asm/kvm.h
@@ -77,7 +77,7 @@ struct kvm_regs {
#define KVM_ARM_DEVICE_TYPE_SHIFT 0
#define KVM_ARM_DEVICE_TYPE_MASK (0xffff << KVM_ARM_DEVICE_TYPE_SHIFT)
#define KVM_ARM_DEVICE_ID_SHIFT 16
-#define KVM_ARM_DEVICE_ID_MASK (0xffff << KVM_ARM_DEVICE_ID_SHIFT)
+#define KVM_ARM_DEVICE_ID_MASK (0xffffu << KVM_ARM_DEVICE_ID_SHIFT)
/* Supported device IDs */
#define KVM_ARM_DEVICE_VGIC_V2 0
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] KVM: arm64: fix compile error because of shift overflow
@ 2022-08-09 9:41 ` Yang Yingliang
0 siblings, 0 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-08-09 9:41 UTC (permalink / raw)
To: linux-kernel, kvmarm, linux-arm-kernel; +Cc: maz
Change the mask to unsigned to fix the following fix compile error
because of shift overflow when using low verison gcc(mine version is 7.5):
In function ‘kvm_vm_ioctl_set_device_addr.isra.38’,
inlined from ‘kvm_arch_vm_ioctl’ at arch/arm64/kvm/arm.c:1454:10:
././include/linux/compiler_types.h:354:38: error: call to ‘__compiletime_assert_599’ \
declared with attribute error: FIELD_GET: mask is not constant
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
Fixes: 9f968c9266aa ("KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
arch/arm64/include/uapi/asm/kvm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
index 3bb134355874..04ffa13d5e0a 100644
--- a/arch/arm64/include/uapi/asm/kvm.h
+++ b/arch/arm64/include/uapi/asm/kvm.h
@@ -77,7 +77,7 @@ struct kvm_regs {
#define KVM_ARM_DEVICE_TYPE_SHIFT 0
#define KVM_ARM_DEVICE_TYPE_MASK (0xffff << KVM_ARM_DEVICE_TYPE_SHIFT)
#define KVM_ARM_DEVICE_ID_SHIFT 16
-#define KVM_ARM_DEVICE_ID_MASK (0xffff << KVM_ARM_DEVICE_ID_SHIFT)
+#define KVM_ARM_DEVICE_ID_MASK (0xffffu << KVM_ARM_DEVICE_ID_SHIFT)
/* Supported device IDs */
#define KVM_ARM_DEVICE_VGIC_V2 0
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: arm64: fix compile error because of shift overflow
2022-08-09 9:41 ` Yang Yingliang
(?)
@ 2022-08-09 10:16 ` Marc Zyngier
-1 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2022-08-09 10:16 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, linux-arm-kernel, kvmarm
Hi Yang,
In the future, please add all the KVM/arm64 reviewers mentioned in
MAINTAINERS when sending KVM/arm64 patches.
On Tue, 09 Aug 2022 10:41:58 +0100,
Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> Change the mask to unsigned to fix the following fix compile error
> because of shift overflow when using low verison gcc(mine version is 7.5):
>
> In function ‘kvm_vm_ioctl_set_device_addr.isra.38’,
> inlined from ‘kvm_arch_vm_ioctl’ at arch/arm64/kvm/arm.c:1454:10:
> ././include/linux/compiler_types.h:354:38: error: call to ‘__compiletime_assert_599’ \
> declared with attribute error: FIELD_GET: mask is not constant
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>
> Fixes: 9f968c9266aa ("KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> arch/arm64/include/uapi/asm/kvm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
> index 3bb134355874..04ffa13d5e0a 100644
> --- a/arch/arm64/include/uapi/asm/kvm.h
> +++ b/arch/arm64/include/uapi/asm/kvm.h
> @@ -77,7 +77,7 @@ struct kvm_regs {
> #define KVM_ARM_DEVICE_TYPE_SHIFT 0
> #define KVM_ARM_DEVICE_TYPE_MASK (0xffff << KVM_ARM_DEVICE_TYPE_SHIFT)
> #define KVM_ARM_DEVICE_ID_SHIFT 16
> -#define KVM_ARM_DEVICE_ID_MASK (0xffff << KVM_ARM_DEVICE_ID_SHIFT)
> +#define KVM_ARM_DEVICE_ID_MASK (0xffffu << KVM_ARM_DEVICE_ID_SHIFT)
I'd rather you use GENMASK() for this, making it completely
unambiguous (and for KVM_ARM_DEVICE_TYPE_MASK as well).
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: arm64: fix compile error because of shift overflow
@ 2022-08-09 10:16 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2022-08-09 10:16 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, kvmarm, linux-arm-kernel
Hi Yang,
In the future, please add all the KVM/arm64 reviewers mentioned in
MAINTAINERS when sending KVM/arm64 patches.
On Tue, 09 Aug 2022 10:41:58 +0100,
Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> Change the mask to unsigned to fix the following fix compile error
> because of shift overflow when using low verison gcc(mine version is 7.5):
>
> In function ‘kvm_vm_ioctl_set_device_addr.isra.38’,
> inlined from ‘kvm_arch_vm_ioctl’ at arch/arm64/kvm/arm.c:1454:10:
> ././include/linux/compiler_types.h:354:38: error: call to ‘__compiletime_assert_599’ \
> declared with attribute error: FIELD_GET: mask is not constant
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>
> Fixes: 9f968c9266aa ("KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> arch/arm64/include/uapi/asm/kvm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
> index 3bb134355874..04ffa13d5e0a 100644
> --- a/arch/arm64/include/uapi/asm/kvm.h
> +++ b/arch/arm64/include/uapi/asm/kvm.h
> @@ -77,7 +77,7 @@ struct kvm_regs {
> #define KVM_ARM_DEVICE_TYPE_SHIFT 0
> #define KVM_ARM_DEVICE_TYPE_MASK (0xffff << KVM_ARM_DEVICE_TYPE_SHIFT)
> #define KVM_ARM_DEVICE_ID_SHIFT 16
> -#define KVM_ARM_DEVICE_ID_MASK (0xffff << KVM_ARM_DEVICE_ID_SHIFT)
> +#define KVM_ARM_DEVICE_ID_MASK (0xffffu << KVM_ARM_DEVICE_ID_SHIFT)
I'd rather you use GENMASK() for this, making it completely
unambiguous (and for KVM_ARM_DEVICE_TYPE_MASK as well).
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KVM: arm64: fix compile error because of shift overflow
@ 2022-08-09 10:16 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2022-08-09 10:16 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, kvmarm, linux-arm-kernel
Hi Yang,
In the future, please add all the KVM/arm64 reviewers mentioned in
MAINTAINERS when sending KVM/arm64 patches.
On Tue, 09 Aug 2022 10:41:58 +0100,
Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> Change the mask to unsigned to fix the following fix compile error
> because of shift overflow when using low verison gcc(mine version is 7.5):
>
> In function ‘kvm_vm_ioctl_set_device_addr.isra.38’,
> inlined from ‘kvm_arch_vm_ioctl’ at arch/arm64/kvm/arm.c:1454:10:
> ././include/linux/compiler_types.h:354:38: error: call to ‘__compiletime_assert_599’ \
> declared with attribute error: FIELD_GET: mask is not constant
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>
> Fixes: 9f968c9266aa ("KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> arch/arm64/include/uapi/asm/kvm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
> index 3bb134355874..04ffa13d5e0a 100644
> --- a/arch/arm64/include/uapi/asm/kvm.h
> +++ b/arch/arm64/include/uapi/asm/kvm.h
> @@ -77,7 +77,7 @@ struct kvm_regs {
> #define KVM_ARM_DEVICE_TYPE_SHIFT 0
> #define KVM_ARM_DEVICE_TYPE_MASK (0xffff << KVM_ARM_DEVICE_TYPE_SHIFT)
> #define KVM_ARM_DEVICE_ID_SHIFT 16
> -#define KVM_ARM_DEVICE_ID_MASK (0xffff << KVM_ARM_DEVICE_ID_SHIFT)
> +#define KVM_ARM_DEVICE_ID_MASK (0xffffu << KVM_ARM_DEVICE_ID_SHIFT)
I'd rather you use GENMASK() for this, making it completely
unambiguous (and for KVM_ARM_DEVICE_TYPE_MASK as well).
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-09 10:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-09 9:41 [PATCH] KVM: arm64: fix compile error because of shift overflow Yang Yingliang
2022-08-09 9:41 ` Yang Yingliang
2022-08-09 9:41 ` Yang Yingliang
2022-08-09 10:16 ` Marc Zyngier
2022-08-09 10:16 ` Marc Zyngier
2022-08-09 10:16 ` Marc Zyngier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.