All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: lkp@lists.01.org
Subject: Re: [x86/aperfmperf] adabc53c25: WARNING:at_arch/x86/kernel/cpu/aperfmperf.c:#freq_invariance_enable
Date: Wed, 27 Apr 2022 16:51:39 +0200	[thread overview]
Message-ID: <8735hyy3yc.ffs@tglx> (raw)
In-Reply-To: <20220426072238.GA613@xsang-OptiPlex-9020>

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Tue, Apr 26 2022 at 15:22, kernel test robot wrote:
> [ 11.086251][ T1] WARNING: CPU: 4 PID: 1 at arch/x86/kernel/cpu/aperfmperf.c:431 freq_invariance_enable (arch/x86/kernel/cpu/aperfmperf.c:431) 
> [ 11.227178][ T1] init_freq_invariance_cppc (arch/x86/kernel/acpi/cppc.c:82 arch/x86/kernel/acpi/cppc.c:96) 
> [ 11.232574][ T1] acpi_cppc_processor_probe (drivers/acpi/cppc_acpi.c:832) 

Bah, the commit in question assumed that the CPPC muck is AMD only....

Fix below.

Thanks,

        tglx
---
--- a/arch/x86/kernel/acpi/cppc.c
+++ b/arch/x86/kernel/acpi/cppc.c
@@ -91,6 +91,9 @@ void init_freq_invariance_cppc(void)
 	if (!cpu_feature_enabled(X86_FEATURE_APERFMPERF))
 		return;
 
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
+		return;
+
 	mutex_lock(&freq_invariance_lock);
 	if (!init_done)
 		amd_set_max_freq_ratio();

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: kernel test robot <oliver.sang@intel.com>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
	lkp@lists.01.org, lkp@intel.com,
	LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [x86/aperfmperf]  adabc53c25: WARNING:at_arch/x86/kernel/cpu/aperfmperf.c:#freq_invariance_enable
Date: Wed, 27 Apr 2022 16:51:39 +0200	[thread overview]
Message-ID: <8735hyy3yc.ffs@tglx> (raw)
In-Reply-To: <20220426072238.GA613@xsang-OptiPlex-9020>

On Tue, Apr 26 2022 at 15:22, kernel test robot wrote:
> [ 11.086251][ T1] WARNING: CPU: 4 PID: 1 at arch/x86/kernel/cpu/aperfmperf.c:431 freq_invariance_enable (arch/x86/kernel/cpu/aperfmperf.c:431) 
> [ 11.227178][ T1] init_freq_invariance_cppc (arch/x86/kernel/acpi/cppc.c:82 arch/x86/kernel/acpi/cppc.c:96) 
> [ 11.232574][ T1] acpi_cppc_processor_probe (drivers/acpi/cppc_acpi.c:832) 

Bah, the commit in question assumed that the CPPC muck is AMD only....

Fix below.

Thanks,

        tglx
---
--- a/arch/x86/kernel/acpi/cppc.c
+++ b/arch/x86/kernel/acpi/cppc.c
@@ -91,6 +91,9 @@ void init_freq_invariance_cppc(void)
 	if (!cpu_feature_enabled(X86_FEATURE_APERFMPERF))
 		return;
 
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
+		return;
+
 	mutex_lock(&freq_invariance_lock);
 	if (!init_done)
 		amd_set_max_freq_ratio();

  reply	other threads:[~2022-04-27 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  7:22 [x86/aperfmperf] adabc53c25: WARNING:at_arch/x86/kernel/cpu/aperfmperf.c:#freq_invariance_enable kernel test robot
2022-04-26  7:22 ` kernel test robot
2022-04-27 14:51 ` Thomas Gleixner [this message]
2022-04-27 14:51   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735hyy3yc.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.