From: Cleber Rosa <crosa@redhat.com>
To: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, "Fabien Chouteau" <chouteau@adacore.com>,
"Antony Pavlov" <antonynpavlov@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-arm@nongnu.org, "Eric Auger" <eric.auger@redhat.com>,
"Michael Rolnik" <mrolnik@gmail.com>,
"Greg Kurz" <groug@kaod.org>, "Cédric Le Goater" <clg@kaod.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
qemu-s390x@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Eric Farman" <farman@linux.ibm.com>
Subject: Re: [PATCH 5/9] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag
Date: Thu, 03 Mar 2022 07:13:43 -0500 [thread overview]
Message-ID: <8735jzmdib.fsf@p50.localhost.localdomain> (raw)
In-Reply-To: <aa0e1eb4-ef43-b386-e7a3-c034f666181b@gmail.com>
Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> writes:
> On 25/2/22 22:01, Cleber Rosa wrote:
>> Being explicit about the accelerator used on these tests is a good
>> thing in itself, but it will also be used in the filtering rules
>> applied on "make check-avocado".
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>> tests/avocado/linux_ssh_mips_malta.py | 3 +++
>> 1 file changed, 3 insertions(+)
>> diff --git a/tests/avocado/linux_ssh_mips_malta.py
>> b/tests/avocado/linux_ssh_mips_malta.py
>> index c0f0be5ade..0179d8a6ca 100644
>> --- a/tests/avocado/linux_ssh_mips_malta.py
>> +++ b/tests/avocado/linux_ssh_mips_malta.py
>> @@ -23,6 +23,9 @@
>> @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>
> Should we remove this line then? ^^^
>
Yes, we definitely should. But, I thought it should be a next step.
The reason being that manual invocations of avocado or a custom list of
tests to "make check-avocado" will still respect that at this point.
What do you think?
Cheers,
- Cleber.
WARNING: multiple messages have this Message-ID (diff)
From: Cleber Rosa <crosa@redhat.com>
To: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Eric Farman" <farman@linux.ibm.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Antony Pavlov" <antonynpavlov@gmail.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>, "Greg Kurz" <groug@kaod.org>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Eric Auger" <eric.auger@redhat.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
"Michael Rolnik" <mrolnik@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 5/9] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag
Date: Thu, 03 Mar 2022 07:13:43 -0500 [thread overview]
Message-ID: <8735jzmdib.fsf@p50.localhost.localdomain> (raw)
In-Reply-To: <aa0e1eb4-ef43-b386-e7a3-c034f666181b@gmail.com>
Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> writes:
> On 25/2/22 22:01, Cleber Rosa wrote:
>> Being explicit about the accelerator used on these tests is a good
>> thing in itself, but it will also be used in the filtering rules
>> applied on "make check-avocado".
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>> tests/avocado/linux_ssh_mips_malta.py | 3 +++
>> 1 file changed, 3 insertions(+)
>> diff --git a/tests/avocado/linux_ssh_mips_malta.py
>> b/tests/avocado/linux_ssh_mips_malta.py
>> index c0f0be5ade..0179d8a6ca 100644
>> --- a/tests/avocado/linux_ssh_mips_malta.py
>> +++ b/tests/avocado/linux_ssh_mips_malta.py
>> @@ -23,6 +23,9 @@
>> @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>
> Should we remove this line then? ^^^
>
Yes, we definitely should. But, I thought it should be a next step.
The reason being that manual invocations of avocado or a custom list of
tests to "make check-avocado" will still respect that at this point.
What do you think?
Cheers,
- Cleber.
next prev parent reply other threads:[~2022-03-03 12:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 21:01 [PATCH 0/9] Avocado tests: filter out tests using TCG booting full blown distros Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-25 21:01 ` [PATCH 1/9] Avocado GitLab CI jobs: don't reset TARGETS and simplify commands Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-28 9:42 ` Daniel P. Berrangé
2022-02-28 9:42 ` Daniel P. Berrangé
2022-02-25 21:01 ` [PATCH 2/9] Avocado tests: use logging namespace that is preserved in test logs Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-27 18:49 ` Philippe Mathieu-Daudé
2022-02-27 18:49 ` Philippe Mathieu-Daudé
2022-02-28 12:37 ` Alex Bennée
2022-02-28 12:37 ` Alex Bennée
2022-02-25 21:01 ` [PATCH 3/9] Avocado migration test: adapt to "utils.network" API namespace change Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-27 18:48 ` Philippe Mathieu-Daudé
2022-02-27 18:48 ` Philippe Mathieu-Daudé
2022-02-28 14:01 ` Alex Bennée
2022-02-28 14:01 ` Alex Bennée
2022-02-25 21:01 ` [PATCH 4/9] Avocado: bump to version 95.0 Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-28 6:11 ` Thomas Huth
2022-02-28 6:11 ` Thomas Huth
2022-02-25 21:01 ` [PATCH 5/9] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-27 18:47 ` Philippe Mathieu-Daudé
2022-02-27 18:47 ` Philippe Mathieu-Daudé
2022-03-03 12:13 ` Cleber Rosa [this message]
2022-03-03 12:13 ` Cleber Rosa
2022-03-06 23:57 ` Philippe Mathieu-Daudé
2022-03-06 23:57 ` Philippe Mathieu-Daudé
2022-02-25 21:01 ` [PATCH 6/9] tests/avocado/virtiofs_submounts.py: shared_dir may not exist Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-03-11 17:20 ` Beraldo Leal
2022-03-11 17:20 ` Beraldo Leal
2022-02-25 21:01 ` [PATCH 7/9] Avocado tests: improve documentation on tag filtering Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-28 12:14 ` Thomas Huth
2022-02-28 12:14 ` Thomas Huth
2022-02-25 21:01 ` [PATCH 8/9] Avocado tests: classify tests based on what it's booted Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
2022-02-28 7:00 ` Pavel Dovgalyuk
2022-02-28 7:00 ` Pavel Dovgalyuk
2022-02-25 21:01 ` [PATCH 9/9] Avocado tests: don't run tests with TCG that boot full blown distros Cleber Rosa
2022-02-25 21:01 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735jzmdib.fsf@p50.localhost.localdomain \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=antonynpavlov@gmail.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=chouteau@adacore.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=erdnaxe@crans.org \
--cc=eric.auger@redhat.com \
--cc=f4bug@amsat.org \
--cc=farman@linux.ibm.com \
--cc=frederic.konrad@adacore.com \
--cc=groug@kaod.org \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=ma.mandourr@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mrolnik@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.