All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Lee Jones <lee.jones@linaro.org>, lee.jones@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,Ming Lei
	<ming.lei@redhat.com>,Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
Date: Tue, 10 Aug 2021 16:21:01 +0200	[thread overview]
Message-ID: <8735rhs7n6.ffs@tglx> (raw)
In-Reply-To: <20210617073136.315723-1-lee.jones@linaro.org>

On Thu, Jun 17 2021 at 08:31, Lee Jones wrote:
> This sort of information is only generally useful when debugging.
>
> No need to have these sprinkled through the kernel log otherwise.

Yes and no. 

> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  kernel/irq/cpuhotplug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
> index 02236b13b3599..cf8d4f75632e8 100644
> --- a/kernel/irq/cpuhotplug.c
> +++ b/kernel/irq/cpuhotplug.c
> @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
>  		 * If this happens then there was a missed IRQ fixup at some
>  		 * point. Warn about it and enforce fixup.
>  		 */
> -		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",

This one is clearly a warning as this should not happen. See the
comments around that.

> +		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
>  			cpumask_pr_args(m), d->irq, cpu);
>  		return true;
>  	}
> @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
>  		raw_spin_unlock(&desc->lock);
>  
>  		if (affinity_broken) {
> -			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> +			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
>  					    irq, smp_processor_id());

Maybe, but distro people might have opinions on that.

Thanks,

        tglx

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Lee Jones <lee.jones@linaro.org>, lee.jones@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG
Date: Tue, 10 Aug 2021 16:21:01 +0200	[thread overview]
Message-ID: <8735rhs7n6.ffs@tglx> (raw)
In-Reply-To: <20210617073136.315723-1-lee.jones@linaro.org>

On Thu, Jun 17 2021 at 08:31, Lee Jones wrote:
> This sort of information is only generally useful when debugging.
>
> No need to have these sprinkled through the kernel log otherwise.

Yes and no. 

> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  kernel/irq/cpuhotplug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
> index 02236b13b3599..cf8d4f75632e8 100644
> --- a/kernel/irq/cpuhotplug.c
> +++ b/kernel/irq/cpuhotplug.c
> @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d)
>  		 * If this happens then there was a missed IRQ fixup at some
>  		 * point. Warn about it and enforce fixup.
>  		 */
> -		pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",

This one is clearly a warning as this should not happen. See the
comments around that.

> +		pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n",
>  			cpumask_pr_args(m), d->irq, cpu);
>  		return true;
>  	}
> @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void)
>  		raw_spin_unlock(&desc->lock);
>  
>  		if (affinity_broken) {
> -			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
> +			pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
>  					    irq, smp_processor_id());

Maybe, but distro people might have opinions on that.

Thanks,

        tglx

  reply	other threads:[~2021-08-10 14:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  7:31 [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG Lee Jones
2021-06-17  7:31 ` Lee Jones
2021-08-10 14:21 ` Thomas Gleixner [this message]
2021-08-10 14:21   ` Thomas Gleixner
2021-08-11  7:57   ` Lee Jones
2021-08-11  7:57     ` Lee Jones
2021-08-11 12:08     ` Thomas Gleixner
2021-08-11 12:08       ` Thomas Gleixner
2021-08-16  7:43       ` Lee Jones
2021-08-16  7:43         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735rhs7n6.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=hare@suse.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.