From: Marc Zyngier <maz@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
cohuck@redhat.com, stable@vger.kernel.org,
alex.williamson@redhat.com, Zhu Lingshan <lingshan.zhu@intel.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect"
Date: Mon, 10 May 2021 08:39:59 +0100 [thread overview]
Message-ID: <8735uvox4g.wl-maz@kernel.org> (raw)
In-Reply-To: <cfb68374-a7bf-1eb4-86cf-77c57f7fe9e5@hisilicon.com>
On Mon, 10 May 2021 02:12:22 +0100,
Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
>
> Hi Marc,
>
> On 2021/5/8 17:29, Marc Zyngier wrote:
> > On Sat, 08 May 2021 08:11:52 +0100,
> > Zhu Lingshan <lingshan.zhu@intel.com> wrote:
> >>
> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88.
> >>
> >> The reverted commit may cause VM freeze on arm64 platform.
> >> Because on arm64 platform, stop a consumer will suspend the VM,
> >> the VM will freeze without a start consumer
> >
> > It also unconditionally calls del_consumer on the producer, which
> > isn't exactly expected.
> >
> >>
> >> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> >
> > Reported-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> Thanks for the tag, it works with this patch, So:
> Tested-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> I shall invite you to have a drink for the quick debug.
> Anyway, thank you again.
No worries, glad we were able to root-cause the problem quickly
enough.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Zhu Lingshan <lingshan.zhu@intel.com>, <jasowang@redhat.com>,
<mst@redhat.com>, <alex.williamson@redhat.com>,
<kvm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<kvmarm@lists.cs.columbia.edu>, <cohuck@redhat.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect"
Date: Mon, 10 May 2021 08:39:59 +0100 [thread overview]
Message-ID: <8735uvox4g.wl-maz@kernel.org> (raw)
In-Reply-To: <cfb68374-a7bf-1eb4-86cf-77c57f7fe9e5@hisilicon.com>
On Mon, 10 May 2021 02:12:22 +0100,
Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
>
> Hi Marc,
>
> On 2021/5/8 17:29, Marc Zyngier wrote:
> > On Sat, 08 May 2021 08:11:52 +0100,
> > Zhu Lingshan <lingshan.zhu@intel.com> wrote:
> >>
> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88.
> >>
> >> The reverted commit may cause VM freeze on arm64 platform.
> >> Because on arm64 platform, stop a consumer will suspend the VM,
> >> the VM will freeze without a start consumer
> >
> > It also unconditionally calls del_consumer on the producer, which
> > isn't exactly expected.
> >
> >>
> >> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> >
> > Reported-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> Thanks for the tag, it works with this patch, So:
> Tested-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> I shall invite you to have a drink for the quick debug.
> Anyway, thank you again.
No worries, glad we were able to root-cause the problem quickly
enough.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Zhu Lingshan <lingshan.zhu@intel.com>, <jasowang@redhat.com>,
<mst@redhat.com>, <alex.williamson@redhat.com>,
<kvm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<kvmarm@lists.cs.columbia.edu>, <cohuck@redhat.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect"
Date: Mon, 10 May 2021 08:39:59 +0100 [thread overview]
Message-ID: <8735uvox4g.wl-maz@kernel.org> (raw)
In-Reply-To: <cfb68374-a7bf-1eb4-86cf-77c57f7fe9e5@hisilicon.com>
On Mon, 10 May 2021 02:12:22 +0100,
Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
>
> Hi Marc,
>
> On 2021/5/8 17:29, Marc Zyngier wrote:
> > On Sat, 08 May 2021 08:11:52 +0100,
> > Zhu Lingshan <lingshan.zhu@intel.com> wrote:
> >>
> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88.
> >>
> >> The reverted commit may cause VM freeze on arm64 platform.
> >> Because on arm64 platform, stop a consumer will suspend the VM,
> >> the VM will freeze without a start consumer
> >
> > It also unconditionally calls del_consumer on the producer, which
> > isn't exactly expected.
> >
> >>
> >> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> >
> > Reported-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> Thanks for the tag, it works with this patch, So:
> Tested-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> I shall invite you to have a drink for the quick debug.
> Anyway, thank you again.
No worries, glad we were able to root-cause the problem quickly
enough.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-05-10 7:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 7:11 [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" Zhu Lingshan
2021-05-08 7:11 ` Zhu Lingshan
2021-05-08 7:11 ` Zhu Lingshan
2021-05-08 7:22 ` Greg KH
2021-05-08 7:22 ` Greg KH
2021-05-08 7:22 ` Greg KH
2021-05-08 9:29 ` Marc Zyngier
2021-05-08 9:29 ` Marc Zyngier
2021-05-08 9:29 ` Marc Zyngier
2021-05-09 17:04 ` Auger Eric
2021-05-09 17:04 ` Auger Eric
2021-05-09 17:04 ` Auger Eric
2021-05-10 1:12 ` Shaokun Zhang
2021-05-10 1:12 ` Shaokun Zhang
2021-05-10 1:12 ` Shaokun Zhang
2021-05-10 7:39 ` Marc Zyngier [this message]
2021-05-10 7:39 ` Marc Zyngier
2021-05-10 7:39 ` Marc Zyngier
2021-05-10 2:43 ` Jason Wang
2021-05-10 2:43 ` Jason Wang
2021-05-10 2:43 ` Jason Wang
2021-05-10 3:00 ` Zhu, Lingshan
2021-05-10 3:00 ` Zhu, Lingshan
2021-05-10 3:00 ` Zhu, Lingshan
2021-05-10 4:34 ` Jason Wang
2021-05-10 4:34 ` Jason Wang
2021-05-10 4:34 ` Jason Wang
2021-05-10 7:09 ` Zhu, Lingshan
2021-05-10 7:09 ` Zhu, Lingshan
2021-05-10 7:09 ` Zhu, Lingshan
2021-05-10 8:32 ` Zhu, Lingshan
2021-05-10 8:32 ` Zhu, Lingshan
2021-05-10 8:32 ` Zhu, Lingshan
2021-05-10 10:00 ` Marc Zyngier
2021-05-10 10:00 ` Marc Zyngier
2021-05-10 10:00 ` Marc Zyngier
2021-05-10 10:37 ` Zhu, Lingshan
2021-05-10 10:37 ` Zhu, Lingshan
2021-05-10 10:37 ` Zhu, Lingshan
2021-05-10 11:01 ` Marc Zyngier
2021-05-10 11:01 ` Marc Zyngier
2021-05-10 11:01 ` Marc Zyngier
2021-05-11 8:48 ` Michael S. Tsirkin
2021-05-11 8:48 ` Michael S. Tsirkin
2021-05-11 8:48 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735uvox4g.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=lingshan.zhu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.