From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Sarah Harris" <S.E.Harris@kent.ac.uk>,
"Max Filippov" <jcmvbkbc@gmail.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Anthony Green" <green@moxielogic.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Chris Wulff" <crwulff@gmail.com>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
qemu-riscv@nongnu.org, "David Hildenbrand" <david@redhat.com>,
qemu-arm@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Michael Walle" <michael@walle.cc>, "Greg Kurz" <groug@kaod.org>,
qemu-ppc@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Stafford Horne" <shorne@gmail.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Marek Vasut" <marex@denx.de>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Michael Rolnik" <mrolnik@gmail.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 10/10] target: Move SEMIHOSTING feature to target Kconfig
Date: Mon, 01 Feb 2021 11:56:08 +0000 [thread overview]
Message-ID: <8735ygvvtu.fsf@linaro.org> (raw)
In-Reply-To: <20210131111316.232778-11-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> SEMIHOSTING is an architecture feature, move its declaration to
> each target/ARCH/.
I'm going to punt on this one and leave it to the arch maintainers to
opine because AIUI in a lot of cases semihosting is more of a "useful
hack" than something mandated by the architecture.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> default-configs/devices/lm32-softmmu.mak | 2 --
> default-configs/devices/m68k-softmmu.mak | 2 --
> default-configs/devices/mips-softmmu-common.mak | 3 ---
> default-configs/devices/nios2-softmmu.mak | 2 --
> default-configs/devices/unicore32-softmmu.mak | 1 -
> default-configs/devices/xtensa-softmmu.mak | 2 --
> target/lm32/Kconfig | 1 +
> target/m68k/Kconfig | 1 +
> target/mips/Kconfig | 1 +
> target/nios2/Kconfig | 1 +
> target/unicore32/Kconfig | 1 +
> target/xtensa/Kconfig | 1 +
> 12 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/default-configs/devices/lm32-softmmu.mak b/default-configs/devices/lm32-softmmu.mak
> index 1bce3f6e8b6..1f69795b749 100644
> --- a/default-configs/devices/lm32-softmmu.mak
> +++ b/default-configs/devices/lm32-softmmu.mak
> @@ -4,8 +4,6 @@
> #
> #CONFIG_MILKYMIST_TMU2=n # disabling it actually causes compile-time failures
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_LM32_EVR=y
> diff --git a/default-configs/devices/m68k-softmmu.mak b/default-configs/devices/m68k-softmmu.mak
> index 6629fd2aa33..4fef4bd731d 100644
> --- a/default-configs/devices/m68k-softmmu.mak
> +++ b/default-configs/devices/m68k-softmmu.mak
> @@ -1,7 +1,5 @@
> # Default configuration for m68k-softmmu
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_AN5206=y
> diff --git a/default-configs/devices/mips-softmmu-common.mak b/default-configs/devices/mips-softmmu-common.mak
> index ea78fe72759..af652ec7bdd 100644
> --- a/default-configs/devices/mips-softmmu-common.mak
> +++ b/default-configs/devices/mips-softmmu-common.mak
> @@ -1,8 +1,5 @@
> # Common mips*-softmmu CONFIG defines
>
> -# CONFIG_SEMIHOSTING is always required on this architecture
> -CONFIG_SEMIHOSTING=y
> -
> CONFIG_ISA_BUS=y
> CONFIG_PCI=y
> CONFIG_PCI_DEVICES=y
> diff --git a/default-configs/devices/nios2-softmmu.mak b/default-configs/devices/nios2-softmmu.mak
> index 1bc4082ea99..e130d024e62 100644
> --- a/default-configs/devices/nios2-softmmu.mak
> +++ b/default-configs/devices/nios2-softmmu.mak
> @@ -1,7 +1,5 @@
> # Default configuration for nios2-softmmu
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_NIOS2_10M50=y
> diff --git a/default-configs/devices/unicore32-softmmu.mak b/default-configs/devices/unicore32-softmmu.mak
> index 899288e3d71..0bfce48c6da 100644
> --- a/default-configs/devices/unicore32-softmmu.mak
> +++ b/default-configs/devices/unicore32-softmmu.mak
> @@ -3,4 +3,3 @@
> # Boards:
> #
> CONFIG_PUV3=y
> -CONFIG_SEMIHOSTING=y
> diff --git a/default-configs/devices/xtensa-softmmu.mak b/default-configs/devices/xtensa-softmmu.mak
> index 4fe1bf00c94..49e4c9da88c 100644
> --- a/default-configs/devices/xtensa-softmmu.mak
> +++ b/default-configs/devices/xtensa-softmmu.mak
> @@ -1,7 +1,5 @@
> # Default configuration for Xtensa
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_XTENSA_SIM=y
> diff --git a/target/lm32/Kconfig b/target/lm32/Kconfig
> index 09de5b703a3..286710fd47b 100644
> --- a/target/lm32/Kconfig
> +++ b/target/lm32/Kconfig
> @@ -1,2 +1,3 @@
> config LM32
> bool
> + select SEMIHOSTING
> diff --git a/target/m68k/Kconfig b/target/m68k/Kconfig
> index 23debad519a..9eae71486ff 100644
> --- a/target/m68k/Kconfig
> +++ b/target/m68k/Kconfig
> @@ -1,2 +1,3 @@
> config M68K
> bool
> + select SEMIHOSTING
> diff --git a/target/mips/Kconfig b/target/mips/Kconfig
> index 6adf1453548..eb19c94c7d4 100644
> --- a/target/mips/Kconfig
> +++ b/target/mips/Kconfig
> @@ -1,5 +1,6 @@
> config MIPS
> bool
> + select SEMIHOSTING
>
> config MIPS64
> bool
> diff --git a/target/nios2/Kconfig b/target/nios2/Kconfig
> index 1529ab8950d..c65550c861a 100644
> --- a/target/nios2/Kconfig
> +++ b/target/nios2/Kconfig
> @@ -1,2 +1,3 @@
> config NIOS2
> bool
> + select SEMIHOSTING
> diff --git a/target/unicore32/Kconfig b/target/unicore32/Kconfig
> index 62c9d10b38f..c699d5238ea 100644
> --- a/target/unicore32/Kconfig
> +++ b/target/unicore32/Kconfig
> @@ -1,2 +1,3 @@
> config UNICORE32
> bool
> + select SEMIHOSTING
> diff --git a/target/xtensa/Kconfig b/target/xtensa/Kconfig
> index a3c8dc7f6d7..5e46049262d 100644
> --- a/target/xtensa/Kconfig
> +++ b/target/xtensa/Kconfig
> @@ -1,2 +1,3 @@
> config XTENSA
> bool
> + select SEMIHOSTING
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Sarah Harris" <S.E.Harris@kent.ac.uk>,
"Cornelia Huck" <cohuck@redhat.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Anthony Green" <green@moxielogic.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Max Filippov" <jcmvbkbc@gmail.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Marek Vasut" <marex@denx.de>,
qemu-block@nongnu.org, "David Hildenbrand" <david@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
"Michael Rolnik" <mrolnik@gmail.com>,
"Stafford Horne" <shorne@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Kevin Wolf" <kwolf@redhat.com>,
qemu-riscv@nongnu.org,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Chris Wulff" <crwulff@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Max Reitz" <mreitz@redhat.com>,
"Michael Walle" <michael@walle.cc>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 10/10] target: Move SEMIHOSTING feature to target Kconfig
Date: Mon, 01 Feb 2021 11:56:08 +0000 [thread overview]
Message-ID: <8735ygvvtu.fsf@linaro.org> (raw)
In-Reply-To: <20210131111316.232778-11-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> SEMIHOSTING is an architecture feature, move its declaration to
> each target/ARCH/.
I'm going to punt on this one and leave it to the arch maintainers to
opine because AIUI in a lot of cases semihosting is more of a "useful
hack" than something mandated by the architecture.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> default-configs/devices/lm32-softmmu.mak | 2 --
> default-configs/devices/m68k-softmmu.mak | 2 --
> default-configs/devices/mips-softmmu-common.mak | 3 ---
> default-configs/devices/nios2-softmmu.mak | 2 --
> default-configs/devices/unicore32-softmmu.mak | 1 -
> default-configs/devices/xtensa-softmmu.mak | 2 --
> target/lm32/Kconfig | 1 +
> target/m68k/Kconfig | 1 +
> target/mips/Kconfig | 1 +
> target/nios2/Kconfig | 1 +
> target/unicore32/Kconfig | 1 +
> target/xtensa/Kconfig | 1 +
> 12 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/default-configs/devices/lm32-softmmu.mak b/default-configs/devices/lm32-softmmu.mak
> index 1bce3f6e8b6..1f69795b749 100644
> --- a/default-configs/devices/lm32-softmmu.mak
> +++ b/default-configs/devices/lm32-softmmu.mak
> @@ -4,8 +4,6 @@
> #
> #CONFIG_MILKYMIST_TMU2=n # disabling it actually causes compile-time failures
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_LM32_EVR=y
> diff --git a/default-configs/devices/m68k-softmmu.mak b/default-configs/devices/m68k-softmmu.mak
> index 6629fd2aa33..4fef4bd731d 100644
> --- a/default-configs/devices/m68k-softmmu.mak
> +++ b/default-configs/devices/m68k-softmmu.mak
> @@ -1,7 +1,5 @@
> # Default configuration for m68k-softmmu
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_AN5206=y
> diff --git a/default-configs/devices/mips-softmmu-common.mak b/default-configs/devices/mips-softmmu-common.mak
> index ea78fe72759..af652ec7bdd 100644
> --- a/default-configs/devices/mips-softmmu-common.mak
> +++ b/default-configs/devices/mips-softmmu-common.mak
> @@ -1,8 +1,5 @@
> # Common mips*-softmmu CONFIG defines
>
> -# CONFIG_SEMIHOSTING is always required on this architecture
> -CONFIG_SEMIHOSTING=y
> -
> CONFIG_ISA_BUS=y
> CONFIG_PCI=y
> CONFIG_PCI_DEVICES=y
> diff --git a/default-configs/devices/nios2-softmmu.mak b/default-configs/devices/nios2-softmmu.mak
> index 1bc4082ea99..e130d024e62 100644
> --- a/default-configs/devices/nios2-softmmu.mak
> +++ b/default-configs/devices/nios2-softmmu.mak
> @@ -1,7 +1,5 @@
> # Default configuration for nios2-softmmu
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_NIOS2_10M50=y
> diff --git a/default-configs/devices/unicore32-softmmu.mak b/default-configs/devices/unicore32-softmmu.mak
> index 899288e3d71..0bfce48c6da 100644
> --- a/default-configs/devices/unicore32-softmmu.mak
> +++ b/default-configs/devices/unicore32-softmmu.mak
> @@ -3,4 +3,3 @@
> # Boards:
> #
> CONFIG_PUV3=y
> -CONFIG_SEMIHOSTING=y
> diff --git a/default-configs/devices/xtensa-softmmu.mak b/default-configs/devices/xtensa-softmmu.mak
> index 4fe1bf00c94..49e4c9da88c 100644
> --- a/default-configs/devices/xtensa-softmmu.mak
> +++ b/default-configs/devices/xtensa-softmmu.mak
> @@ -1,7 +1,5 @@
> # Default configuration for Xtensa
>
> -CONFIG_SEMIHOSTING=y
> -
> # Boards:
> #
> CONFIG_XTENSA_SIM=y
> diff --git a/target/lm32/Kconfig b/target/lm32/Kconfig
> index 09de5b703a3..286710fd47b 100644
> --- a/target/lm32/Kconfig
> +++ b/target/lm32/Kconfig
> @@ -1,2 +1,3 @@
> config LM32
> bool
> + select SEMIHOSTING
> diff --git a/target/m68k/Kconfig b/target/m68k/Kconfig
> index 23debad519a..9eae71486ff 100644
> --- a/target/m68k/Kconfig
> +++ b/target/m68k/Kconfig
> @@ -1,2 +1,3 @@
> config M68K
> bool
> + select SEMIHOSTING
> diff --git a/target/mips/Kconfig b/target/mips/Kconfig
> index 6adf1453548..eb19c94c7d4 100644
> --- a/target/mips/Kconfig
> +++ b/target/mips/Kconfig
> @@ -1,5 +1,6 @@
> config MIPS
> bool
> + select SEMIHOSTING
>
> config MIPS64
> bool
> diff --git a/target/nios2/Kconfig b/target/nios2/Kconfig
> index 1529ab8950d..c65550c861a 100644
> --- a/target/nios2/Kconfig
> +++ b/target/nios2/Kconfig
> @@ -1,2 +1,3 @@
> config NIOS2
> bool
> + select SEMIHOSTING
> diff --git a/target/unicore32/Kconfig b/target/unicore32/Kconfig
> index 62c9d10b38f..c699d5238ea 100644
> --- a/target/unicore32/Kconfig
> +++ b/target/unicore32/Kconfig
> @@ -1,2 +1,3 @@
> config UNICORE32
> bool
> + select SEMIHOSTING
> diff --git a/target/xtensa/Kconfig b/target/xtensa/Kconfig
> index a3c8dc7f6d7..5e46049262d 100644
> --- a/target/xtensa/Kconfig
> +++ b/target/xtensa/Kconfig
> @@ -1,2 +1,3 @@
> config XTENSA
> bool
> + select SEMIHOSTING
--
Alex Bennée
next prev parent reply other threads:[~2021-02-01 12:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 11:13 [PATCH 00/10] target: Provide target-specific Kconfig Philippe Mathieu-Daudé
2021-01-31 11:13 ` [PATCH 01/10] hw/sh4/Kconfig: Rename CONFIG_SH4 -> CONFIG_SH4_PERIPHERALS Philippe Mathieu-Daudé
2021-02-01 10:24 ` Alex Bennée
2021-02-01 10:24 ` Alex Bennée
2021-01-31 11:13 ` [PATCH 02/10] hw/lm32/Kconfig: Introduce CONFIG_LM32_EVR for lm32-evr/uclinux boards Philippe Mathieu-Daudé
2021-02-01 10:28 ` Alex Bennée
2021-02-01 10:28 ` Alex Bennée
2021-01-31 11:13 ` [PATCH 03/10] hw/sh4/Kconfig: Rename CONFIG_LM32 -> CONFIG_LM32_PERIPHERALS Philippe Mathieu-Daudé
2021-02-01 10:29 ` Alex Bennée
2021-02-01 10:29 ` Alex Bennée
2021-01-31 11:13 ` [PATCH 04/10] hw/lm32/Kconfig: Have MILKYMIST select LM32_PERIPHERALS Philippe Mathieu-Daudé
2021-02-01 11:11 ` Alex Bennée
2021-02-01 11:11 ` Alex Bennée
2021-01-31 11:13 ` [PATCH 05/10] meson: Introduce target-specific Kconfig Philippe Mathieu-Daudé
2021-01-31 11:40 ` Artyom Tarasenko
2021-01-31 12:36 ` Philippe Mathieu-Daudé
2021-01-31 15:34 ` Philippe Mathieu-Daudé
2021-01-31 15:34 ` Philippe Mathieu-Daudé
2021-02-01 11:23 ` Alex Bennée
2021-02-01 11:23 ` Alex Bennée
2021-01-31 11:13 ` [PATCH 06/10] target/i386: Move SEV feature to target Kconfig Philippe Mathieu-Daudé
2021-02-01 11:20 ` Alex Bennée
2021-02-01 11:20 ` Alex Bennée
2021-01-31 11:13 ` [PATCH 07/10] target/arm: Move V7M " Philippe Mathieu-Daudé
2021-02-01 11:25 ` Alex Bennée
2021-02-01 11:25 ` Alex Bennée
2021-01-31 11:13 ` [PATCH 08/10] default-configs: Remove unnecessary SEMIHOSTING selection Philippe Mathieu-Daudé
2021-02-01 11:53 ` Alex Bennée
2021-02-01 11:53 ` Alex Bennée
2021-02-01 19:58 ` Alistair Francis
2021-02-01 19:58 ` Alistair Francis
2021-01-31 11:13 ` [PATCH 09/10] target: Move ARM_COMPATIBLE_SEMIHOSTING feature to target Kconfig Philippe Mathieu-Daudé
2021-02-01 11:54 ` Alex Bennée
2021-02-01 11:54 ` Alex Bennée
2021-02-01 19:59 ` Alistair Francis
2021-02-01 19:59 ` Alistair Francis
2021-01-31 11:13 ` [PATCH 10/10] target: Move SEMIHOSTING " Philippe Mathieu-Daudé
2021-01-31 11:13 ` Philippe Mathieu-Daudé
2021-02-01 11:56 ` Alex Bennée [this message]
2021-02-01 11:56 ` Alex Bennée
2021-03-10 13:30 ` [PATCH 00/10] target: Provide target-specific Kconfig Claudio Fontana
2021-03-10 13:30 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735ygvvtu.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.rikalo@syrmia.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=cohuck@redhat.com \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=green@moxielogic.com \
--cc=groug@kaod.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=mreitz@redhat.com \
--cc=mrolnik@gmail.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
--cc=shorne@gmail.com \
--cc=thuth@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.