From: Markus Armbruster <armbru@redhat.com>
To: <luoyonggang@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py
Date: Tue, 06 Oct 2020 13:57:19 +0200 [thread overview]
Message-ID: <87362rsh28.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAE2XoE-QZBm=nkimjzTN424LsciD1J3p4DwjDR4uFm2tY07y3w@mail.gmail.com> ("罗勇刚(Yonggang Luo)"'s message of "Tue, 6 Oct 2020 19:04:48 +0800")
罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:
> On Tue, Oct 6, 2020 at 6:33 PM Peter Maydell <peter.maydell@linaro.org>
> wrote:
>>
>> On Mon, 5 Oct 2020 at 20:51, Yonggang Luo <luoyonggang@gmail.com> wrote:
>> >
>> > The sh script are harder to maintain for compatible different
>> > xsh environment so convert it to python script
>> > Also incorporate the fixes in
>> >
> https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lureau@redhat.com/
>> >
>> > Testing args length and if not enough, setting pkgversion and version
> to ''
>> >
>> > +#
>> > +# Script for retrieve qemu git version information
>> > +#
>> > +# Author: Yonggang Luo <luoyonggang@gmail.com>
>> > +#
>> > +# This work is licensed under the terms of the GNU GPL, version 2. See
>> > +# the COPYING file in the top-level directory.
>>
>> Does this have to be GPL-v2-only ? We strongly prefer
>> v2-or-later...
> Directly copy from other python script, do you have a template for this?
Copy from scripts/qapi-gen.py:
# This work is licensed under the terms of the GNU GPL, version 2 or later.
# See the COPYING file in the top-level directory.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: <luoyonggang@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py
Date: Tue, 06 Oct 2020 13:57:19 +0200 [thread overview]
Message-ID: <87362rsh28.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAE2XoE-QZBm=nkimjzTN424LsciD1J3p4DwjDR4uFm2tY07y3w@mail.gmail.com> ("罗勇刚(Yonggang Luo)"'s message of "Tue, 6 Oct 2020 19:04:48 +0800")
罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:
> On Tue, Oct 6, 2020 at 6:33 PM Peter Maydell <peter.maydell@linaro.org>
> wrote:
>>
>> On Mon, 5 Oct 2020 at 20:51, Yonggang Luo <luoyonggang@gmail.com> wrote:
>> >
>> > The sh script are harder to maintain for compatible different
>> > xsh environment so convert it to python script
>> > Also incorporate the fixes in
>> >
> https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lureau@redhat.com/
>> >
>> > Testing args length and if not enough, setting pkgversion and version
> to ''
>> >
>> > +#
>> > +# Script for retrieve qemu git version information
>> > +#
>> > +# Author: Yonggang Luo <luoyonggang@gmail.com>
>> > +#
>> > +# This work is licensed under the terms of the GNU GPL, version 2. See
>> > +# the COPYING file in the top-level directory.
>>
>> Does this have to be GPL-v2-only ? We strongly prefer
>> v2-or-later...
> Directly copy from other python script, do you have a template for this?
Copy from scripts/qapi-gen.py:
# This work is licensed under the terms of the GNU GPL, version 2 or later.
# See the COPYING file in the top-level directory.
next prev parent reply other threads:[~2020-10-06 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 19:51 [PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py Yonggang Luo
2020-10-05 19:51 ` Yonggang Luo
2020-10-05 20:00 ` Marc-André Lureau
2020-10-05 20:00 ` Marc-André Lureau
2020-10-06 7:43 ` Paolo Bonzini
2020-10-06 7:43 ` Paolo Bonzini
2020-10-06 10:33 ` Peter Maydell
2020-10-06 10:33 ` Peter Maydell
2020-10-06 11:04 ` 罗勇刚(Yonggang Luo)
2020-10-06 11:04 ` 罗勇刚(Yonggang Luo)
2020-10-06 11:57 ` Markus Armbruster [this message]
2020-10-06 11:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87362rsh28.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.