From: Marc Zyngier <maz@kernel.org>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: justin.he@arm.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
richardcochran@gmail.com, linux-kernel@vger.kernel.org,
sean.j.christopherson@intel.com, steven.price@arm.com,
john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com,
tglx@linutronix.de, nd@arm.com, will@kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp.
Date: Sat, 05 Sep 2020 12:04:10 +0100 [thread overview]
Message-ID: <87363wmqmt.wl-maz@kernel.org> (raw)
In-Reply-To: <20200904092744.167655-8-jianyong.wu@arm.com>
On Fri, 04 Sep 2020 10:27:41 +0100,
Jianyong Wu <jianyong.wu@arm.com> wrote:
>
> ptp_kvm will get this service through smccc call.
> The service offers wall time and counter cycle of host for guest.
> caller must explicitly determines which cycle of virtual counter or
> physical counter to return if it needs counter cycle.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
> arch/arm64/kvm/Kconfig | 6 +++++
> arch/arm64/kvm/arch_timer.c | 2 +-
> arch/arm64/kvm/hypercalls.c | 49 ++++++++++++++++++++++++++++++++++++
> include/kvm/arm_arch_timer.h | 1 +
> include/linux/arm-smccc.h | 16 ++++++++++++
> 5 files changed, 73 insertions(+), 1 deletion(-)
>
[...]
On top of what I said yesterday:
> index 32ba6fbc3814..eb85f6701845 100644
> --- a/arch/arm64/kvm/arch_timer.c
> +++ b/arch/arm64/kvm/arch_timer.c
> @@ -81,7 +81,7 @@ u64 timer_get_cval(struct arch_timer_context *ctxt)
> }
> }
>
> -static u64 timer_get_offset(struct arch_timer_context *ctxt)
> +u64 timer_get_offset(struct arch_timer_context *ctxt)
> {
> struct kvm_vcpu *vcpu = ctxt->vcpu;
>
Why has this become global? I can't see a reason why we would want to
expose this purely KVM internal helper.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: Mark.Rutland@arm.com, justin.he@arm.com, kvm@vger.kernel.org,
suzuki.poulose@arm.com, netdev@vger.kernel.org,
richardcochran@gmail.com, Steve.Capper@arm.com,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
steven.price@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com,
pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com,
will@kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp.
Date: Sat, 05 Sep 2020 12:04:10 +0100 [thread overview]
Message-ID: <87363wmqmt.wl-maz@kernel.org> (raw)
In-Reply-To: <20200904092744.167655-8-jianyong.wu@arm.com>
On Fri, 04 Sep 2020 10:27:41 +0100,
Jianyong Wu <jianyong.wu@arm.com> wrote:
>
> ptp_kvm will get this service through smccc call.
> The service offers wall time and counter cycle of host for guest.
> caller must explicitly determines which cycle of virtual counter or
> physical counter to return if it needs counter cycle.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
> arch/arm64/kvm/Kconfig | 6 +++++
> arch/arm64/kvm/arch_timer.c | 2 +-
> arch/arm64/kvm/hypercalls.c | 49 ++++++++++++++++++++++++++++++++++++
> include/kvm/arm_arch_timer.h | 1 +
> include/linux/arm-smccc.h | 16 ++++++++++++
> 5 files changed, 73 insertions(+), 1 deletion(-)
>
[...]
On top of what I said yesterday:
> index 32ba6fbc3814..eb85f6701845 100644
> --- a/arch/arm64/kvm/arch_timer.c
> +++ b/arch/arm64/kvm/arch_timer.c
> @@ -81,7 +81,7 @@ u64 timer_get_cval(struct arch_timer_context *ctxt)
> }
> }
>
> -static u64 timer_get_offset(struct arch_timer_context *ctxt)
> +u64 timer_get_offset(struct arch_timer_context *ctxt)
> {
> struct kvm_vcpu *vcpu = ctxt->vcpu;
>
Why has this become global? I can't see a reason why we would want to
expose this purely KVM internal helper.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: netdev@vger.kernel.org, yangbo.lu@nxp.com,
john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com,
sean.j.christopherson@intel.com, richardcochran@gmail.com,
Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com,
steven.price@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com
Subject: Re: [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp.
Date: Sat, 05 Sep 2020 12:04:10 +0100 [thread overview]
Message-ID: <87363wmqmt.wl-maz@kernel.org> (raw)
In-Reply-To: <20200904092744.167655-8-jianyong.wu@arm.com>
On Fri, 04 Sep 2020 10:27:41 +0100,
Jianyong Wu <jianyong.wu@arm.com> wrote:
>
> ptp_kvm will get this service through smccc call.
> The service offers wall time and counter cycle of host for guest.
> caller must explicitly determines which cycle of virtual counter or
> physical counter to return if it needs counter cycle.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
> arch/arm64/kvm/Kconfig | 6 +++++
> arch/arm64/kvm/arch_timer.c | 2 +-
> arch/arm64/kvm/hypercalls.c | 49 ++++++++++++++++++++++++++++++++++++
> include/kvm/arm_arch_timer.h | 1 +
> include/linux/arm-smccc.h | 16 ++++++++++++
> 5 files changed, 73 insertions(+), 1 deletion(-)
>
[...]
On top of what I said yesterday:
> index 32ba6fbc3814..eb85f6701845 100644
> --- a/arch/arm64/kvm/arch_timer.c
> +++ b/arch/arm64/kvm/arch_timer.c
> @@ -81,7 +81,7 @@ u64 timer_get_cval(struct arch_timer_context *ctxt)
> }
> }
>
> -static u64 timer_get_offset(struct arch_timer_context *ctxt)
> +u64 timer_get_offset(struct arch_timer_context *ctxt)
> {
> struct kvm_vcpu *vcpu = ctxt->vcpu;
>
Why has this become global? I can't see a reason why we would want to
expose this purely KVM internal helper.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2020-09-05 11:04 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 9:27 [PATCH v14 00/10] Enable ptp_kvm for arm64 Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 01/10] arm64: Probe for the presence of KVM hypervisor services during boot Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 02/10] arm/arm64: KVM: Advertise KVM UID to guests via SMCCC Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 03/10] smccc: Export smccc conduit get helper Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 04/10] ptp: Reorganize ptp_kvm module to make it arch-independent Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 05/10] time: Add mechanism to recognize clocksource in time_get_snapshot Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 06/10] clocksource: Add clocksource id for arm arch counter Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 16:15 ` Marc Zyngier
2020-09-04 16:15 ` Marc Zyngier
2020-09-04 16:15 ` Marc Zyngier
2020-09-07 8:10 ` Jianyong Wu
2020-09-07 8:10 ` Jianyong Wu
2020-09-07 8:10 ` Jianyong Wu
2020-09-05 11:04 ` Marc Zyngier [this message]
2020-09-05 11:04 ` Marc Zyngier
2020-09-05 11:04 ` Marc Zyngier
2020-09-07 8:13 ` Jianyong Wu
2020-09-07 8:13 ` Jianyong Wu
2020-09-07 8:13 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64 Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-05 11:01 ` Marc Zyngier
2020-09-05 11:01 ` Marc Zyngier
2020-09-05 11:01 ` Marc Zyngier
2020-09-06 10:00 ` Marc Zyngier
2020-09-06 10:00 ` Marc Zyngier
2020-09-06 10:00 ` Marc Zyngier
2020-09-07 8:40 ` Jianyong Wu
2020-09-07 8:40 ` Jianyong Wu
2020-09-07 8:40 ` Jianyong Wu
2020-09-07 8:54 ` Marc Zyngier
2020-09-07 8:54 ` Marc Zyngier
2020-09-07 8:54 ` Marc Zyngier
2020-09-07 9:28 ` Jianyong Wu
2020-09-07 9:28 ` Jianyong Wu
2020-09-07 9:28 ` Jianyong Wu
2020-09-07 9:47 ` Marc Zyngier
2020-09-07 9:47 ` Marc Zyngier
2020-09-07 9:47 ` Marc Zyngier
2020-09-07 10:11 ` Jianyong Wu
2020-09-07 10:11 ` Jianyong Wu
2020-09-07 10:11 ` Jianyong Wu
2020-09-05 11:33 ` Marc Zyngier
2020-09-05 11:33 ` Marc Zyngier
2020-09-05 11:33 ` Marc Zyngier
2020-09-07 8:51 ` Jianyong Wu
2020-09-07 8:51 ` Jianyong Wu
2020-09-07 8:51 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 09/10] doc: add ptp_kvm introduction for arm64 support Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 16:18 ` Marc Zyngier
2020-09-04 16:18 ` Marc Zyngier
2020-09-04 16:18 ` Marc Zyngier
2020-09-07 7:55 ` Jianyong Wu
2020-09-07 7:55 ` Jianyong Wu
2020-09-07 7:55 ` Jianyong Wu
2020-09-04 9:27 ` [PATCH v14 10/10] arm64: Add kvm capability check extension for ptp_kvm Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
2020-09-04 9:27 ` Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87363wmqmt.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=jianyong.wu@arm.com \
--cc=john.stultz@linaro.org \
--cc=justin.he@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sean.j.christopherson@intel.com \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.