From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH] target/arm: Delete unused VFP_DREG macros
Date: Mon, 03 Aug 2020 14:27:57 +0100 [thread overview]
Message-ID: <873653oo4i.fsf@linaro.org> (raw)
In-Reply-To: <20200803124848.18295-1-peter.maydell@linaro.org>
Peter Maydell <peter.maydell@linaro.org> writes:
> As part of the Neon decodetree conversion we removed all
> the uses of the VFP_DREG macros, but forgot to remove the
> macro definitions. Do so now.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/translate.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index c39a929b938..27bf6cd8b51 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -2471,21 +2471,6 @@ static int disas_dsp_insn(DisasContext *s, uint32_t insn)
> return 1;
> }
>
> -#define VFP_REG_SHR(x, n) (((n) > 0) ? (x) >> (n) : (x) << -(n))
> -#define VFP_DREG(reg, insn, bigbit, smallbit) do { \
> - if (dc_isar_feature(aa32_simd_r32, s)) { \
> - reg = (((insn) >> (bigbit)) & 0x0f) \
> - | (((insn) >> ((smallbit) - 4)) & 0x10); \
> - } else { \
> - if (insn & (1 << (smallbit))) \
> - return 1; \
> - reg = ((insn) >> (bigbit)) & 0x0f; \
> - }} while (0)
> -
> -#define VFP_DREG_D(reg, insn) VFP_DREG(reg, insn, 12, 22)
> -#define VFP_DREG_N(reg, insn) VFP_DREG(reg, insn, 16, 7)
> -#define VFP_DREG_M(reg, insn) VFP_DREG(reg, insn, 0, 5)
> -
> static inline bool use_goto_tb(DisasContext *s, target_ulong dest)
> {
> #ifndef CONFIG_USER_ONLY
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm: Delete unused VFP_DREG macros
Date: Mon, 03 Aug 2020 14:27:57 +0100 [thread overview]
Message-ID: <873653oo4i.fsf@linaro.org> (raw)
In-Reply-To: <20200803124848.18295-1-peter.maydell@linaro.org>
Peter Maydell <peter.maydell@linaro.org> writes:
> As part of the Neon decodetree conversion we removed all
> the uses of the VFP_DREG macros, but forgot to remove the
> macro definitions. Do so now.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/translate.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index c39a929b938..27bf6cd8b51 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -2471,21 +2471,6 @@ static int disas_dsp_insn(DisasContext *s, uint32_t insn)
> return 1;
> }
>
> -#define VFP_REG_SHR(x, n) (((n) > 0) ? (x) >> (n) : (x) << -(n))
> -#define VFP_DREG(reg, insn, bigbit, smallbit) do { \
> - if (dc_isar_feature(aa32_simd_r32, s)) { \
> - reg = (((insn) >> (bigbit)) & 0x0f) \
> - | (((insn) >> ((smallbit) - 4)) & 0x10); \
> - } else { \
> - if (insn & (1 << (smallbit))) \
> - return 1; \
> - reg = ((insn) >> (bigbit)) & 0x0f; \
> - }} while (0)
> -
> -#define VFP_DREG_D(reg, insn) VFP_DREG(reg, insn, 12, 22)
> -#define VFP_DREG_N(reg, insn) VFP_DREG(reg, insn, 16, 7)
> -#define VFP_DREG_M(reg, insn) VFP_DREG(reg, insn, 0, 5)
> -
> static inline bool use_goto_tb(DisasContext *s, target_ulong dest)
> {
> #ifndef CONFIG_USER_ONLY
--
Alex Bennée
next prev parent reply other threads:[~2020-08-03 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 12:48 [PATCH] target/arm: Delete unused VFP_DREG macros Peter Maydell
2020-08-03 13:10 ` Philippe Mathieu-Daudé
2020-08-03 13:27 ` Alex Bennée [this message]
2020-08-03 13:27 ` Alex Bennée
-- strict thread matches above, loose matches on Subject: below --
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
2020-10-12 15:33 ` [PATCH] target/arm: Delete unused VFP_DREG macros Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873653oo4i.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.