All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Hilber <peter.hilber@opensynergy.com>
Cc: virtio-comment@lists.oasis-open.org,
	linux-arm-kernel@lists.infradead.org, Souvik.Chakravarty@arm.com,
	Sudeep.Holla@arm.com, virtio-dev@lists.oasis-open.org
Subject: [virtio-comment] Re: [virtio-dev] [PATCH v3] Add virtio SCMI device specification
Date: Fri, 27 Mar 2020 17:19:47 +0000	[thread overview]
Message-ID: <87369tn2a4.fsf@linaro.org> (raw)
In-Reply-To: <20200317192053.15665-1-peter.hilber@opensynergy.com>


Peter Hilber <peter.hilber@opensynergy.com> writes:

> This patch proposes a new virtio device for the Arm SCMI protocol.
>
> The device provides a simple transport for the Arm SCMI protocol[1]. The
> *S*ystem *C*ontrol and *M*anagement *I*nterface protocol allows speaking
> to system controllers that allow orchestrating things like power
> management, system state management and sensor access. The SCMI protocol
> is used on SoCs where multiple cores and co-processors need access to
> these resources.
>
> The virtio transport allows making use of this protocol in virtualized
> systems.
>
> [1] https://developer.arm.com/docs/den0056/b
>
> Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
<snip>
> +
> +\subsubsection{Shared Memory Operation}
> +
> +Various SCMI protocols define statistics shared memory regions (for
> +statistics and sensor values).
> +
> +\devicenormative{\paragraph}{Shared Memory Operation}{Device Types / SCMI Device / Device Operation / Shared Memory Operation}
> +
> +If VIRTIO_SCMI_F_SHARED_MEMORY was negotiated, the device MAY implement
> +an SCMI statistics shared memory region using a virtio shared memory
> +region.

AFAICT this is the first usage of shmid in the virtio spec so I have
some questions. The spec says:

  Memory consistency rules vary depending on the region and the device
  and they will be specified as required by each device.

So what are the rules for memory consistency for these regions:

  - are they read-only w.r.t the guest? (maybe this is implicit?)
  - how does the guest know when they have been updated?
  - how goes the guest know it hasn't read a value mid-update?

> +
> +If the device implements a shared memory region, the device MUST assign
> +the corresponding shmid as per the following table:
> +
> +\begin{tabular}{|l|l|}
> +\hline
> +SCMI statistics shared memory region & Virtio shmid \\
> +\hline \hline
> +Power state statistics shared memory region & 1 \\
> +\hline
> +Performance domain statistics shared memory region & 2 \\
> +\hline
> +Sensor Values Shared Memory & 3 \\
> +\hline
> +Reserved for future use & 4 to 0x7F \\
> +\hline
> +Vendor-specific statistics shared memory regions & 0x80 to 0xFF \\
> +\hline
> +Reserved for future use & 0x100 and greater \\
> +\hline
> +\end{tabular}


-- 
Alex Bennée

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Hilber <peter.hilber@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, Sudeep.Holla@arm.com,
	Souvik.Chakravarty@arm.com, linux-arm-kernel@lists.infradead.org,
	virtio-comment@lists.oasis-open.org
Subject: Re: [virtio-dev] [PATCH v3] Add virtio SCMI device specification
Date: Fri, 27 Mar 2020 17:19:47 +0000	[thread overview]
Message-ID: <87369tn2a4.fsf@linaro.org> (raw)
In-Reply-To: <20200317192053.15665-1-peter.hilber@opensynergy.com>


Peter Hilber <peter.hilber@opensynergy.com> writes:

> This patch proposes a new virtio device for the Arm SCMI protocol.
>
> The device provides a simple transport for the Arm SCMI protocol[1]. The
> *S*ystem *C*ontrol and *M*anagement *I*nterface protocol allows speaking
> to system controllers that allow orchestrating things like power
> management, system state management and sensor access. The SCMI protocol
> is used on SoCs where multiple cores and co-processors need access to
> these resources.
>
> The virtio transport allows making use of this protocol in virtualized
> systems.
>
> [1] https://developer.arm.com/docs/den0056/b
>
> Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
<snip>
> +
> +\subsubsection{Shared Memory Operation}
> +
> +Various SCMI protocols define statistics shared memory regions (for
> +statistics and sensor values).
> +
> +\devicenormative{\paragraph}{Shared Memory Operation}{Device Types / SCMI Device / Device Operation / Shared Memory Operation}
> +
> +If VIRTIO_SCMI_F_SHARED_MEMORY was negotiated, the device MAY implement
> +an SCMI statistics shared memory region using a virtio shared memory
> +region.

AFAICT this is the first usage of shmid in the virtio spec so I have
some questions. The spec says:

  Memory consistency rules vary depending on the region and the device
  and they will be specified as required by each device.

So what are the rules for memory consistency for these regions:

  - are they read-only w.r.t the guest? (maybe this is implicit?)
  - how does the guest know when they have been updated?
  - how goes the guest know it hasn't read a value mid-update?

> +
> +If the device implements a shared memory region, the device MUST assign
> +the corresponding shmid as per the following table:
> +
> +\begin{tabular}{|l|l|}
> +\hline
> +SCMI statistics shared memory region & Virtio shmid \\
> +\hline \hline
> +Power state statistics shared memory region & 1 \\
> +\hline
> +Performance domain statistics shared memory region & 2 \\
> +\hline
> +Sensor Values Shared Memory & 3 \\
> +\hline
> +Reserved for future use & 4 to 0x7F \\
> +\hline
> +Vendor-specific statistics shared memory regions & 0x80 to 0xFF \\
> +\hline
> +Reserved for future use & 0x100 and greater \\
> +\hline
> +\end{tabular}


-- 
Alex Bennée

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-03-27 17:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 19:37 [virtio-comment] [PATCH] Add virtio SCMI device specification Peter Hilber
2020-02-20 19:37 ` Peter Hilber
2020-02-21 10:53 ` [virtio-comment] " Peter Hilber
2020-02-21 10:53   ` Peter Hilber
2020-02-21 11:22 ` Souvik Chakravarty
2020-02-21 12:47   ` [virtio-comment] Fwd: " Peter Hilber
2020-02-21 19:45   ` [virtio-comment] " Peter Hilber
2020-02-21 19:45     ` Peter Hilber
2020-02-27 11:37 ` [virtio-comment] [PATCH v2] " Peter Hilber
2020-02-27 11:37   ` Peter Hilber
2020-03-17 19:20   ` [virtio-comment] [PATCH v3] " Peter Hilber
2020-03-17 19:20     ` Peter Hilber
2020-03-23 17:35     ` [virtio-dev] " Alex Bennée
2020-03-23 17:35       ` Alex Bennée
2020-03-27 14:43       ` [virtio-comment] " Alex Bennée
2020-03-27 14:43         ` Alex Bennée
2020-03-27 17:19     ` Alex Bennée [this message]
2020-03-27 17:19       ` Alex Bennée
2020-04-09  8:01       ` [virtio-comment] " Peter Hilber
2020-04-09  8:01         ` Peter Hilber
2020-04-24  8:51     ` [virtio-comment] [PATCH v4] " Peter Hilber
2020-04-24  8:51       ` Peter Hilber
2020-05-13 10:48       ` [virtio-comment] " Peter Hilber
2020-05-13 10:48         ` Peter Hilber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87369tn2a4.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Souvik.Chakravarty@arm.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=peter.hilber@opensynergy.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.