From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
"qemu-trivial\@nongnu.org" <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"qemu-devel\@nongnu.org" <qemu-devel@nongnu.org>,
Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Subject: Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')
Date: Tue, 08 Oct 2019 20:19:13 +0200 [thread overview]
Message-ID: <8736g3drry.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20191008124113.GE1192@redhat.com> ("Daniel P. Berrangé"'s message of "Tue, 8 Oct 2019 13:41:13 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> Given that we're aiming to convert to meson, how much effort do we really
> want to put into fixing this inconsistency ?
>
> I'd argue the best way to fix "clean" and "distclean" is to delete them
> entirely. Instead enforce that builddir != srcdir when running configure,
> so cleaning up simply means deleting the builddir sub-tree entirely.
I don't wish to belittle anybody's efforts at improving make targets
clean and distclean, but like Daniel, I've long given up on them[*]. My
"make distclean" is "rm -rf BUILD-DIR", and my "make clean" is "nuke-bld
BUILD-DIR", where nuke-bld is the script below.
#!/bin/sh -e
if [ $# -gt 1 ]
then
echo "Usage: $0 [bld-dir]" >&2
exit 1
fi
[ $# -eq 1 ] && cd "$1"
if [ ! -e config.status ]
then
echo "$0: not a build tree" >&2
exit 1
fi
rm -f .config.status
mv config.status .config.status
rm -r *
mv .config.status config.status
./config.status
[*] Along with .gitignore.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Subject: Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')
Date: Tue, 08 Oct 2019 20:19:13 +0200 [thread overview]
Message-ID: <8736g3drry.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20191008124113.GE1192@redhat.com> ("Daniel P. Berrangé"'s message of "Tue, 8 Oct 2019 13:41:13 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> Given that we're aiming to convert to meson, how much effort do we really
> want to put into fixing this inconsistency ?
>
> I'd argue the best way to fix "clean" and "distclean" is to delete them
> entirely. Instead enforce that builddir != srcdir when running configure,
> so cleaning up simply means deleting the builddir sub-tree entirely.
I don't wish to belittle anybody's efforts at improving make targets
clean and distclean, but like Daniel, I've long given up on them[*]. My
"make distclean" is "rm -rf BUILD-DIR", and my "make clean" is "nuke-bld
BUILD-DIR", where nuke-bld is the script below.
#!/bin/sh -e
if [ $# -gt 1 ]
then
echo "Usage: $0 [bld-dir]" >&2
exit 1
fi
[ $# -eq 1 ] && cd "$1"
if [ ! -e config.status ]
then
echo "$0: not a build tree" >&2
exit 1
fi
rm -f .config.status
mv config.status .config.status
rm -r *
mv .config.status config.status
./config.status
[*] Along with .gitignore.
next prev parent reply other threads:[~2019-10-08 18:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:28 [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean') Thomas Huth
2019-10-08 8:28 ` Thomas Huth
2019-10-08 12:18 ` Aleksandar Markovic
2019-10-08 12:18 ` Aleksandar Markovic
2019-10-08 12:35 ` Thomas Huth
2019-10-08 12:35 ` Thomas Huth
2019-10-08 12:41 ` Peter Maydell
2019-10-08 12:41 ` Peter Maydell
2019-10-08 16:04 ` Paolo Bonzini
2019-10-08 16:04 ` Paolo Bonzini
2020-06-13 16:28 ` Aleksandar Markovic
2020-06-13 16:28 ` Aleksandar Markovic
2020-06-15 5:17 ` Thomas Huth
2020-06-15 7:13 ` Paolo Bonzini
2020-06-15 7:13 ` Paolo Bonzini
2020-06-15 7:46 ` Thomas Huth
2020-06-15 19:46 ` Markus Armbruster
2020-06-15 19:46 ` Markus Armbruster
2019-10-08 12:41 ` Daniel P. Berrangé
2019-10-08 12:41 ` Daniel P. Berrangé
2019-10-08 13:34 ` Thomas Huth
2019-10-08 13:34 ` Thomas Huth
2019-10-08 18:19 ` Markus Armbruster [this message]
2019-10-08 18:19 ` Markus Armbruster
2019-10-22 20:35 ` Aleksandar Markovic
2019-10-22 20:35 ` Aleksandar Markovic
2019-10-23 7:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736g3drry.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.