Subject: [net-next v2] net: sched: Introduce act_ctinfo action
Date: Sun, 05 May 2019 12:43:20 +0200 [thread overview]
Message-ID: <8736lt9o6v.fsf@toke.dk> (raw)
In-Reply-To: <B6426224-12CC-417B-9A38-6DDBE574A85C@darbyshire-bryant.me.uk>
Kevin 'ldir' Darbyshire-Bryant <ldir at darbyshire-bryant.me.uk> writes:
>> On 5 May 2019, at 11:23, Greg KH <greg at kroah.com> wrote:
>>
>> On Sun, May 05, 2019 at 10:15:43AM +0000, Kevin 'ldir' Darbyshire-Bryant wrote:
>>> --- /dev/null
>>> +++ b/net/sched/act_ctinfo.c
>>> @@ -0,0 +1,407 @@
>>> +// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
>>
>
> Hey Greg, thanks for the review.
>
>> How can a .c file, buried in the kernel tree, have a Linux-syscall-note
>> exception to it?
>
> Because I’m a moron and nobody else spotted it.
>>
>> Are you _sure_ that is ok? That license should only be for files in the
>> uapi header directory.
>
> Expect a v3 shortly. I shall wear your chastisement with honour :-)
While you're at it, you don't actually need the GPL text blob when using
the SPDX headers... :)
-Toke
WARNING: multiple messages have this Message-ID (diff)
From: toke@redhat.com (Toke Høiland-Jørgensen)
Subject: [net-next v2] net: sched: Introduce act_ctinfo action
Date: Sun, 05 May 2019 12:43:20 +0200 [thread overview]
Message-ID: <8736lt9o6v.fsf@toke.dk> (raw)
Message-ID: <20190505104320.3W8qUtW6njWeRaUVBbiPlhYGFZ2hpNwWcay4mKCWlkM@z> (raw)
In-Reply-To: <B6426224-12CC-417B-9A38-6DDBE574A85C@darbyshire-bryant.me.uk>
Kevin 'ldir' Darbyshire-Bryant <ldir at darbyshire-bryant.me.uk> writes:
>> On 5 May 2019,@11:23, Greg KH <greg@kroah.com> wrote:
>>
>> On Sun, May 05, 2019@10:15:43AM +0000, Kevin 'ldir' Darbyshire-Bryant wrote:
>>> --- /dev/null
>>> +++ b/net/sched/act_ctinfo.c
>>> @@ -0,0 +1,407 @@
>>> +// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
>>
>
> Hey Greg, thanks for the review.
>
>> How can a .c file, buried in the kernel tree, have a Linux-syscall-note
>> exception to it?
>
> Because I’m a moron and nobody else spotted it.
>>
>> Are you _sure_ that is ok? That license should only be for files in the
>> uapi header directory.
>
> Expect a v3 shortly. I shall wear your chastisement with honour :-)
While you're at it, you don't actually need the GPL text blob when using
the SPDX headers... :)
-Toke
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>,
Greg KH <greg@kroah.com>
Cc: "xiyou.wangcong\@gmail.com" <xiyou.wangcong@gmail.com>,
"davem\@davemloft.net" <davem@davemloft.net>,
"jhs\@mojatatu.com" <jhs@mojatatu.com>,
"jiri\@resnulli.us" <jiri@resnulli.us>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest\@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"shuah\@kernel.org" <shuah@kernel.org>
Subject: Re: [net-next v2] net: sched: Introduce act_ctinfo action
Date: Sun, 05 May 2019 12:43:20 +0200 [thread overview]
Message-ID: <8736lt9o6v.fsf@toke.dk> (raw)
In-Reply-To: <B6426224-12CC-417B-9A38-6DDBE574A85C@darbyshire-bryant.me.uk>
Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> writes:
>> On 5 May 2019, at 11:23, Greg KH <greg@kroah.com> wrote:
>>
>> On Sun, May 05, 2019 at 10:15:43AM +0000, Kevin 'ldir' Darbyshire-Bryant wrote:
>>> --- /dev/null
>>> +++ b/net/sched/act_ctinfo.c
>>> @@ -0,0 +1,407 @@
>>> +// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
>>
>
> Hey Greg, thanks for the review.
>
>> How can a .c file, buried in the kernel tree, have a Linux-syscall-note
>> exception to it?
>
> Because I’m a moron and nobody else spotted it.
>>
>> Are you _sure_ that is ok? That license should only be for files in the
>> uapi header directory.
>
> Expect a v3 shortly. I shall wear your chastisement with honour :-)
While you're at it, you don't actually need the GPL text blob when using
the SPDX headers... :)
-Toke
next prev parent reply other threads:[~2019-05-05 10:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 13:08 [PATCH net-next] net: sched: Introduce act_ctinfo action ldir
2019-04-27 13:08 ` Kevin 'ldir' Darbyshire-Bryant
2019-04-27 13:08 ` Kevin 'ldir' Darbyshire-Bryant
2019-04-30 21:47 ` xiyou.wangcong
2019-04-30 21:47 ` Cong Wang
2019-04-30 21:47 ` Cong Wang
2019-05-03 21:20 ` ldir
2019-05-03 21:20 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-03 21:20 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:15 ` [net-next v2] " ldir
2019-05-05 10:15 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:15 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:23 ` greg
2019-05-05 10:23 ` Greg KH
2019-05-05 10:23 ` Greg KH
2019-05-05 10:32 ` ldir
2019-05-05 10:32 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:32 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:43 ` [this message]
2019-05-05 10:43 ` Toke Høiland-Jørgensen
2019-05-05 10:43 ` Toke Høiland-Jørgensen
2019-05-05 13:20 ` [net-next v3] " ldir
2019-05-05 13:20 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 13:20 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-07 19:39 ` davem
2019-05-07 19:39 ` David Miller
2019-05-07 19:39 ` David Miller
2019-05-07 20:12 ` [PATCH net-next v4] " ldir
2019-05-07 20:12 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-07 20:12 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-08 0:20 ` davem
2019-05-08 0:20 ` David Miller
2019-05-08 0:20 ` David Miller
2019-05-08 16:12 ` ldir
2019-05-08 16:12 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-08 16:12 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-07 20:18 ` [net-next v3] " ldir
2019-05-07 20:18 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-07 20:18 ` Kevin 'ldir' Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736lt9o6v.fsf@toke.dk \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.