All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	"andrew\@lunn.ch" <andrew@lunn.ch>,
	"jason\@lakedaemon.net" <jason@lakedaemon.net>
Cc: Russell King <linux@armlinux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
Date: Sun, 21 Apr 2019 19:24:57 +0200	[thread overview]
Message-ID: <8736mb8e52.fsf@FE-laptop> (raw)
In-Reply-To: <ed2e24ed25504979aef666b6f677f34e@svr-chch-ex1.atlnz.lc>

Hi Chris,

> On 20/02/19 4:14 AM, Gregory CLEMENT wrote:
>> Hi Chris,
>>   
>>   On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>> 
>>> Kirkwood has always had the ability to retrieve the local-mac-address
>>> from the hardware (usually this was configured by the bootloader). This
>>> is particularly useful when dealing with a legacy non-DT aware
>>> bootloader.
>>>
>>> The "error" message just indicated that the board used an old bootloader
>>> and in many cases users can't do anything about this. The message
>>> probably should have been pr_info() to inform the user that the kernel
>>> has been helpful but rather than than let's remove it entirely to make
>>> the kernel less noisy.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> 
>> I'm OK with this patch, however as it is not a fix, it's too late for
>> 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
>> 
>
> No problem with that. We have a local fork I'll cherry pick it into once 
> it hits linux-mvebu.
>

Applied on mvebu/arm

Thanks,

Gregory


>> Thanks,
>> 
>> gregory
>> 
>>> ---
>>>   arch/arm/mach-mvebu/kirkwood.c | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
>>> index 0aa88105d46e..bf3ff0f580c2 100644
>>> --- a/arch/arm/mach-mvebu/kirkwood.c
>>> +++ b/arch/arm/mach-mvebu/kirkwood.c
>>> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
>>>   		clk_prepare_enable(clk);
>>>   
>>>   		/* store MAC address register contents in local-mac-address */
>>> -		pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
>>> -
>>>   		pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
>>>   		if (!pmac)
>>>   			goto eth_fixup_no_mem;
>>> -- 
>>> 2.20.1
>>>
>> 
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	"andrew\@lunn.ch" <andrew@lunn.ch>,
	"jason\@lakedaemon.net" <jason@lakedaemon.net>
Cc: "linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address
Date: Sun, 21 Apr 2019 19:24:57 +0200	[thread overview]
Message-ID: <8736mb8e52.fsf@FE-laptop> (raw)
In-Reply-To: <ed2e24ed25504979aef666b6f677f34e@svr-chch-ex1.atlnz.lc>

Hi Chris,

> On 20/02/19 4:14 AM, Gregory CLEMENT wrote:
>> Hi Chris,
>>   
>>   On lun., févr. 18 2019, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>> 
>>> Kirkwood has always had the ability to retrieve the local-mac-address
>>> from the hardware (usually this was configured by the bootloader). This
>>> is particularly useful when dealing with a legacy non-DT aware
>>> bootloader.
>>>
>>> The "error" message just indicated that the board used an old bootloader
>>> and in many cases users can't do anything about this. The message
>>> probably should have been pr_info() to inform the user that the kernel
>>> has been helpful but rather than than let's remove it entirely to make
>>> the kernel less noisy.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> 
>> I'm OK with this patch, however as it is not a fix, it's too late for
>> 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released.
>> 
>
> No problem with that. We have a local fork I'll cherry pick it into once 
> it hits linux-mvebu.
>

Applied on mvebu/arm

Thanks,

Gregory


>> Thanks,
>> 
>> gregory
>> 
>>> ---
>>>   arch/arm/mach-mvebu/kirkwood.c | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
>>> index 0aa88105d46e..bf3ff0f580c2 100644
>>> --- a/arch/arm/mach-mvebu/kirkwood.c
>>> +++ b/arch/arm/mach-mvebu/kirkwood.c
>>> @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void)
>>>   		clk_prepare_enable(clk);
>>>   
>>>   		/* store MAC address register contents in local-mac-address */
>>> -		pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np);
>>> -
>>>   		pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL);
>>>   		if (!pmac)
>>>   			goto eth_fixup_no_mem;
>>> -- 
>>> 2.20.1
>>>
>> 
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2019-04-21 17:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  2:46 [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address Chris Packham
2019-02-18  2:46 ` Chris Packham
2019-02-19 15:03 ` Gregory CLEMENT
2019-02-19 15:03   ` Gregory CLEMENT
2019-02-19 20:00   ` Chris Packham
2019-02-19 20:00     ` Chris Packham
2019-04-21 17:24     ` Gregory CLEMENT [this message]
2019-04-21 17:24       ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736mb8e52.fsf@FE-laptop \
    --to=gregory.clement@bootlin.com \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=andrew@lunn.ch \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.