From: Juan Quintela <quintela@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
Date: Wed, 10 Apr 2019 11:06:35 +0200 [thread overview]
Message-ID: <8736mqz0tg.fsf@trasno.org> (raw)
In-Reply-To: <b991a4d0e6c4253bc08b2794c6084be55fc72e1d.1554851834.git.crobinso@redhat.com> (Cole Robinson's message of "Tue, 9 Apr 2019 19:19:57 -0400")
Cole Robinson <crobinso@redhat.com> wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
Date: Wed, 10 Apr 2019 11:06:35 +0200 [thread overview]
Message-ID: <8736mqz0tg.fsf@trasno.org> (raw)
Message-ID: <20190410090635.LjqT7GxNtMcxkquAqDEBkKEoYJAFLA5hjeKovSJB_DA@z> (raw)
In-Reply-To: <b991a4d0e6c4253bc08b2794c6084be55fc72e1d.1554851834.git.crobinso@redhat.com> (Cole Robinson's message of "Tue, 9 Apr 2019 19:19:57 -0400")
Cole Robinson <crobinso@redhat.com> wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2019-04-10 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 23:19 [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers Cole Robinson
2019-04-09 23:19 ` Cole Robinson
2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 9:06 ` Juan Quintela [this message]
2019-04-10 9:06 ` Juan Quintela
2019-05-14 14:01 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736mqz0tg.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=crobinso@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.