From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/7] qdev: remove DeviceClass::init/exit()
Date: Wed, 31 Jan 2018 14:42:03 +0100 [thread overview]
Message-ID: <87372m5ems.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180122120351.22369-1-f4bug@amsat.org> ("Philippe Mathieu-Daudé"'s message of "Mon, 22 Jan 2018 09:03:44 -0300")
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> since v1:
> - fix format string on 32-bit host (patchew)
> - do not add smbus_eeprom_reset() (Eduardo)
> - directly use DeviceClass::realize (Eduardo)
> - squashed 2 patches (Eduardo)
>
> Hi,
>
> This series finalize the qdev QOMification.
Awesome!
It's been almost nine years since qdev, and more than 7 since QOM.
Sadly, I don't have the time to review this closely right now.
> We first convert the I2CSlave/SMBusDevice,
> then the usb-ccid and virtio-ccw,
> and finally the SysBusDevice.
>
> At the end we get one less TODO :)
>
> /* TODO remove, once users are converted to unrealize */
>
> There is still one standing in SysBusDeviceClass::init().
Another one in ssi_sd_realize(), I think. I didn't really look for
more.
prev parent reply other threads:[~2018-01-31 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 12:03 [Qemu-devel] [PATCH v2 0/7] qdev: remove DeviceClass::init/exit() Philippe Mathieu-Daudé
2018-01-22 12:03 ` [Qemu-devel] [PATCH v2 1/7] hw/i2c/smbus: use DeviceClass::realize instead of SMBusDeviceClass::init Philippe Mathieu-Daudé
2018-01-22 12:03 ` [Qemu-devel] [PATCH v2 2/7] hw/i2c: use DeviceClass::realize instead of I2CSlaveClass::init Philippe Mathieu-Daudé
2018-01-22 12:03 ` [Qemu-devel] [PATCH v2 3/7] usb-ccid: convert CCIDCardClass::init -> realize Philippe Mathieu-Daudé
2018-01-25 15:25 ` Gerd Hoffmann
2018-01-31 13:43 ` Markus Armbruster
2018-01-22 12:03 ` [Qemu-devel] [PATCH v2 4/7] virtio-ccw: convert VirtIOCCWDeviceClass::exit -> unrealize Philippe Mathieu-Daudé
2018-01-22 12:03 ` [Qemu-devel] [PATCH v2 5/7] qdev: simplify the SysBusDeviceClass::init path Philippe Mathieu-Daudé
2018-01-22 12:03 ` [Qemu-devel] [PATCH v2 6/7] qdev: remove DeviceClass::exit Philippe Mathieu-Daudé
2018-01-22 12:03 ` [Qemu-devel] [PATCH v2 7/7] qdev: rename typedef qdev_resetfn() -> DeviceReset() Philippe Mathieu-Daudé
2018-01-31 13:42 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87372m5ems.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.