From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Kalyan Kinthada
<kalyan.kinthada-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Chris Packham
<chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
Subject: Re: [PATCH] dt-bindings: i2c: Add armada-38x i2c binding
Date: Fri, 22 Sep 2017 09:30:51 +0200 [thread overview]
Message-ID: <87377fmbpw.fsf@free-electrons.com> (raw)
In-Reply-To: <20170922020429.20941-1-kalyan.kinthada-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> (Kalyan Kinthada's message of "Fri, 22 Sep 2017 14:04:29 +1200")
Hi Kalyan,
On ven., sept. 22 2017, Kalyan Kinthada <kalyan.kinthada-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> wrote:
> All armada-38x variants(380, 385, 388) SoCs have an issue
> in i2c controller which violates the i2c repeated start timing.
Did you had an issue with one of the SoC ?
If yes what was your setting ?
On my side I never managed to have this sort of issue on Armada 38x.
>
> This errata is fixed in the i2c-mv64xxx driver but enabled
> only for devices with compatible string "marvell,mv78230-i2c".
In this case why not just adding the "marvell,mv78230-i2c" as compatible
string in the appropriate device tree files ?
Gregory
>
> This patch introduces a new compatible string
> "marvell,armada-38x-i2c" for the i2c controller on armada-38x SoCs
> so that the workaound is enabled.
>
> Signed-off-by: Kalyan Kinthada <kalyan.kinthada-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> index 5c30026921..fc100b6bdb 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> @@ -14,6 +14,7 @@ Required properties :
> very rare, initial version of the SoC which
> had broken offload support. Linux
> auto-detects this and sets it appropriately.
> + - "marvell,armada-38x-i2c"
> - interrupts : The interrupt number
>
> Optional properties :
> --
> 2.14.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
Cc: devicetree@vger.kernel.org, wsa@the-dreams.de,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: [PATCH] dt-bindings: i2c: Add armada-38x i2c binding
Date: Fri, 22 Sep 2017 09:30:51 +0200 [thread overview]
Message-ID: <87377fmbpw.fsf@free-electrons.com> (raw)
In-Reply-To: <20170922020429.20941-1-kalyan.kinthada@alliedtelesis.co.nz> (Kalyan Kinthada's message of "Fri, 22 Sep 2017 14:04:29 +1200")
Hi Kalyan,
On ven., sept. 22 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> All armada-38x variants(380, 385, 388) SoCs have an issue
> in i2c controller which violates the i2c repeated start timing.
Did you had an issue with one of the SoC ?
If yes what was your setting ?
On my side I never managed to have this sort of issue on Armada 38x.
>
> This errata is fixed in the i2c-mv64xxx driver but enabled
> only for devices with compatible string "marvell,mv78230-i2c".
In this case why not just adding the "marvell,mv78230-i2c" as compatible
string in the appropriate device tree files ?
Gregory
>
> This patch introduces a new compatible string
> "marvell,armada-38x-i2c" for the i2c controller on armada-38x SoCs
> so that the workaound is enabled.
>
> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> index 5c30026921..fc100b6bdb 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> @@ -14,6 +14,7 @@ Required properties :
> very rare, initial version of the SoC which
> had broken offload support. Linux
> auto-detects this and sets it appropriately.
> + - "marvell,armada-38x-i2c"
> - interrupts : The interrupt number
>
> Optional properties :
> --
> 2.14.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-09-22 7:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 2:04 [PATCH] dt-bindings: i2c: Add armada-38x i2c binding Kalyan Kinthada
[not found] ` <20170922020429.20941-1-kalyan.kinthada-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-09-22 7:30 ` Gregory CLEMENT [this message]
2017-09-22 7:30 ` Gregory CLEMENT
2017-09-24 21:44 ` Kalyan Kinthada
[not found] ` <1506289460890.34765-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-09-26 11:55 ` Gregory CLEMENT
2017-09-26 11:55 ` Gregory CLEMENT
2017-09-26 23:10 ` Kalyan Kinthada
2017-09-27 1:15 ` Chris Packham
2017-09-27 7:33 ` Gregory CLEMENT
2017-09-27 7:33 ` Gregory CLEMENT
[not found] ` <87efqsiok3.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-10-03 21:49 ` Rob Herring
2017-10-03 21:49 ` Rob Herring
2017-10-04 8:33 ` Gregory CLEMENT
2017-10-04 8:33 ` Gregory CLEMENT
2017-10-04 12:46 ` Rob Herring
2017-10-04 12:52 ` Gregory CLEMENT
2017-10-04 12:52 ` Gregory CLEMENT
2017-10-04 13:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87377fmbpw.fsf@free-electrons.com \
--to=gregory.clement-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kalyan.kinthada-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.