From: NeilBrown <neilb@suse.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH] staging: lustre: fix minor typos in comments
Date: Wed, 02 Aug 2017 13:26:11 +1000 [thread overview]
Message-ID: <87379aveek.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20170719082955.GA30088@kroah.com>
Fix minor typos in comments.
Signed-off-by: NeilBrown <neilb@suse.com>
---
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
index 8ed24ec1255d..7a1133661a65 100644
--- a/drivers/staging/lustre/lustre/llite/namei.c
+++ b/drivers/staging/lustre/lustre/llite/namei.c
@@ -488,7 +488,7 @@ static int ll_lookup_it_finish(struct ptlrpc_request *request,
*de = alias;
if (!it_disposition(it, DISP_LOOKUP_NEG)) {
- /* we have lookup look - unhide dentry */
+ /* We have the "lookup" lock, so unhide dentry */
if (bits & MDS_INODELOCK_LOOKUP)
d_lustre_revalidate(*de);
} else if (!it_disposition(it, DISP_OPEN_CREATE)) {
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
index 3eb66cea65db..ae97c6f1aeb0 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
@@ -1030,7 +1030,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
* If we're performing a creation, that means that unless the creation
* failed with EEXIST, we should fake up a negative dentry.
*
- * For everything else, we want to lookup to succeed.
+ * For everything else, we want the lookup to succeed.
*
* One additional note: if CREATE or OPEN succeeded, we add an extra
* reference to the request because we need to keep it around until
@@ -1040,7 +1040,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
* exactly what it_status refers to.
*
* If DISP_OPEN_OPEN is set, then it_status refers to the open() call,
- * otherwise if DISP_OPEN_CREATE is set, then it status is the
+ * otherwise if DISP_OPEN_CREATE is set, then it_status is the
* creation failure mode. In either case, one of DISP_LOOKUP_NEG or
* DISP_LOOKUP_POS will be set, indicating whether the child lookup
* was successful.
--
2.12.2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20170802/fc892112/attachment.pgp>
WARNING: multiple messages have this Message-ID (diff)
From: NeilBrown <neilb@suse.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [PATCH] staging: lustre: fix minor typos in comments
Date: Wed, 02 Aug 2017 13:26:11 +1000 [thread overview]
Message-ID: <87379aveek.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20170719082955.GA30088@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]
Fix minor typos in comments.
Signed-off-by: NeilBrown <neilb@suse.com>
---
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
index 8ed24ec1255d..7a1133661a65 100644
--- a/drivers/staging/lustre/lustre/llite/namei.c
+++ b/drivers/staging/lustre/lustre/llite/namei.c
@@ -488,7 +488,7 @@ static int ll_lookup_it_finish(struct ptlrpc_request *request,
*de = alias;
if (!it_disposition(it, DISP_LOOKUP_NEG)) {
- /* we have lookup look - unhide dentry */
+ /* We have the "lookup" lock, so unhide dentry */
if (bits & MDS_INODELOCK_LOOKUP)
d_lustre_revalidate(*de);
} else if (!it_disposition(it, DISP_OPEN_CREATE)) {
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
index 3eb66cea65db..ae97c6f1aeb0 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
@@ -1030,7 +1030,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
* If we're performing a creation, that means that unless the creation
* failed with EEXIST, we should fake up a negative dentry.
*
- * For everything else, we want to lookup to succeed.
+ * For everything else, we want the lookup to succeed.
*
* One additional note: if CREATE or OPEN succeeded, we add an extra
* reference to the request because we need to keep it around until
@@ -1040,7 +1040,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
* exactly what it_status refers to.
*
* If DISP_OPEN_OPEN is set, then it_status refers to the open() call,
- * otherwise if DISP_OPEN_CREATE is set, then it status is the
+ * otherwise if DISP_OPEN_CREATE is set, then it_status is the
* creation failure mode. In either case, one of DISP_LOOKUP_NEG or
* DISP_LOOKUP_POS will be set, indicating whether the child lookup
* was successful.
--
2.12.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-08-02 3:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 23:26 [lustre-devel] [PATCH 00/12] Assorted lustre fixes and improvements NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 10/12] staging: lustre: ldlm: tidy list walking in ldlm_flock() NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-19 1:54 ` [lustre-devel] " Patrick Farrell
2017-07-19 4:36 ` NeilBrown
2017-07-19 4:36 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 12/12] staging: lustre: ldlm: remove unused field 'fwd_generation' NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 02/12] staging: lustre: llite: fix incorrect DCACHE_DISCONNECTED test NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 05/12] staging: lustre: ldlm: remove unused 'work_list' arg from ldlm_process_flock_lock() NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 06/12] staging: lustre: ldlm: remove unneeded 'err' arg to ldlm_process_flock_lock() NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 07/12] staging: lustre: ldlm: remove 'flags' arg from ldlm_process_flock_lock() NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 03/12] staging: lustre: llite: fix various issues with ll_splice_alias NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-19 2:51 ` [lustre-devel] " Oleg Drokin
2017-07-19 2:51 ` Oleg Drokin
2017-07-19 4:33 ` [lustre-devel] " NeilBrown
2017-07-19 4:33 ` NeilBrown
2017-07-19 6:18 ` [lustre-devel] " Oleg Drokin
2017-07-19 6:18 ` Oleg Drokin
2017-07-18 23:26 ` [lustre-devel] [PATCH 04/12] staging: lustre: ldlm: remove 'first_enq' arg from ldlm_process_flock_lock() NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 01/12] staging: lustre: fix minor typos in comments NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-19 8:29 ` [lustre-devel] " Greg KH
2017-07-19 8:29 ` Greg KH
2017-08-02 3:26 ` NeilBrown [this message]
2017-08-02 3:26 ` [PATCH] " NeilBrown
2017-08-03 17:29 ` [lustre-devel] " James Simmons
2017-08-03 17:29 ` James Simmons
2017-07-18 23:26 ` [lustre-devel] [PATCH 11/12] staging: lustre: ldlm: remove unnecessary 'ownlocks' variable NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 09/12] staging: lustre: ldlm: remove 'flags' arg from ldlm_flock_destroy() NeilBrown
2017-07-18 23:26 ` NeilBrown
2017-07-18 23:26 ` [lustre-devel] [PATCH 08/12] staging: lustre: ldlm: remove unused 'overlaps' variable NeilBrown
2017-07-18 23:26 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87379aveek.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.