Re: [dim PATCH] dim: restore cd in update_rerere_cache()

From: Jani Nikula <jani.nikula@intel.com>
To: Archit Taneja <architt@codeaurora.org>, Daniel Vetter <daniel@ffwll.ch>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [dim PATCH] dim: restore cd in update_rerere_cache()
Date: Tue, 18 Jul 2017 11:06:41 +0300	[thread overview]
Message-ID: <87379ub23y.fsf@intel.com> (raw)
In-Reply-To: <fc45665a-964f-b940-2ac5-3ab60fcdd14d@codeaurora.org>

On Tue, 18 Jul 2017, Archit Taneja <architt@codeaurora.org> wrote:
> On 07/18/2017 01:20 PM, Daniel Vetter wrote:
>> On Tue, Jul 18, 2017 at 10:15:25AM +0300, Jani Nikula wrote:
>>> The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
>>> cannot stat 'rr-cache/*': No such file or directory" on dim ub.
>>>
>>> Reported-by: Archit Taneja <architt@codeaurora.org>
>>> Fixes: 599eb3db59c9 ("dim: Move all rerere updating into helpers")
>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> Cc: Sean Paul <seanpaul@chromium.org>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> Thx for spotting this.
>> 
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks, works for me now.
>
> Tested-by: Archit Taneja <architt@codeaurora.org>

Thanks, pushed.

BR,
Jani.

>
>>> ---
>>>   dim | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/dim b/dim
>>> index 1fcd8d73fe1e..6ba2c085be16 100755
>>> --- a/dim
>>> +++ b/dim
>>> @@ -495,6 +495,7 @@ function update_rerere_cache
>>>   {
>>>   	echo -n "Updating rerere cache... "
>>>   
>>> +	cd $DIM_PREFIX/drm-rerere/
>>>   	git pull
>>>   	mkdir $(rr_cache_dir) &> /dev/null || true
>>>   	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
>>> -- 
>>> 2.11.0
>>>
>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx