[dim PATCH] dim: restore cd in update_rerere_cache()

[dim PATCH] dim: restore cd in update_rerere_cache()

[Jani Nikula]

The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
cannot stat 'rr-cache/*': No such file or directory" on dim ub.

Reported-by: Archit Taneja <architt@codeaurora.org>
Fixes: 599eb3db59c9 ("dim: Move all rerere updating into helpers")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 dim | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dim b/dim
index 1fcd8d73fe1e..6ba2c085be16 100755
--- a/dim
+++ b/dim
@@ -495,6 +495,7 @@ function update_rerere_cache
 {
 	echo -n "Updating rerere cache... "
 
+	cd $DIM_PREFIX/drm-rerere/
 	git pull
 	mkdir $(rr_cache_dir) &> /dev/null || true
 	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [dim PATCH] dim: restore cd in update_rerere_cache()

[Daniel Vetter]

On Tue, Jul 18, 2017 at 10:15:25AM +0300, Jani Nikula wrote:
> The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
> cannot stat 'rr-cache/*': No such file or directory" on dim ub.
> 
> Reported-by: Archit Taneja <architt@codeaurora.org>
> Fixes: 599eb3db59c9 ("dim: Move all rerere updating into helpers")
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Thx for spotting this.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  dim | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dim b/dim
> index 1fcd8d73fe1e..6ba2c085be16 100755
> --- a/dim
> +++ b/dim
> @@ -495,6 +495,7 @@ function update_rerere_cache
>  {
>  	echo -n "Updating rerere cache... "
>  
> +	cd $DIM_PREFIX/drm-rerere/
>  	git pull
>  	mkdir $(rr_cache_dir) &> /dev/null || true
>  	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
> -- 
> 2.11.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [dim PATCH] dim: restore cd in update_rerere_cache()

[Archit Taneja]

On 07/18/2017 01:20 PM, Daniel Vetter wrote:
> On Tue, Jul 18, 2017 at 10:15:25AM +0300, Jani Nikula wrote:
>> The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
>> cannot stat 'rr-cache/*': No such file or directory" on dim ub.
>>
>> Reported-by: Archit Taneja <architt@codeaurora.org>
>> Fixes: 599eb3db59c9 ("dim: Move all rerere updating into helpers")
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Sean Paul <seanpaul@chromium.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> 
> Thx for spotting this.
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks, works for me now.

Tested-by: Archit Taneja <architt@codeaurora.org>

>> ---
>>   dim | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/dim b/dim
>> index 1fcd8d73fe1e..6ba2c085be16 100755
>> --- a/dim
>> +++ b/dim
>> @@ -495,6 +495,7 @@ function update_rerere_cache
>>   {
>>   	echo -n "Updating rerere cache... "
>>   
>> +	cd $DIM_PREFIX/drm-rerere/
>>   	git pull
>>   	mkdir $(rr_cache_dir) &> /dev/null || true
>>   	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
>> -- 
>> 2.11.0
>>
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [dim PATCH] dim: restore cd in update_rerere_cache()

[Jani Nikula]

On Tue, 18 Jul 2017, Archit Taneja <architt@codeaurora.org> wrote:
> On 07/18/2017 01:20 PM, Daniel Vetter wrote:
>> On Tue, Jul 18, 2017 at 10:15:25AM +0300, Jani Nikula wrote:
>>> The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
>>> cannot stat 'rr-cache/*': No such file or directory" on dim ub.
>>>
>>> Reported-by: Archit Taneja <architt@codeaurora.org>
>>> Fixes: 599eb3db59c9 ("dim: Move all rerere updating into helpers")
>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> Cc: Sean Paul <seanpaul@chromium.org>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> Thx for spotting this.
>> 
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks, works for me now.
>
> Tested-by: Archit Taneja <architt@codeaurora.org>

Thanks, pushed.

BR,
Jani.


>
>>> ---
>>>   dim | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/dim b/dim
>>> index 1fcd8d73fe1e..6ba2c085be16 100755
>>> --- a/dim
>>> +++ b/dim
>>> @@ -495,6 +495,7 @@ function update_rerere_cache
>>>   {
>>>   	echo -n "Updating rerere cache... "
>>>   
>>> +	cd $DIM_PREFIX/drm-rerere/
>>>   	git pull
>>>   	mkdir $(rr_cache_dir) &> /dev/null || true
>>>   	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
>>> -- 
>>> 2.11.0
>>>
>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx