From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,
alistair.francis@xilinx.com
Subject: Re: [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay
Date: Tue, 16 May 2017 10:43:17 +0200 [thread overview]
Message-ID: <8737c5gpju.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170515214114.15442-4-eblake@redhat.com> (Eric Blake's message of "Mon, 15 May 2017 16:41:12 -0500")
Eric Blake <eblake@redhat.com> writes:
> With the recent addition of ShutdownCause, we want to be able to pass
> a cause through any shutdown request, and then faithfully replay that
> cause when later replaying the same sequence. The easiest way is to
> expand the reply event mechanism to track a series of values for
> EVENT_SHUTDOWN, one corresponding to each value of ShutdownCause.
>
> We are free to change the replay stream as needed, since there are
> already no guarantees about being able to use a replay stream by
> any other version of qemu than the one that generated it.
>
> The cause is not actually fed back until the next patch changes the
> signature for requesting a shutdown; a TODO marks that upcoming change.
>
> Yes, this uses the gcc/clang extension of a ranged case label,
> but this is not the first time we've used non-C99 constructs.
Not even *this* construct, as git-grep shows.
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2017-05-16 8:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 21:41 [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN Eric Blake
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 1/5] shutdown: Simplify shutdown_signal Eric Blake
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request Eric Blake
2017-05-15 21:41 ` Eric Blake
2017-05-16 8:40 ` [Qemu-devel] " Markus Armbruster
2017-05-16 8:40 ` Markus Armbruster
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay Eric Blake
2017-05-16 8:43 ` Markus Armbruster [this message]
2017-05-15 21:41 ` [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET Eric Blake
2017-05-15 21:41 ` Eric Blake
2017-05-15 21:41 ` [Qemu-devel] " Eric Blake
2017-05-15 21:41 ` Eric Blake
2017-05-16 8:46 ` [Qemu-devel] " Markus Armbruster
2017-05-16 8:46 ` Markus Armbruster
2017-05-16 8:46 ` Markus Armbruster
2017-05-16 8:46 ` Markus Armbruster
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events Eric Blake
2017-05-16 8:49 ` Markus Armbruster
2017-05-16 11:43 ` [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737c5gpju.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=eblake@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.