From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
"open list\:Overall" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Alexander Graf <agraf@suse.de>,
Yongbok Kim <yongbok.kim@imgtec.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Rob Herring <robh@kernel.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Anthony Perard <anthony.perard@citrix.com>,
"open list\:X86" <xen-devel@lists.xenproject.org>,
Richard Henderson <rth@twiddle.net>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Weil <sw@weilnetz.de>,
alistair.francis@xilinx.com,
"open list\:Calxeda Highbank" <qemu-arm@nongnu.org>,
Jan Kiszka <jan.kiszka@web.de>,
Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,
Igor Mammedov <imammedo@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
Paul Burton <paul.burton@imgtec.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Michael Walle <michael@walle.cc>,
"open list\:Old World" <qemu-ppc@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET
Date: Tue, 16 May 2017 10:46:57 +0200 [thread overview]
Message-ID: <87y3txfata.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170515214114.15442-5-eblake@redhat.com> (Eric Blake's message of "Mon, 15 May 2017 16:41:13 -0500")
Eric Blake <eblake@redhat.com> writes:
> Time to wire up all the call sites that request a shutdown or
> reset to use the enum added in the previous patch.
>
> It would have been less churn to keep the common case with no
> arguments as meaning guest-triggered, and only modified the
> host-triggered code paths, via a wrapper function, but then we'd
> still have to audit that I didn't miss any host-triggered spots;
> changing the signature forces us to double-check that I correctly
> categorized all callers.
>
> Since command line options can change whether a guest reset request
> causes an actual reset vs. a shutdown, it's easy to also add the
> information to reset requests.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Acked-by: David Gibson <david@gibson.dropbear.id.au> [ppc parts]
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> [SPARC part]
> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com> [s390x parts]
>
> ---
> v8: rebase later in series
That turned out nicely. Thanks!
Reviewed-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
"open list\:Overall" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Alexander Graf <agraf@suse.de>,
Yongbok Kim <yongbok.kim@imgtec.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Rob Herring <robh@kernel.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Anthony Perard <anthony.perard@citrix.com>,
"open list\:X86" <xen-devel@lists.xenproject.org>,
Richard Henderson <rth@twiddle.net>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Weil <sw@weilnetz.de>,
alistai
Subject: Re: [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET
Date: Tue, 16 May 2017 10:46:57 +0200 [thread overview]
Message-ID: <87y3txfata.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170515214114.15442-5-eblake@redhat.com> (Eric Blake's message of "Mon, 15 May 2017 16:41:13 -0500")
Eric Blake <eblake@redhat.com> writes:
> Time to wire up all the call sites that request a shutdown or
> reset to use the enum added in the previous patch.
>
> It would have been less churn to keep the common case with no
> arguments as meaning guest-triggered, and only modified the
> host-triggered code paths, via a wrapper function, but then we'd
> still have to audit that I didn't miss any host-triggered spots;
> changing the signature forces us to double-check that I correctly
> categorized all callers.
>
> Since command line options can change whether a guest reset request
> causes an actual reset vs. a shutdown, it's easy to also add the
> information to reset requests.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Acked-by: David Gibson <david@gibson.dropbear.id.au> [ppc parts]
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> [SPARC part]
> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com> [s390x parts]
>
> ---
> v8: rebase later in series
That turned out nicely. Thanks!
Reviewed-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
"open list:Overall" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Alexander Graf <agraf@suse.de>,
Yongbok Kim <yongbok.kim@imgtec.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Rob Herring <robh@kernel.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Anthony Perard <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>,
Richard Henderson <rth@twiddle.net>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Weil <sw@weilnetz.de>,
alistair.francis@xilinx.com,
"open list:Calxeda Highbank" <qemu-arm@nongnu.org>,
Jan Kiszka <jan.kiszka@web.de>,
Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,
Igor Mammedov <imammedo@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
Paul Burton <paul.burton@imgtec.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Michael Walle <michael@walle.cc>,
"open list:Old World" <qemu-ppc@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET
Date: Tue, 16 May 2017 10:46:57 +0200 [thread overview]
Message-ID: <87y3txfata.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170515214114.15442-5-eblake@redhat.com> (Eric Blake's message of "Mon, 15 May 2017 16:41:13 -0500")
Eric Blake <eblake@redhat.com> writes:
> Time to wire up all the call sites that request a shutdown or
> reset to use the enum added in the previous patch.
>
> It would have been less churn to keep the common case with no
> arguments as meaning guest-triggered, and only modified the
> host-triggered code paths, via a wrapper function, but then we'd
> still have to audit that I didn't miss any host-triggered spots;
> changing the signature forces us to double-check that I correctly
> categorized all callers.
>
> Since command line options can change whether a guest reset request
> causes an actual reset vs. a shutdown, it's easy to also add the
> information to reset requests.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Acked-by: David Gibson <david@gibson.dropbear.id.au> [ppc parts]
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> [SPARC part]
> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com> [s390x parts]
>
> ---
> v8: rebase later in series
That turned out nicely. Thanks!
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2017-05-16 8:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 21:41 [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN Eric Blake
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 1/5] shutdown: Simplify shutdown_signal Eric Blake
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request Eric Blake
2017-05-15 21:41 ` Eric Blake
2017-05-16 8:40 ` [Qemu-devel] " Markus Armbruster
2017-05-16 8:40 ` Markus Armbruster
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay Eric Blake
2017-05-16 8:43 ` Markus Armbruster
2017-05-15 21:41 ` [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET Eric Blake
2017-05-15 21:41 ` Eric Blake
2017-05-15 21:41 ` [Qemu-devel] " Eric Blake
2017-05-15 21:41 ` Eric Blake
2017-05-16 8:46 ` [Qemu-devel] " Markus Armbruster
2017-05-16 8:46 ` Markus Armbruster [this message]
2017-05-16 8:46 ` Markus Armbruster
2017-05-16 8:46 ` Markus Armbruster
2017-05-15 21:41 ` [Qemu-devel] [PATCH v9 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events Eric Blake
2017-05-16 8:49 ` Markus Armbruster
2017-05-16 11:43 ` [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3txfata.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=anthony.perard@citrix.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jcmvbkbc@gmail.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul.burton@imgtec.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xenproject.org \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.