From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, amit.shah@redhat.com,
zhang.zhanghailiang@huawei.com
Subject: Re: [Qemu-devel] [PATCH 2/2] postcopy: Recover block devices on early failure
Date: Thu, 02 Feb 2017 17:45:43 +0100 [thread overview]
Message-ID: <8737fwr16w.fsf@emacs.mitica> (raw)
In-Reply-To: <20170202155909.31784-3-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 2 Feb 2017 15:59:09 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> An early postcopy failure can be recovered from as long as we know
> we haven't sent the command to run the destination.
> We have to undo the bdrv_inactivate_all by calling
> bdrv_invalidate_cache_all
>
> Note that I'm not using ms->block_inactive because once we've
> sent the postcopy package we dont want anything else to try
> and recover the block storage on the source; the destination
> might have started writing to it.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2017-02-02 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 15:59 [Qemu-devel] [PATCH 0/2] Postcopy fixes Dr. David Alan Gilbert (git)
2017-02-02 15:59 ` [Qemu-devel] [PATCH 1/2] Postcopy: Reset state to avoid cleanup assert Dr. David Alan Gilbert (git)
2017-02-02 16:45 ` Juan Quintela
2017-02-02 15:59 ` [Qemu-devel] [PATCH 2/2] postcopy: Recover block devices on early failure Dr. David Alan Gilbert (git)
2017-02-02 16:45 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737fwr16w.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.