From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, amit.shah@redhat.com,
zhang.zhanghailiang@huawei.com
Subject: Re: [Qemu-devel] [PATCH 1/2] Postcopy: Reset state to avoid cleanup assert
Date: Thu, 02 Feb 2017 17:45:28 +0100 [thread overview]
Message-ID: <877f58r17b.fsf@emacs.mitica> (raw)
In-Reply-To: <20170202155909.31784-2-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 2 Feb 2017 15:59:08 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> On a destination host with no userfault support an incoming
> postcopy would cause the state to enter ADVISE before
> it realised there was no support, and because it was in ADVISE
> state it would perform a cleanup at the end. Since there
> was no support the cleanup function should be unreachable,
> but ends up being called and asserting.
>
> Reset the state when we realise we have no support, thus the
> cleanup doesn't happen.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2017-02-02 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 15:59 [Qemu-devel] [PATCH 0/2] Postcopy fixes Dr. David Alan Gilbert (git)
2017-02-02 15:59 ` [Qemu-devel] [PATCH 1/2] Postcopy: Reset state to avoid cleanup assert Dr. David Alan Gilbert (git)
2017-02-02 16:45 ` Juan Quintela [this message]
2017-02-02 15:59 ` [Qemu-devel] [PATCH 2/2] postcopy: Recover block devices on early failure Dr. David Alan Gilbert (git)
2017-02-02 16:45 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f58r17b.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.