* [Qemu-trivial] [PATCH] qemu-options.hx: Specify the units for -machine kvm_shadow_mem
@ 2016-05-10 15:49 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-05-10 15:49 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: patches
The -machine kvm_shadow_mem option takes a size in bytes; say
so explicitly in its documentation.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reported-by: Tobi (github.com/tobimensch)
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 6106520..0b86d9f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -35,7 +35,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \
" kernel_irqchip=on|off controls accelerated irqchip support\n"
" kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)\n"
" vmport=on|off|auto controls emulation of vmport (default: auto)\n"
- " kvm_shadow_mem=size of KVM shadow MMU\n"
+ " kvm_shadow_mem=size of KVM shadow MMU in bytes\n"
" dump-guest-core=on|off include guest memory in a core dump (default=on)\n"
" mem-merge=on|off controls memory merge support (default: on)\n"
" iommu=on|off controls emulated Intel IOMMU (VT-d) support (default=off)\n"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] qemu-options.hx: Specify the units for -machine kvm_shadow_mem
@ 2016-05-10 15:49 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-05-10 15:49 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: patches
The -machine kvm_shadow_mem option takes a size in bytes; say
so explicitly in its documentation.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reported-by: Tobi (github.com/tobimensch)
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 6106520..0b86d9f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -35,7 +35,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \
" kernel_irqchip=on|off controls accelerated irqchip support\n"
" kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)\n"
" vmport=on|off|auto controls emulation of vmport (default: auto)\n"
- " kvm_shadow_mem=size of KVM shadow MMU\n"
+ " kvm_shadow_mem=size of KVM shadow MMU in bytes\n"
" dump-guest-core=on|off include guest memory in a core dump (default=on)\n"
" mem-merge=on|off controls memory merge support (default: on)\n"
" iommu=on|off controls emulated Intel IOMMU (VT-d) support (default=off)\n"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-options.hx: Specify the units for -machine kvm_shadow_mem
2016-05-10 15:49 ` [Qemu-devel] " Peter Maydell
@ 2016-05-11 7:33 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2016-05-11 7:33 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-trivial, patches
Peter Maydell <peter.maydell@linaro.org> writes:
> The -machine kvm_shadow_mem option takes a size in bytes; say
> so explicitly in its documentation.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reported-by: Tobi (github.com/tobimensch)
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 6106520..0b86d9f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -35,7 +35,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \
> " kernel_irqchip=on|off controls accelerated irqchip support\n"
> " kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)\n"
> " vmport=on|off|auto controls emulation of vmport (default: auto)\n"
> - " kvm_shadow_mem=size of KVM shadow MMU\n"
> + " kvm_shadow_mem=size of KVM shadow MMU in bytes\n"
> " dump-guest-core=on|off include guest memory in a core dump (default=on)\n"
> " mem-merge=on|off controls memory merge support (default: on)\n"
> " iommu=on|off controls emulated Intel IOMMU (VT-d) support (default=off)\n"
Won't hurt, but makes me wonder: we have several size-valued option
parameters where we don't bother to clarify the unit in the description.
Sometimes the param=value string gives a hint, e.g. sndbuf=nbytes.
Things would be less confusing if the suffixless unit of a size was the
same everywhere, but we've screwed that up pretty comprehensively.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-options.hx: Specify the units for -machine kvm_shadow_mem
@ 2016-05-11 7:33 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2016-05-11 7:33 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-trivial, patches
Peter Maydell <peter.maydell@linaro.org> writes:
> The -machine kvm_shadow_mem option takes a size in bytes; say
> so explicitly in its documentation.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reported-by: Tobi (github.com/tobimensch)
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 6106520..0b86d9f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -35,7 +35,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \
> " kernel_irqchip=on|off controls accelerated irqchip support\n"
> " kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)\n"
> " vmport=on|off|auto controls emulation of vmport (default: auto)\n"
> - " kvm_shadow_mem=size of KVM shadow MMU\n"
> + " kvm_shadow_mem=size of KVM shadow MMU in bytes\n"
> " dump-guest-core=on|off include guest memory in a core dump (default=on)\n"
> " mem-merge=on|off controls memory merge support (default: on)\n"
> " iommu=on|off controls emulated Intel IOMMU (VT-d) support (default=off)\n"
Won't hurt, but makes me wonder: we have several size-valued option
parameters where we don't bother to clarify the unit in the description.
Sometimes the param=value string gives a hint, e.g. sndbuf=nbytes.
Things would be less confusing if the suffixless unit of a size was the
same everywhere, but we've screwed that up pretty comprehensively.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] qemu-options.hx: Specify the units for -machine kvm_shadow_mem
2016-05-10 15:49 ` [Qemu-devel] " Peter Maydell
@ 2016-05-29 8:13 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2016-05-29 8:13 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-29 8:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-10 15:49 [Qemu-trivial] [PATCH] qemu-options.hx: Specify the units for -machine kvm_shadow_mem Peter Maydell
2016-05-10 15:49 ` [Qemu-devel] " Peter Maydell
2016-05-11 7:33 ` [Qemu-trivial] " Markus Armbruster
2016-05-11 7:33 ` Markus Armbruster
2016-05-29 8:13 ` [Qemu-trivial] " Michael Tokarev
2016-05-29 8:13 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.