From: Jani Nikula <jani.nikula@intel.com>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] Convert INTEL_INFO(...)->gen to INTEL_GEN(...)
Date: Fri, 08 Apr 2016 11:24:25 +0300 [thread overview]
Message-ID: <8737qwwls6.fsf@intel.com> (raw)
In-Reply-To: <1460046136-3384-1-git-send-email-david.s.gordon@intel.com>
On Thu, 07 Apr 2016, Dave Gordon <david.s.gordon@intel.com> wrote:
> Since Jani has given us this macro, I thought I'd make use of it by
> converting all existing instances of this construct with a really
> simple little Coccinelle script:
>
> @intel_gen@
> expression E;
> @@
> <...
> - INTEL_INFO(E)->gen
> + INTEL_GEN(E)
> ...>
I intentionally did not do this because I think it causes more trouble
than it's worth. Basically this will conflict with roughly all patches
currently in flight. Yes, I admit I did tell people to go wild, but
please let's do this piecemeal.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-08 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 9:48 [PATCH] drm/i915: add INTEL_GEN() helper shorthand for INTEL_INFO()->gen Jani Nikula
2016-04-07 9:52 ` Chris Wilson
2016-04-07 13:56 ` Jani Nikula
2016-04-07 16:22 ` [RFC] Convert INTEL_INFO(...)->gen to INTEL_GEN(...) Dave Gordon
2016-04-08 8:24 ` Jani Nikula [this message]
2016-04-11 8:40 ` Dave Gordon
2016-04-13 12:32 ` [PATCH] drm/i915: add INTEL_GEN() helper shorthand for INTEL_INFO()->gen Jani Nikula
2016-04-07 13:29 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-08 7:07 ` ✗ Fi.CI.BAT: failure for drm/i915: add INTEL_GEN() helper shorthand for INTEL_INFO()->gen (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737qwwls6.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.