From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add INTEL_GEN() helper shorthand for INTEL_INFO()->gen
Date: Thu, 07 Apr 2016 16:56:26 +0300 [thread overview]
Message-ID: <8760vtwmid.fsf@intel.com> (raw)
In-Reply-To: <20160407095234.GA18061@nuc-i3427.alporthouse.com>
On Thu, 07 Apr 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Apr 07, 2016 at 12:48:17PM +0300, Jani Nikula wrote:
>> Sudden realization:
>>
>> $ grep -ho "INTEL_INFO([^)]*)->[a-zA-Z0-9_]*" *.[ch] | sed 's/.*->//' |\
>> sort | uniq -c | sort -rn | head -5
>> 446 gen
>> 24 num_pipes
>> 10 ring_mask
>> 9 color
>> 4 subslice_per_slice
>
> Yes, we did get a bit carried away over the years. In the beginning, it
> was IS_G4X this, IS_IGDNG that and only rarely IS_GEN()!
>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed to drm-intel-next-queued, everybody go wild and start
using it.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-07 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 9:48 [PATCH] drm/i915: add INTEL_GEN() helper shorthand for INTEL_INFO()->gen Jani Nikula
2016-04-07 9:52 ` Chris Wilson
2016-04-07 13:56 ` Jani Nikula [this message]
2016-04-07 16:22 ` [RFC] Convert INTEL_INFO(...)->gen to INTEL_GEN(...) Dave Gordon
2016-04-08 8:24 ` Jani Nikula
2016-04-11 8:40 ` Dave Gordon
2016-04-13 12:32 ` [PATCH] drm/i915: add INTEL_GEN() helper shorthand for INTEL_INFO()->gen Jani Nikula
2016-04-07 13:29 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-08 7:07 ` ✗ Fi.CI.BAT: failure for drm/i915: add INTEL_GEN() helper shorthand for INTEL_INFO()->gen (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760vtwmid.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.