Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

[Markus Armbruster <armbru@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On 8 February 2016 at 17:39, Markus Armbruster <armbru@redhat.com> wrote:
>> Eric Blake <eblake@redhat.com> writes:
>>
>>> As a followup to commit cbf2115, clean up the includes in files
>>> generated by QAPI so that osdep.h is included first in .c files,
>>> and headers which it implies are not included manually.  This
>>> patch is done manually, since Coccinelle (and therefore
>>> scripts/clean-includes) doesn't see into the generator scripts.
>>>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>
>>   CC    tests/check-qfloat.o
>> In file included from /home/armbru/work/qemu/include/qapi/qmp/qobject.h:37:0,
>>                  from /home/armbru/work/qemu/include/qapi/qmp/qfloat.h:18,
>>                  from /home/armbru/work/qemu/tests/check-qfloat.c:15:
>> ./qapi-types.h:55:9: error: unknown type name ‘bool’
>>          bool value;
>>          ^
>>
>> Chicken and egg problem?  check-qfloat.c doesn't include osdep.h, yet...
>
> Easy enough to add it; I have 'run clean-includes on tests/' on
> my todo list, but it requires a little care because I think at
> least some .c files in tests/ do not have QEMU headers in their
> include path at all. This might just be tests/tcg/.

With "make check" fixed:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

I'm happy to take it through my tree when it's ready (tell me then), but
it might be easier to take it along whatever fixes "make check".